Re: [PATCH v6 07/10] tty: serial: Add Cortina UART driver

[sashiko-bot@kernel.org]

> From: Fil Dunsky <filipp.dunsky@gmail.com>
> 
> Add a driver for the UART found in Cortina SoCs, starting with the
> Cortina Systems CS75xx (Goldengate G2) family such as the CS7542. The
> block has transmit and receive FIFOs with full/empty status, a 24-bit
> baud rate divider clocked from the peripheral (APB) clock, a receive
> sampling point register and one interrupt line per port with per-cause
> enable and write-one-to-clear status registers.
> 
> The same block, with an additional flow control register and a few more
> interrupt causes, is used in the Cortina Access CAxxxx SoCs, which were
> briefly supported by commit b61c8bf4694b ("tty: serial: Add UART driver
> for Cortina-Access platform") before it was removed again. The driver
> is therefore named after the vendor rather than one SoC, so that those
> parts can be added with their own compatible strings.
> 
> The driver is a rewrite of the vendor driver shipped with the Linux
> 2.6.36 and 4.9 based vendor kernels, using the current serial core API
> (uart_port_tx(), port lock helpers, deferred sysrq handling) and devm
> resource management. It supports the system console and earlycon.
> Hardware flow control is not supported.
> 
> The ports are named ttyCS so that the driver can coexist with the 8250
> driver in multiplatform kernels, where the 8250 core registers ttyS0
> and up even without any 8250 hardware, and PORT_GENERIC is used rather
> than allocating a new port type.
> 
> Signed-off-by: Fil Dunsky <filipp.dunsky@gmail.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261013-b4-cs75xx-v6-0-37e8f3969b7c@gmail.com?part=7