Re: [PATCH v2 13/13] media: sony-starvis2: Add support for IMX585

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] media: duplicate .active_area initialization in imx585_variant_def leaves .native_area zeroed
--

commit 189fbc745613583120b9ef2ff05d5e60a02d4cb3
Author: Dave Stevenson <dave.stevenson@raspberrypi.com>

media: sony-starvis2: Add support for IMX585

This commit adds support for the IMX585 8MPix Starvis 2 sensor.

> diff --git a/drivers/media/i2c/sony-starvis2.c b/drivers/media/i2c/sony-starvis2.c
> index 1ce2b86c57acc..c9a3dd4fe529b 100644
> --- a/drivers/media/i2c/sony-starvis2.c
> +++ b/drivers/media/i2c/sony-starvis2.c

[ ... ]

> +const struct starvis2_variant imx585_variant_def = {
> +	.name = "imx585",
> +	.id_reg = CCI_REG16_LE(0x5a1d),
> +	.id_mask = 0x3ff,
> +	.id_value = 0x259,
> +	.active_area = {
> +		.top = 0,
> +		.left = 0,
> +		.width = 3857,
> +		.height = 2201,
> +	},
> +	.active_area = {
> +		.top = 20,
> +		.left = 0,
> +		.width = 3856,
> +		.height = 2180,
> +	},

[Severity: High]
Does this code inadvertently leave .native_area uninitialized?

By defining .active_area twice, the second definition overwrites the first,
leaving .native_area implicitly zero-initialized. When userspace queries
V4L2_SEL_TGT_NATIVE_SIZE via starvis2_get_selection(), it will inadvertently
receive a 0x0 native area.

Was the first .active_area initialization intended to be .native_area?

> +	.pixel_rate = 594000000,
> +	.pix_per_clk = 8,
> +	.common_regs = imx585_common_regs,
> +	.num_common_regs = ARRAY_SIZE(imx585_common_regs),
> +	.vmax_default = 2250,
> +	.hmax_min_link_freq = imx585_min_hmax_2lane,
> +	.hmax_min_pixel_array = 550,
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261013-media-starvis2-v2-0-3670722d250a@raspberrypi.com?part=13