Re: [PATCH v2 01/13] media: imx678: Rework into generic Starvis 2 sensor driver.

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [High] kconfig: VIDEO_IMX678 selects VIDEO_SONY_STARVIS2 without inheriting GPIOLIB dependency
- [High] build: missing removal of imx678.o from Makefile causes build failure
--

commit 1c5c35700f9fe2a06860a9b3d153305723dc7e5f
Author: Dave Stevenson <dave.stevenson@raspberrypi.com>

media: imx678: Rework into generic Starvis 2 sensor driver.

The register layout and programming model for multiple of the
Sony Starvis2 sensors is identical, so prepare for supporting
those by renaming all common parts of the driver to a starvis2_
prefix, and renaming the driver.

> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
> --- a/drivers/media/i2c/Kconfig
> +++ b/drivers/media/i2c/Kconfig
> @@ -323,14 +323,11 @@ config VIDEO_IMX576
>  
>  config VIDEO_IMX678
>  	tristate "Sony IMX678 sensor support"
> -	depends on GPIOLIB
> -	select V4L2_CCI_I2C
> +	select VIDEO_SONY_STARVIS2

[Severity: High]
Does selecting VIDEO_SONY_STARVIS2 without inheriting its GPIOLIB dependency
cause Kconfig warnings or build failures? The VIDEO_SONY_STARVIS2 symbol added
below explicitly depends on GPIOLIB, so enabling VIDEO_IMX678 on a platform
without GPIOLIB would forcefully enable the target driver and could lead to
unmet direct dependencies.

>  	help
>  	  This is a Video4Linux2 sensor driver for the Sony
> -	  IMX678 camera.
> -
> -	  To compile this driver as a module, choose M here: the
> -	  module will be called imx678.
> +	  IMX678 camera. This sensor is now supported by the common
> +	  Sony Starvis 2 sensor driver.

[ ... ]

> @@ -879,6 +876,17 @@ config VIDEO_S5KJN5
>  	  To compile this driver as a module, choose M here: the
>  	  module will be called s5kjn5.
>  
> +config VIDEO_SONY_STARVIS2
> +	tristate "Sony Starvis 2 sensor support"
> +	depends on GPIOLIB
> +	select V4L2_CCI_I2C
> +	help
> +	  This is a Video4Linux2 sensor driver for the Sony Starvis
> +	  2 image sensors.
> +
> +	  To compile this driver as a module, choose M here: the
> +	  module will be called sony-starvis2.
> +

> diff --git a/drivers/media/i2c/Makefile b/drivers/media/i2c/Makefile
> --- a/drivers/media/i2c/Makefile
> +++ b/drivers/media/i2c/Makefile
> @@ -146,6 +146,7 @@ obj-$(CONFIG_VIDEO_SAA7127) += saa7127.o
>  obj-$(CONFIG_VIDEO_SAA717X) += saa717x.o
>  obj-$(CONFIG_VIDEO_SAA7185) += saa7185.o
>  obj-$(CONFIG_VIDEO_SONY_BTF_MPX) += sony-btf-mpx.o
> +obj-$(CONFIG_VIDEO_SONY_STARVIS2) += sony-starvis2.o

[Severity: High]
Does omitting the removal of the obj-$(CONFIG_VIDEO_IMX678) rule cause a
build failure? Since the source file imx678.c was renamed to sony-starvis2.c
and CONFIG_VIDEO_IMX678 remains in Kconfig for backwards compatibility, Kbuild
will attempt to build the non-existent imx678.o target.

>  obj-$(CONFIG_VIDEO_ST_MIPID02) += st-mipid02.o
>  obj-$(CONFIG_VIDEO_T4KA3) += t4ka3.o
>  obj-$(CONFIG_VIDEO_TC358743) += tc358743.o

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261013-media-starvis2-v2-0-3670722d250a@raspberrypi.com?part=1