Re: [PATCH v2 1/7] regulator: dt-bindings: ti,lp872x: Deprecate ti,dvs-gpio and ti,update-config

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: regulator: ti,lp872x: Deprecated ti,update-config remains in example
--

commit 308202c795df4f41c7d2f8aff005747332d2dc21
Author: Svyatoslav Ryhel <clamor95@gmail.com>

regulator: dt-bindings: ti,lp872x: Deprecate ti,dvs-gpio and ti,update-config

This commit marks ti,dvs-gpio and ti,update-config as deprecated in favor of
using dvs-gpios and the presence of ti,general-config as a trigger to update.

> diff --git a/Documentation/devicetree/bindings/regulator/ti,lp872x.yaml b/Documentation/devicetree/bindings/regulator/ti,lp872x.yaml
> index 8e74dbb3ae303..8216f1e3125d4 100644
> --- a/Documentation/devicetree/bindings/regulator/ti,lp872x.yaml
> +++ b/Documentation/devicetree/bindings/regulator/ti,lp872x.yaml
> @@ -47,10 +47,12 @@ properties:
>  
>    ti,update-config:
>      type: boolean
> +    deprecated: true
>      description: define it when LP872X_GENERAL_CFG register should be set

[Severity: Low]
Does this deprecated property need to be removed from the example block in this
binding?

Documentation/devicetree/bindings/regulator/ti,lp872x.yaml:examples
    examples:
      - |
        #include <dt-bindings/gpio/gpio.h>
    
        i2c {
            ...
            pmic@7a {
                compatible = "ti,lp8725";
                reg = <0x7a>;
    
                /* Enable BUCK1,2, no DVS, normal LDO mode, timestep is 256usec */
                ti,general-config = /bits/ 8 <0xdd>;
                ti,update-config;

Leaving deprecated properties in the example might encourage developers to
copy deprecated code into new device trees.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261013181417.492252-1-clamor95@gmail.com?part=1