Re: [PATCH v2 5/7] regulator: lp872x: Remove platform_data based probing

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] gpio: gpiod_set_value() called with enum gpiod_flags instead of logical integer
--

commit 66e7cc15bc21448dbaf8906353d687e2f61e221f
Author: Svyatoslav Ryhel <clamor95@gmail.com>

regulator: lp872x: Remove platform_data based probing

The platform_data-based probing is tightly integrated into the lp872x
driver structure itself; removing just the platform data support is
impossible without remodeling major parts of the probe sequence.
The lp872x_platform_data structure was removed, and its contents were
incorporated into the driver private structure and lp872x_chip_info.

> diff --git a/drivers/regulator/lp872x.c b/drivers/regulator/lp872x.c
> index 1e16d7e8361a0..50870ffe75ac5 100644
> --- a/drivers/regulator/lp872x.c
> +++ b/drivers/regulator/lp872x.c
[ ... ]
> @@ -344,10 +333,9 @@ static int lp872x_buck_set_voltage_sel(struct regulator_dev *rdev,
>  	struct lp872x *lp = rdev_get_drvdata(rdev);
>  	enum lp872x_regulator_id buck = rdev_get_id(rdev);
>  	u32 addr, mask = LP872X_VOUT_M;
> -	struct lp872x_dvs *dvs = lp->pdata ? lp->pdata->dvs : NULL;
>  
> -	if (dvs && dvs->gpio)
> -		lp872x_set_dvs(lp, dvs->vsel, dvs->gpio);
> +	if (lp->dvs_gpio)
> +		lp872x_set_dvs(lp, lp->vsel, lp->dvs_gpio);
>  
>  	addr = lp872x_select_buck_vout_addr(lp, buck);
>  	if (!lp872x_is_valid_buck_addr(addr))

[Severity: High]
This problem wasn't introduced by this patch, but the modification of the caller
in lp872x_buck_set_voltage_sel() retains a broken data path under the new driver
structure.

Does lp872x_set_dvs() incorrectly pass enum gpiod_flags to gpiod_set_value()?

Looking at lp872x_set_dvs(), it assigns enum values to state:

	state = dvs_sel == SEL_V1 ? GPIOD_OUT_HIGH : GPIOD_OUT_LOW;
	gpiod_set_value(gpio, state);

Because both GPIOD_OUT_HIGH and GPIOD_OUT_LOW evaluate to non-zero values,
gpiod_set_value() will always drive the GPIO high, breaking the dynamic voltage
scaling (DVS) state selection.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261013181417.492252-1-clamor95@gmail.com?part=5