Re: [PATCH v2 1/2] perf timechart: Add a --live mode to the TUI

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] perf: missing <string.h> inclusion for string functions
--

commit affd0db9a1d96743f8d4a342d96e560618e1bb09
Author: Alice Rogers <alice.mei.rogers@gmail.com>

perf timechart: Add a --live mode to the TUI

This commit adds a --live option to perf timechart and ttimechart.py that
runs perf record and displays the events interactively in the TUI.
It limits the display to the most recent window of history and allows
pausing or recording specific workloads.

> diff --git a/tools/perf/builtin-timechart.c b/tools/perf/builtin-timechart.c
> index 9eb335d9db167..d558ea656fe4f 100644
> --- a/tools/perf/builtin-timechart.c
> +++ b/tools/perf/builtin-timechart.c
[ ... ]
> @@ -2207,13 +2207,24 @@ int cmd_timechart(int argc, const char **argv)
>  		ret = -1;
>  		goto out;
>  	}
> +	if (tchart.io_only && (tchart.power_only || tchart.tasks_only)) {
> +		pr_err("-I cannot be used with -P or -T.\n");
> +		ret = -1;
> +		goto out;
> +	}
>  
> -	if (argc && strlen(argv[0]) > 2 && strstarts("record", argv[0])) {
> +	if (!tchart.live && argc && strlen(argv[0]) > 2 && strstarts("record", argv[0])) {

[Severity: Low]
Does this file need to explicitly include <string.h> for musl compatibility?
The perf subsystem guide mandates explicit inclusions of POSIX headers for libc
functions to ensure the tools can be compiled under musl, which strictly
separates declarations, unlike glibc. Since strlen() and strstarts() are used
here, should <string.h> be added to the includes at the top of the file?

>  		argc = parse_options(argc, argv, timechart_record_options,
>  				     timechart_record_usage,
>  				     PARSE_OPT_STOP_AT_NON_OPTION);

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261014042249.2379829-1-irogers@google.com?part=1