All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] usb: host: ehci-atmel: Use dev_dbg() for debug messages
@ 2026-10-14 12:16 Mihai Sain
  2026-10-14 12:19 ` sashiko-bot
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Mihai Sain @ 2026-10-14 12:16 UTC (permalink / raw)
  To: stern, gregkh, nicolas.ferre, alexandre.belloni, claudiu.beznea
  Cc: linux-usb, linux-arm-kernel, linux-kernel, Mihai Sain

Use dev_dbg() instead of pr_debug() in the probe function
to provide a more specific device message.
This ensures the log message is properly associated with
the corresponding platform device instance.

Signed-off-by: Mihai Sain <mihai.sain@microchip.com>
---
 drivers/usb/host/ehci-atmel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/host/ehci-atmel.c b/drivers/usb/host/ehci-atmel.c
index 65747270fd88..b6ba7005be69 100644
--- a/drivers/usb/host/ehci-atmel.c
+++ b/drivers/usb/host/ehci-atmel.c
@@ -99,7 +99,7 @@ static int ehci_atmel_drv_probe(struct platform_device *pdev)
 	if (usb_disabled())
 		return -ENODEV;
 
-	pr_debug("Initializing Atmel-SoC USB Host Controller\n");
+	dev_dbg(&pdev->dev, "Initializing Atmel-SoC USB Host Controller\n");
 
 	irq = platform_get_irq(pdev, 0);
 	if (irq < 0) {
-- 
2.56.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] usb: host: ehci-atmel: Use dev_dbg() for debug messages
  2026-10-14 12:16 [PATCH] usb: host: ehci-atmel: Use dev_dbg() for debug messages Mihai Sain
@ 2026-10-14 12:19 ` sashiko-bot
  2026-10-14 14:38 ` Alexander Dahl
  2026-10-14 14:45 ` Alan Stern
  2 siblings, 0 replies; 4+ messages in thread
From: sashiko-bot @ 2026-10-14 12:19 UTC (permalink / raw)
  To: Mihai Sain; +Cc: linux-usb

> Use dev_dbg() instead of pr_debug() in the probe function
> to provide a more specific device message.
> This ensures the log message is properly associated with
> the corresponding platform device instance.
> 
> Signed-off-by: Mihai Sain <mihai.sain@microchip.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261014121656.1634-1-mihai.sain@microchip.com?part=1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] usb: host: ehci-atmel: Use dev_dbg() for debug messages
  2026-10-14 12:16 [PATCH] usb: host: ehci-atmel: Use dev_dbg() for debug messages Mihai Sain
  2026-10-14 12:19 ` sashiko-bot
@ 2026-10-14 14:38 ` Alexander Dahl
  2026-10-14 14:45 ` Alan Stern
  2 siblings, 0 replies; 4+ messages in thread
From: Alexander Dahl @ 2026-10-14 14:38 UTC (permalink / raw)
  To: Mihai Sain
  Cc: stern, gregkh, nicolas.ferre, alexandre.belloni, claudiu.beznea,
	linux-usb, linux-arm-kernel, linux-kernel

Hello Mihai,

Am Wed, Oct 14, 2026 at 03:16:56PM +0300 schrieb Mihai Sain:
> Use dev_dbg() instead of pr_debug() in the probe function
> to provide a more specific device message.
> This ensures the log message is properly associated with
> the corresponding platform device instance.
> 
> Signed-off-by: Mihai Sain <mihai.sain@microchip.com>
> ---
>  drivers/usb/host/ehci-atmel.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/host/ehci-atmel.c b/drivers/usb/host/ehci-atmel.c
> index 65747270fd88..b6ba7005be69 100644
> --- a/drivers/usb/host/ehci-atmel.c
> +++ b/drivers/usb/host/ehci-atmel.c
> @@ -99,7 +99,7 @@ static int ehci_atmel_drv_probe(struct platform_device *pdev)
>  	if (usb_disabled())
>  		return -ENODEV;
>  
> -	pr_debug("Initializing Atmel-SoC USB Host Controller\n");
> +	dev_dbg(&pdev->dev, "Initializing Atmel-SoC USB Host Controller\n");
>  
>  	irq = platform_get_irq(pdev, 0);
>  	if (irq < 0) {

Reviewed-by: Alexander Dahl <ada@thorsis.com>

Greets
Alex



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] usb: host: ehci-atmel: Use dev_dbg() for debug messages
  2026-10-14 12:16 [PATCH] usb: host: ehci-atmel: Use dev_dbg() for debug messages Mihai Sain
  2026-10-14 12:19 ` sashiko-bot
  2026-10-14 14:38 ` Alexander Dahl
@ 2026-10-14 14:45 ` Alan Stern
  2 siblings, 0 replies; 4+ messages in thread
From: Alan Stern @ 2026-10-14 14:45 UTC (permalink / raw)
  To: Mihai Sain
  Cc: gregkh, nicolas.ferre, alexandre.belloni, claudiu.beznea,
	linux-usb, linux-arm-kernel, linux-kernel

On Wed, Oct 14, 2026 at 03:16:56PM +0300, Mihai Sain wrote:
> Use dev_dbg() instead of pr_debug() in the probe function
> to provide a more specific device message.
> This ensures the log message is properly associated with
> the corresponding platform device instance.
> 
> Signed-off-by: Mihai Sain <mihai.sain@microchip.com>
> ---

Acked-by: Alan Stern <stern@rowland.harvard.edu>

>  drivers/usb/host/ehci-atmel.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/host/ehci-atmel.c b/drivers/usb/host/ehci-atmel.c
> index 65747270fd88..b6ba7005be69 100644
> --- a/drivers/usb/host/ehci-atmel.c
> +++ b/drivers/usb/host/ehci-atmel.c
> @@ -99,7 +99,7 @@ static int ehci_atmel_drv_probe(struct platform_device *pdev)
>  	if (usb_disabled())
>  		return -ENODEV;
>  
> -	pr_debug("Initializing Atmel-SoC USB Host Controller\n");
> +	dev_dbg(&pdev->dev, "Initializing Atmel-SoC USB Host Controller\n");
>  
>  	irq = platform_get_irq(pdev, 0);
>  	if (irq < 0) {
> -- 
> 2.56.0
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-10-14 14:46 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-14 12:16 [PATCH] usb: host: ehci-atmel: Use dev_dbg() for debug messages Mihai Sain
2026-10-14 12:19 ` sashiko-bot
2026-10-14 14:38 ` Alexander Dahl
2026-10-14 14:45 ` Alan Stern

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.