Re: [PATCH v2 2/5] drm/panel: add Novatek NT36850 panel driver

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] drm/panel: uninitialized dsi_info causes empty secondary DSI device name
--

commit d78556555a8b667c80856e68aa43c5f0f311c5d4
Author: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>

drm/panel: add Novatek NT36850 panel driver

This commit adds support for the Truly WQHD dual-DSI command mode panel
using the Novatek NT36850 controller. It configures power sequences,
initialization commands, and secondary host registration.

> diff --git a/drivers/gpu/drm/panel/panel-novatek-nt36850.c b/drivers/gpu/drm/panel/panel-novatek-nt36850.c
> --- /dev/null
> +++ b/drivers/gpu/drm/panel/panel-novatek-nt36850.c
> [ ... ]
> +static const struct panel_desc truly_wqhd_desc = {
> +	.mode = &truly_wqhd_mode,
> +	.bpc = 8,
> +	.lanes = 4,
> +	.format = MIPI_DSI_FMT_RGB888,
> +	.mode_flags = MIPI_DSI_CLOCK_NON_CONTINUOUS | MIPI_DSI_MODE_LPM,
> +	.init_sequence = truly_wqhd_init_sequence,
> +	.is_dual_dsi = true,
> +};

[Severity: Medium]
Because the dsi_info struct field is completely omitted here, it is
zero-initialized by the compiler.

> [ ... ]
> +static int nt36850_probe(struct mipi_dsi_device *dsi)
> +{
> [ ... ]
> +	/* If the panel is dual dsi, register DSI1 */
> +	if (pinfo->desc->is_dual_dsi) {
> +		info = &pinfo->desc->dsi_info;
> [ ... ]
> +		dsi1_host = of_find_mipi_dsi_host_by_node(dsi1);
> +		of_node_put(dsi1);
> +		if (!dsi1_host)
> +			return dev_err_probe(dev, -EPROBE_DEFER, "cannot get secondary DSI host\n");
> +
> +		pinfo->dsi[1] = devm_mipi_dsi_device_register_full(dev, dsi1_host, info);

[Severity: Medium]
Does passing this zero-initialized info struct to
devm_mipi_dsi_device_register_full() cause a malformed sysfs representation?

The MIPI DSI core copies info->type into dsi->name. Since info->type is
empty, it results in an empty string as the device name, creating a broken
uevent modalias of MODALIAS=mipi: with no actual name.

Should truly_wqhd_desc be updated to include a valid string in .dsi_info
so the secondary device is properly represented?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261014-sdm845-hdk-v2-0-6d0b4b42f267@oss.qualcomm.com?part=2