Re: [PATCH v2 5/5] arm64: dts: qcom: sdm845-hdk: add display card overlay

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dts: qcom: sdm845-hdk: missing mode select line configuration
--

commit 054d071f82b9427b1a9e8eba69c5018761cb4d20
Author: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>

arm64: dts: qcom: sdm845-hdk: add display card overlay

This commit adds a device tree overlay for the SDM845 HDK to support a
Truly NT36850 WQHD dual-DSI panel.

> diff --git a/arch/arm64/boot/dts/qcom/sdm845-hdk-display-card.dtso b/arch/arm64/boot/dts/qcom/sdm845-hdk-display-card.dtso
> new file mode 100644
> index 0000000000000..1022ab096170f
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sdm845-hdk-display-card.dtso
[ ... ]
> +&tlmm {
> +	disp0_reset_n_active: disp0-reset-n-active-state {
> +		pins = "gpio6";
> +		function = "gpio";
> +		drive-strength = <8>;
> +		bias-disable;
> +	};
> +
> +	disp0_reset_n_suspend: disp0-reset-n-suspend-state {
> +		pins = "gpio6";
> +		function = "gpio";
> +		drive-strength = <2>;
> +		bias-pull-down;
> +	};
> +
> +	mdp_vsync: mdp-vsync-state {
> +		pins = "gpio10";
> +		function = "mdp_vsync";
> +		drive-strength = <2>;
> +		bias-pull-down;
> +	};
> +};

[Severity: Medium]
The commit message states "the mode select line driven low for the dual
port mode", but does the &tlmm node actually configure this?

There doesn't appear to be a gpio-hog definition or other configuration
here to statically drive the mode select line low. Without it, might the
dual-DSI panel fail to initialize correctly if the hardware defaults
to the single port mode?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261014-sdm845-hdk-v2-0-6d0b4b42f267@oss.qualcomm.com?part=5