Re: [PATCH 6.6.y 1/2] net/mlx5e: Don't store mlx5e_priv in mlx5e_dev devlink priv

[sashiko-bot@kernel.org]

> From: Saeed Mahameed <saeedm@nvidia.com>
> 
> [ Upstream commit 123eda2e5b1638e298e3a66bb1e64a8da92de5e1 ]
> 
> mlx5e_priv is an unstable structure that can be memset(0) if profile
> attaching fails, mlx5e_priv in mlx5e_dev devlink private is used to
> reference the netdev and mdev associated with that struct. Instead,
> store netdev directly into mlx5e_dev and get mdev from the containing
> mlx5_adev aux device structure.
> 
> This fixes a kernel oops in mlx5e_remove when switchdev mode fails due
> to change profile failure.
> 
> $ devlink dev eswitch set pci/0000:00:03.0 mode switchdev
> Error: mlx5_core: Failed setting eswitch to offloads.
> [ ... ]
>   Fix netif state handling), which makes probe registration-failure
>   unwind release resources even before netif_device_attach(). Patch 2
>   of this series ("net/mlx5e: Pass netdev to mlx5e_destroy_netdev instead
>   of priv") uses netdev-based destruction. ]
> Signed-off-by: Artem Dinaburg <artem@trailofbits.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261014191738.24034-1-artem@trailofbits.com?part=1