From: sashiko-bot@kernel.org
To: "Artem Dinaburg" <artem@trailofbits.com>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH 6.6.y 2/2] net/mlx5e: Pass netdev to mlx5e_destroy_netdev instead of priv
Date: Wed, 14 Oct 2026 19:34:01 +0000 [thread overview]
Message-ID: <sashiko-outbox-171794@kernel.org> (raw)
In-Reply-To: <20261014191738.24034-3-artem@trailofbits.com>
> From: Saeed Mahameed <saeedm@nvidia.com>
>
> [ Upstream commit 4ef8512e1427111f7ba92b4a847d181ff0aeec42 ]
>
> mlx5e_priv is an unstable structure that can be memset(0) if profile
> attaching fails.
>
> Pass netdev to mlx5e_destroy_netdev() to guarantee it will work on a
> valid netdev.
>
> On mlx5e_remove: Check validity of priv->profile, before attempting
> to cleanup any resources that might be not there.
>
> This fixes a kernel oops in mlx5e_remove when switchdev mode fails due
> to change profile failure.
> [ ... ]
> Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
> Link: https://patch.msgid.link/20260108212657.25090-4-saeed@kernel.org
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> Assisted-by: LLM
> Signed-off-by: Artem Dinaburg <artem@trailofbits.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261014191738.24034-1-artem@trailofbits.com?part=2
prev parent reply other threads:[~2026-10-14 19:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-14 19:17 [PATCH 6.6.y 0/2] CVE-2026-22996, CVE-2026-23035: backport fix series Artem Dinaburg
2026-10-14 19:17 ` [PATCH 6.6.y 1/2] net/mlx5e: Don't store mlx5e_priv in mlx5e_dev devlink priv Artem Dinaburg
2026-10-14 19:34 ` sashiko-bot
2026-10-14 19:17 ` [PATCH 6.6.y 2/2] net/mlx5e: Pass netdev to mlx5e_destroy_netdev instead of priv Artem Dinaburg
2026-10-14 19:34 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-171794@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=artem@trailofbits.com \
--cc=linux-rdma@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.