From: sashiko-bot@kernel.org
To: "Sreeshankar K" <sreeshankar0910@gmail.com>
Cc: linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v10 5/6] dt-bindings: cpufreq: qcom-hw: Document SM7250 cpufreq hardware
Date: Thu, 15 Oct 2026 05:26:12 +0000 [thread overview]
Message-ID: <sashiko-outbox-172305@kernel.org> (raw)
In-Reply-To: <20261015051926.13752-6-sreeshankar0910@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: missing allOf conditional constraint for qcom,sm7250-cpufreq-hw
--
commit 98b8b2444ed3f6041afd44a3665350b379c6ffc1
Author: Sreeshankar K <sreeshankar0910@gmail.com>
dt-bindings: cpufreq: qcom-hw: Document SM7250 cpufreq hardware
Document the cpufreq hardware on the SM7250 SoC.
> diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml b/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml
> index 98eb36bff1727..2dc2c265cac06 100644
> --- a/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml
> +++ b/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml
> @@ -29,6 +29,7 @@ properties:
> - qcom,sdm845-cpufreq-hw
> - qcom,sm6115-cpufreq-hw
> - qcom,sm6350-cpufreq-hw
> + - qcom,sm7250-cpufreq-hw
[Severity: Medium]
Does qcom,sm7250-cpufreq-hw also need to be added to the allOf conditional
blocks later in the file?
This binding schema strictly enforces constraints like the number of registers
(reg, reg-names) and interrupts (interrupts, interrupt-names) based on the
exact SoC variant using if-then blocks.
Because qcom,sm7250-cpufreq-hw is omitted from those conditionals, device
trees for the SM7250 variant might silently pass schema validation even if
they contain an incorrect number of registers or interrupts.
> - qcom,sm8150-cpufreq-hw
> - const: qcom,cpufreq-hw
>
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261015051926.13752-2-sreeshankar0910@gmail.com?part=5
next prev parent reply other threads:[~2026-10-15 5:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 5:19 Add initial support for Qualcomm SM7250 SoC Sreeshankar K
2026-10-15 5:19 ` [PATCH v10 1/6] dt-bindings: clock: Add SM7250 global clock controller Sreeshankar K
2026-10-15 5:19 ` [PATCH v10 2/6] clk: qcom: Add Global Clock Controller (GCC) driver for SM7250 Sreeshankar K
2026-10-15 5:34 ` sashiko-bot
2026-10-15 5:19 ` [PATCH v10 3/6] dt-bindings: firmware: qcom,scm: Document SM7250 SCM Sreeshankar K
2026-10-15 5:19 ` [PATCH v10 4/6] dt-bindings: interrupt-controller: qcom,pdc: Document SM7250 PDC Sreeshankar K
2026-10-15 5:19 ` [PATCH v10 5/6] dt-bindings: cpufreq: qcom-hw: Document SM7250 cpufreq hardware Sreeshankar K
2026-10-15 5:26 ` sashiko-bot [this message]
2026-10-15 5:19 ` [PATCH v10 6/6] arm64: dts: qcom: Add SM7250 devicetree file Sreeshankar K
2026-10-15 5:32 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-172305@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=sreeshankar0910@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.