Re: [PATCH v10 6/6] arm64: dts: qcom: Add SM7250 devicetree file

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dts: mismatched #address-cells with empty ranges property
--

commit d7254d0330c233afd2ea9eb553621c4b088c8ea0
Author: Sreeshankar K <sreeshankar0910@gmail.com>

arm64: dts: qcom: Add SM7250 devicetree file

This commit adds the base devicetree file for the SM7250 SoC, including basic
nodes like cpu, psci, and other required configurations for booting up to
the serial console.

> diff --git a/arch/arm64/boot/dts/qcom/sm7250.dtsi b/arch/arm64/boot/dts/qcom/sm7250.dtsi
> new file mode 100644
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sm7250.dtsi
[ ... ]
> +	soc: soc@0 {
> +		compatible = "simple-bus";
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		ranges = <0 0 0 0 0x10 0>;
> +		dma-ranges = <0 0 0 0 0x10 0>;
[ ... ]
> +		timer@17c20000 {
> +			compatible = "arm,armv7-timer-mem";
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +			ranges;

[Severity: Low]
The parent soc@0 node defines a 2-cell address space layout, but this child
node defines 1-cell addresses and uses an empty ranges property. According
to the Devicetree specification, an empty ranges property asserts that
parent and child address spaces are identically formatted.

Does this mismatch trigger a ranges_format dtc compiler warning?

While Linux of_translate_address() gracefully handles this by reading the
child's cells and zero-padding the parent's cells, could relying on
OS-specific parsing quirks for an invalid device tree structure break non-Linux
parsers like bootloaders?

Would it be better to resolve this by using an explicit translation mask,
such as ranges = <0 0 0 0x20000000>;?

> +			reg = <0x0 0x17c20000 0x0 0x1000>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261015051926.13752-2-sreeshankar0910@gmail.com?part=6