[PATCH] IB/rdmavt: Fix error unwind path for qp_priv_init() in rvt_create_qp()

[PATCH] IB/rdmavt: Fix error unwind path for qp_priv_init() in rvt_create_qp()

[Serhat Kumral]

If driver_f.qp_priv_init() fails, execution jumps to bail_rq_wq, which
bypasses bail_qpn. Because alloc_qpn() has already succeeded at this point,
the allocated QP number is left unreleased.

Jump to bail_qpn instead to ensure the QPN is properly freed via
rvt_free_qpn().

Fixes: 5190f052a3654 ("IB/hfi1: Allow the driver to initialize QP priv struct")
Assisted-by: LLM
Signed-off-by: Serhat Kumral <serhatkumral1@gmail.com>
---
found while investigating smatch warning:
- drivers/infiniband/sw/rdmavt/qp.c:1182 rvt_create_qp() warn: missing unwind goto? 

 drivers/infiniband/sw/rdmavt/qp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/sw/rdmavt/qp.c b/drivers/infiniband/sw/rdmavt/qp.c
index d8ee485c49a6..3602b9ff2196 100644
--- a/drivers/infiniband/sw/rdmavt/qp.c
+++ b/drivers/infiniband/sw/rdmavt/qp.c
@@ -1173,7 +1173,7 @@ int rvt_create_qp(struct ib_qp *ibqp, struct ib_qp_init_attr *init_attr,
 		if (rdi->driver_f.qp_priv_init) {
 			ret = rdi->driver_f.qp_priv_init(rdi, qp, init_attr);
 			if (ret)
-				goto bail_rq_wq;
+				goto bail_qpn;
 		}
 		break;
 
-- 
2.53.0

Re: [PATCH] IB/rdmavt: Fix error unwind path for qp_priv_init() in rvt_create_qp()

[sashiko-bot]

> If driver_f.qp_priv_init() fails, execution jumps to bail_rq_wq, which
> bypasses bail_qpn. Because alloc_qpn() has already succeeded at this point,
> the allocated QP number is left unreleased.
> 
> Jump to bail_qpn instead to ensure the QPN is properly freed via
> rvt_free_qpn().
> 
> Fixes: 5190f052a3654 ("IB/hfi1: Allow the driver to initialize QP priv struct")
> Assisted-by: LLM
> Signed-off-by: Serhat Kumral <serhatkumral1@gmail.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261015102518.15780-1-serhatkumral1@gmail.com?part=1