Re: [PATCH net-next v16 2/7] dt-bindings: net: qcom: document the ethqos device for SCMI-based systems

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: net: missed power-domains constraint in ultrarisc,dp1000-gmac.yaml
--

commit eaf763b0d0d309757c6cf7f9fe067155eb99eb11
Author: Bartosz Golaszewski <brgl@kernel.org>

dt-bindings: net: qcom: document the ethqos device for SCMI-based systems

This commit describes the firmware-managed variant of the QCom DesignWare MAC
in a separate file. It updates the top-level snps,dwmac.yaml to allow up to
two power domains and restricts existing referencing bindings to a maximum of
one power domain.

> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> index 2218a492817fd..2c4842404bf67 100644
> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml

[ ... ]

> @@ -187,7 +188,8 @@ properties:
>            - enum: [ahb, stmmaceth-ocp]
>  
>    power-domains:
> -    maxItems: 1
> +    minItems: 1
> +    maxItems: 2
>  
>    mac-mode:
>      $ref: ethernet-controller.yaml#/properties/phy-connection-type

[Severity: Low]
Was Documentation/devicetree/bindings/net/ultrarisc,dp1000-gmac.yaml missed in
the updates to other bindings?

The commit message states the intent to update existing bindings referencing
snps,dwmac.yaml to limit their maxItems for power-domains to 1. However,
ultrarisc,dp1000-gmac.yaml references snps,dwmac.yaml under its allOf node:

Documentation/devicetree/bindings/net/ultrarisc,dp1000-gmac.yaml:
allOf:
  - $ref: snps,dwmac.yaml#

Because the top-level snps,dwmac.yaml was relaxed to allow 2 power domains
here, and ultrarisc,dp1000-gmac.yaml lacks a local override, does it implicitly
inherit the newly relaxed limit of 2?

Could this cause a schema validation regression where device trees for the
hardware could incorrectly specify up to two power domains without failing
validation?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261014-qcom-sa8255p-emac-v16-0-0266c2ead980@oss.qualcomm.com?part=2

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic