Re: [PATCHv2 2/2] arm64: dts: altera: Add support for the Agilex27 platform

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
- [Medium] arm64: dts: altera: Missing VGIC maintenance interrupt in GICv3 node
- [Low] arm64: dts: altera: Unnecessary duplication of SoC DTSI file
- [Low] dt-bindings: arm: altera: Undocumented compatible strings for Agilex27
--

commit ef21748becf923e3ea0b9bb9bcd2a6ea73fa866e
Author: Dinh Nguyen <dinguyen@kernel.org>

    arm64: dts: altera: Add support for the Agilex27 platform
    
    The Agilex72 platform is being rebranded to Agilex27. The Agilex27 is
    exactly the same as the Agilex72. Add the base DTSI and the devkit's
    DTS.

diff --git a/arch/arm64/boot/dts/altera/socfpga_agilex27.dtsi b/arch/arm64/boot/dts/altera/socfpga_agilex27.dtsi
new file mode 100644
index 0000000000000..369981fe85e38
--- /dev/null
+++ b/arch/arm64/boot/dts/altera/socfpga_agilex27.dtsi
@@ -0,0 +1,156 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * Copyright (C) 2026, Altera Corporation
+ */
+/dts-v1/;
+#include <dt-bindings/interrupt-controller/arm-gic.h>
+#include <dt-bindings/interrupt-controller/irq.h>
+
+/ {
+	compatible = "altr,socfpga-agilex27";
+	#address-cells = <2>;
+	#size-cells = <2>;

[Severity: Low]
Since the commit message states that Agilex27 is exactly the same as
Agilex72, is it necessary to duplicate the entire SoC layout into a new
file? Could we include the existing socfpga_agilex72.dtsi or add this
compatible string directly to the Agilex72 device tree to avoid keeping the
two files in sync?

[Severity: Low]
Is this new compatible string documented in the corresponding devicetree
binding YAML files? Without it, running make dtbs_check will likely trigger
validation errors.

[ ... ]

> +	intc: interrupt-controller@7000000 {
> +		compatible = "arm,gic-v3";
> +		reg = <0x0 0x7000000 0x0 0x10000>,
> +		      <0x0 0x7080000 0x0 0x100000>;
> +		ranges;
> +		#interrupt-cells = <3>;
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		interrupt-controller;
> +		#redistributor-regions = <1>;
> +		redistributor-stride = <0x0 0x40000>;

[Severity: Medium]
Does this GICv3 node need the interrupts property for the VGIC maintenance
interrupt? 

Without it, KVM initialization via vgic_set_kvm_info() cannot proceed because
irq_of_parse_and_map() returns 0. Could this silently break KVM virtualization
support on this platform?

[ ... ]

diff --git a/arch/arm64/boot/dts/altera/socfpga_agilex27_socdk.dts b/arch/arm64/boot/dts/altera/socfpga_agilex27_socdk.dts
new file mode 100644
index 0000000000000..15d331cdeeb47
--- /dev/null
+++ b/arch/arm64/boot/dts/altera/socfpga_agilex27_socdk.dts
@@ -0,0 +1,27 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * Copyright (C) 2026, Altera Corporation
+ */
+#include "socfpga_agilex27.dtsi"
+
+/ {
+	model = "Altera SoCFPGA Agilex27 SoCDK";
+	compatible = "altr,socfpga-agilex27-socdk", "altr,socfpga-agilex27";

[Severity: Low]
Is the altr,socfpga-agilex27-socdk board-level compatible string documented
in the devicetree bindings?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261015123700.2137706-2-dinguyen@kernel.org?part=1