Re: [PATCH net 1/3] net/mlx5e: Sync CQE moderation pflags with coalesce params

[sashiko-bot@kernel.org]

> From: Yael Chemla <ychemla@nvidia.com>
> 
> mlx5e_params keeps two representations of CQE moderation: the private
> flags (MLX5E_PFLAG_RX_CQE_BASED_MODER, MLX5E_PFLAG_TX_CQE_BASED_MODER)
> and the fields rx_moder_use_cqe_mode / tx_moder_use_cqe_mode, which are
> used by ethtool get/set coalesce. Both are used by the driver (ethtool
> get/set coalesce, channel open, moderation apply). When they disagree,
> CQE moderation reported value is wrong.
> 
> Such an issue can be seen on channel attach or reopen:
> mlx5e_build_nic_params() runs and sets rx_moder_use_cqe_mode and
> tx_moder_use_cqe_mode from device capability but did not set the
> corresponding pflags. So after attach/reopen, pflags could remain zero
> while the fields reflected hardware configuration.
> 
> Fix by syncing pflags in build_nic_params from the capability-derived
> fields.
> 
> Reproducer:
> 
>     ethtool --show-priv-flags eth2 | grep rx_cqe_moder
>       rx_cqe_moder       : off
>     ethtool --coalesce eth2 adaptive-tx off
>     ethtool --show-priv-flags eth2 | grep rx_cqe_moder
>       rx_cqe_moder       : on
> 
> Fixes: 445a25f6e1a2 ("net/mlx5e: Support updating coalescing configuration without resetting channels")
> Signed-off-by: Yael Chemla <ychemla@nvidia.com>
> Reviewed-by: Dragos Tatulea <dtatulea@nvidia.com>
> Signed-off-by: Tariq Toukan <tariqt@nvidia.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261014124704.1017782-1-tariqt@nvidia.com?part=1