Re: [PATCH v10 3/3] arm: dts: altera: add Draeger M48 CPU Module

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] dts: socfpga: misplaced snps,dwmac-mdio compatible string breaks ethernet
--

commit 2a1e9ba4738dc175386bf567bcce3c8d3aa0f021
Author: Petko Manolov <petko.manolov@konsulko.com>
Subject: arm: dts: altera: add Draeger M48 CPU Module

This commit adds the device tree for the Altera SoCFPGA Cyclone 5 portion
of the Draeger M48 board.

> diff --git a/arch/arm/boot/dts/intel/socfpga/socfpga_cyclone5_draeger_m48.dts b/arch/arm/boot/dts/intel/socfpga/socfpga_cyclone5_draeger_m48.dts
> new file mode 100644
> index 0000000000000..f19e24c80e89a
> --- /dev/null
> +++ b/arch/arm/boot/dts/intel/socfpga/socfpga_cyclone5_draeger_m48.dts
[ ... ]
> +&gmac0 {
> +	status = "okay";
> +	phy-mode = "rgmii";
> +	phy-handle = <&ethphy>;
> +
> +	mdio0 {
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		ethphy: ethernet-phy@0 {
> +			compatible = "snps,dwmac-mdio";

[Severity: High]
Does this compatible string belong in the parent mdio0 node instead of the
PHY node?

During board boot, the STMMAC ethernet driver (stmmac_of_get_mdio()) attempts
to discover and register the MDIO bus by iterating over the MAC's direct
child nodes to find the one with the compatible = "snps,dwmac-mdio" property.

Because mdio0 lacks the compatible string, the driver fails to locate the
MDIO controller, leading to an aborted MDIO bus registration. Furthermore,
the PHY node is assigned a wrong compatible string (it should either be
omitted to let the generic PHY driver probe via PHY ID, or use a standard
PHY compatible like ethernet-phy-ieee802.3-c22).

Will this cause a complete failure of the Ethernet interface on this board?

> +			reg = <0>;
> +			rxc-skew-ps  = <1860>;
> +			rxd0-skew-ps = <0>;
> +			rxd1-skew-ps = <0>;
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261015131352.3624327-1-petko.manolov@konsulko.com?part=3