From: sashiko-bot@kernel.org
To: "Srinivas Kandagatla" <srinivas.kandagatla@oss.qualcomm.com>
Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
robh@kernel.org, conor+dt@kernel.org, lee@kernel.org
Subject: Re: [PATCH 2/4] leds: rgb: qcom-lpg: add qcom,pmk8850-pwm compatible
Date: Thu, 15 Oct 2026 19:51:51 +0000 [thread overview]
Message-ID: <sashiko-outbox-173368@kernel.org> (raw)
In-Reply-To: <20261015194732.64428-3-srinivas.kandagatla@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] leds: commit message description is not capitalized
--
commit fdffeb52b0445eebc400d36aacc9eefa0dff0de2
Author: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
leds: rgb: qcom-lpg: add qcom,pmk8850-pwm compatible
This commit adds support for the PMK8850 sleep-clock PMIC on the Snapdragon
X2 Elite by reusing the PMK8550 PWM data. This enables the eDP backlight on
devices such as the Lenovo ThinkPad T14s Gen 7.
> leds: rgb: qcom-lpg: add qcom,pmk8850-pwm compatible
[Severity: Low]
This isn't a bug, but the LED subsystem guidelines request that the commit
description following the subsystem prefix is capitalized. Could the word
add be changed to Add to follow this naming convention?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261015194732.64428-1-srinivas.kandagatla@oss.qualcomm.com?part=2
next prev parent reply other threads:[~2026-10-15 19:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 19:47 [PATCH 0/4] Mahua T14s Gen 7 eDP backlight via PMK8850 LPG Srinivas Kandagatla
2026-10-15 19:47 ` [PATCH 1/4] dt-bindings: leds: qcom-lpg: add qcom,pmk8850-pwm compatible Srinivas Kandagatla
2026-10-15 19:54 ` sashiko-bot
2026-10-15 19:47 ` [PATCH 2/4] leds: rgb: " Srinivas Kandagatla
2026-10-15 19:51 ` sashiko-bot [this message]
2026-10-15 19:47 ` [PATCH 3/4] arm64: dts: qcom: pmk8850: add PWM node Srinivas Kandagatla
2026-10-15 19:53 ` sashiko-bot
2026-10-15 19:47 ` [PATCH 4/4] arm64: dts: qcom: mahua-t14s: wire backlight through pmk8850 pwm Srinivas Kandagatla
2026-10-15 19:54 ` sashiko-bot
2026-10-16 8:50 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-173368@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=srinivas.kandagatla@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.