From: sashiko-bot@kernel.org
To: "Srinivas Kandagatla" <srinivas.kandagatla@oss.qualcomm.com>
Cc: linux-leds@vger.kernel.org, lee@kernel.org
Subject: Re: [PATCH 4/4] arm64: dts: qcom: mahua-t14s: wire backlight through pmk8850 pwm
Date: Thu, 15 Oct 2026 19:54:14 +0000 [thread overview]
Message-ID: <sashiko-outbox-173370@kernel.org> (raw)
In-Reply-To: <20261015194732.64428-5-srinivas.kandagatla@oss.qualcomm.com>
> Move TLMM 18 (EDP_BL_EN) out of the panel node into a pwm-backlight
> node and wire real brightness control through the pmk8850 PWMR output
> (EDP_BL/PWMR_BV_PS on the schematic).
>
> panel-edp was asserting EDP_BL_EN before eDP link training, turning the
> backlight on ahead of video. With a dedicated backlight node the
> framework toggles EDP_BL_EN after the link is up; TLMM 18 remains the
> LED-driver enable, now gated correctly.
>
> The panel takes only its 3.3 V logic supply and references the
> backlight via a phandle. Brightness drives the LPG/PWM channel on
> pmk8850 routed out via pmk8850_gpios gpio5 (func3).
>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261015194732.64428-1-srinivas.kandagatla@oss.qualcomm.com?part=4
next prev parent reply other threads:[~2026-10-15 19:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 19:47 [PATCH 0/4] Mahua T14s Gen 7 eDP backlight via PMK8850 LPG Srinivas Kandagatla
2026-10-15 19:47 ` [PATCH 1/4] dt-bindings: leds: qcom-lpg: add qcom,pmk8850-pwm compatible Srinivas Kandagatla
2026-10-15 19:54 ` sashiko-bot
2026-10-15 19:47 ` [PATCH 2/4] leds: rgb: " Srinivas Kandagatla
2026-10-15 19:51 ` sashiko-bot
2026-10-15 19:47 ` [PATCH 3/4] arm64: dts: qcom: pmk8850: add PWM node Srinivas Kandagatla
2026-10-15 19:53 ` sashiko-bot
2026-10-15 19:47 ` [PATCH 4/4] arm64: dts: qcom: mahua-t14s: wire backlight through pmk8850 pwm Srinivas Kandagatla
2026-10-15 19:54 ` sashiko-bot [this message]
2026-10-16 8:50 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-173370@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=srinivas.kandagatla@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.