Re: [PATCH v9 7/7] drm/xe/ras: Move xe_ras_process_errors() to xe_ras

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] drm/xe: early wedging from ras drops uevent and aborts probe
--

commit 4c0f3e5505fa3f5df25ea28082e7cca0e36630d7
Author: Raag Jadav <raag.jadav@intel.com>

drm/xe/ras: Move xe_ras_process_errors() to xe_ras

This commit moves xe_ras_process_errors() back to xe_ras_init(), reverting
a previous change now that xe_wedge_fini() is handled earlier in the probe.

> diff --git a/drivers/gpu/drm/xe/xe_ras.c b/drivers/gpu/drm/xe/xe_ras.c
> index 0072bb4cc5dfe..db3cbc186a514 100644
> --- a/drivers/gpu/drm/xe/xe_ras.c
> +++ b/drivers/gpu/drm/xe/xe_ras.c
> @@ -1212,6 +1212,13 @@ int xe_ras_init(struct xe_device *xe)
>  	get_offline_list(xe);
>  	get_offline_queue(xe);
>  
> +	/*
> +	 * During probe, process and log any errors detected by firmware while the driver was not
> +	 * loaded. Critical errors such as Punit and CSC are reported through Pcode init failure,
> +	 * causing the driver to enter survivability mode.
> +	 */
> +	xe_ras_process_errors(xe);

[Severity: High]
Does moving this call to xe_ras_init() early in the probe sequence cause
issues when encountering a critical error?

If xe_ras_process_errors() finds a critical error, it declares the device
wedged, which schedules wedged.work.

This work calls drm_dev_wedged_event() which sends a uevent. However, since
drm_dev_register() has not yet run at this point, the kobject is not
in sysfs and the uevent will be silently dropped.

Furthermore, will declaring the device wedged this early cause subsequent
probe steps to fail? For example:

xe_gt_init()
  xe_uc_load_hw()
    xe_guc_pc_start()
      pc_action_reset()
        xe_guc_ct_send()

xe_guc_ct_send() will return -ENOTRECOVERABLE instead of -ECANCELED
because the device is wedged. This error propagates up, completely aborting
xe_device_probe(), causing the driver to unbind rather than entering
survivability mode as intended.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261016031559.427941-1-raag.jadav@intel.com?part=7