Re: [PATCH v2 04/25] ASoC: amd: raven: Fix acp3x_dma_close() being skipped on rollback

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] sound: memory leak of runtime->private_data in acp3x_dma_close()
--

commit f9bf5629ed83739ae2130cf6fe20e488a93aca99
Author: bui duc phuc <phucduc.bui@gmail.com>

ASoC: amd: raven: Fix acp3x_dma_close() being skipped on rollback

The commit ensures that acp3x_dma_open() explicitly returns 0 on success.
This prevents ASoC from skipping the .close() callback during rollback when
snd_pcm_hw_constraint_integer() returns 1.

> diff --git a/sound/soc/amd/raven/acp3x-pcm-dma.c b/sound/soc/amd/raven/acp3x-pcm-dma.c
> index 37ea5c572eb94..7650574990210 100644
> --- a/sound/soc/amd/raven/acp3x-pcm-dma.c
> +++ b/sound/soc/amd/raven/acp3x-pcm-dma.c
> @@ -237,7 +237,13 @@ static int acp3x_dma_open(struct snd_soc_component *component,
>  
>  	i2s_data->acp3x_base = adata->acp3x_base;
>  	runtime->private_data = i2s_data;
> -	return ret;
> +
> +	/*
> +	 * ASoC only marks the component as opened when .open() returns 0.
> +	 * Since snd_pcm_hw_constraint_integer() may return 1, explicitly
> +	 * return 0 to ensure .close() is not skipped on rollback.
> +	 */
> +	return 0;

[Severity: High]
Does this code leak the i2s_data structure stored in runtime->private_data?

While this patch ensures that acp3x_dma_close() is not skipped on rollback,
acp3x_dma_close() does not appear to free the memory allocated in
acp3x_dma_open():

sound/soc/amd/raven/acp3x-pcm-dma.c:acp3x_dma_close() {
    ...
	ins = substream->runtime->private_data;
	if (!ins)
		return -EINVAL;

	if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
    ...
	}

	return 0;
}

Since there is no kfree(ins) in acp3x_dma_close(), repeatedly opening and
closing the stream could cause a memory leak.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261015014324.5569-1-phucduc.bui@gmail.com?part=4