Re: [PATCH v2 01/25] ASoC: amd: acp: Fix .close() being skipped on rollback

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] sound/soc/amd: raven: memory leak in acp3x_dma_close()
--

commit 85bba20e9cd8adc1bcd476d2122c1723541d8edd
Author: bui duc phuc <phucduc.bui@gmail.com>

ASoC: amd: acp: Fix .close() being skipped on rollback

snd_pcm_hw_constraint_integer() may return 1, which is then returned
from acp_dma_open(). ASoC only marks the component as opened when
.open() returns 0, so .close() can be skipped on rollback. Return 0
explicitly on success.

> diff --git a/sound/soc/amd/acp/acp-platform.c b/sound/soc/amd/acp/acp-platform.c
> index 6b1e18b31c1c6..f2c8853775ad3 100644
> --- a/sound/soc/amd/acp/acp-platform.c
> +++ b/sound/soc/amd/acp/acp-platform.c
> @@ -248,7 +248,12 @@ static int acp_dma_open(struct snd_soc_component *component, struct snd_pcm_subs
>  	list_add_tail(&stream->list, &chip->stream_list);
>  	spin_unlock_irq(&chip->acp_lock);
>  
> -	return ret;
> +	/*
> +	 * ASoC only marks the component as opened when .open() returns 0.
> +	 * Since snd_pcm_hw_constraint_integer() may return 1, explicitly
> +	 * return 0 to ensure .close() is not skipped on rollback.
> +	 */
> +	return 0;
>  }

[Severity: High]
Is there a memory leak in acp3x_dma_close() related to this subsystem?

Looking at sound/soc/amd/raven/acp3x-pcm-dma.c, the stream instance
structure is allocated on every stream open:

sound/soc/amd/raven/acp3x-pcm-dma.c:acp3x_dma_open() {
    ...
	i2s_data = kzalloc_obj(*i2s_data);
	if (!i2s_data)
		return -EINVAL;
    ...
}

However, when the stream is closed, acp3x_dma_close() returns without calling
kfree() to free the allocated stream instance structure:

sound/soc/amd/raven/acp3x-pcm-dma.c:acp3x_dma_close() {
    ...
	return 0;
}

Could this lead to a memory leak of the i2s_data structure on every stream
closure, allowing a user to drain system memory by repeatedly opening and
closing the device?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261015014324.5569-1-phucduc.bui@gmail.com?part=1