From: sashiko-bot@kernel.org
To: "Chaz Bailey" <charles.s.bailey@gmail.com>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: typec: nb7vpq904m: Set client data in probe to avoid crash on remove
Date: Fri, 16 Oct 2026 08:13:43 +0000 [thread overview]
Message-ID: <sashiko-outbox-174003@kernel.org> (raw)
In-Reply-To: <20261016080517.156248-1-charles.s.bailey@gmail.com>
> nb7vpq904m_probe() allocates struct nb7vpq904m but neglects to call
> i2c_set_clientdata(client, nb7).
>
> In nb7vpq904m_remove(), i2c_get_clientdata(client) returns NULL, leading
> to a NULL pointer dereference when accessing nb7->retimer or nb7->sw.
>
> Set client data upon successful allocation in probe.
>
> Fixes: 88d8f3ac9c67 ("usb: typec: add support for the nb7vpq904m Type-C Linear Redriver")
> Cc: stable@vger.kernel.org
> Signed-off-by: Chaz Bailey <charles.s.bailey@gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261016080517.156248-1-charles.s.bailey@gmail.com?part=1
next prev parent reply other threads:[~2026-10-16 8:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-16 8:05 [PATCH] usb: typec: nb7vpq904m: Set client data in probe to avoid crash on remove Chaz Bailey
2026-10-16 8:13 ` sashiko-bot [this message]
2026-10-16 8:36 ` Krishna Kurapati
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-174003@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=charles.s.bailey@gmail.com \
--cc=linux-usb@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.