From: Chaz Bailey <charles.s.bailey@gmail.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
linux-usb@vger.kernel.org, stable@vger.kernel.org,
Chaz Bailey <charles.s.bailey@gmail.com>
Subject: [PATCH] usb: typec: nb7vpq904m: Set client data in probe to avoid crash on remove
Date: Fri, 16 Oct 2026 09:05:17 +0100 [thread overview]
Message-ID: <20261016080517.156248-1-charles.s.bailey@gmail.com> (raw)
nb7vpq904m_probe() allocates struct nb7vpq904m but neglects to call
i2c_set_clientdata(client, nb7).
In nb7vpq904m_remove(), i2c_get_clientdata(client) returns NULL, leading
to a NULL pointer dereference when accessing nb7->retimer or nb7->sw.
Set client data upon successful allocation in probe.
Fixes: 88d8f3ac9c67 ("usb: typec: add support for the nb7vpq904m Type-C Linear Redriver")
Cc: stable@vger.kernel.org
Signed-off-by: Chaz Bailey <charles.s.bailey@gmail.com>
---
drivers/usb/typec/mux/nb7vpq904m.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/typec/mux/nb7vpq904m.c b/drivers/usb/typec/mux/nb7vpq904m.c
index d1fa26ff44..52e3c9db35 100644
--- a/drivers/usb/typec/mux/nb7vpq904m.c
+++ b/drivers/usb/typec/mux/nb7vpq904m.c
@@ -396,6 +396,7 @@ static int nb7vpq904m_probe(struct i2c_client *client)
return -ENOMEM;
nb7->client = client;
+ i2c_set_clientdata(client, nb7);
nb7->regmap = devm_regmap_init_i2c(client, &nb7_regmap);
if (IS_ERR(nb7->regmap)) {
--
2.55.0
next reply other threads:[~2026-10-16 8:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-16 8:05 Chaz Bailey [this message]
2026-10-16 8:13 ` [PATCH] usb: typec: nb7vpq904m: Set client data in probe to avoid crash on remove sashiko-bot
2026-10-16 8:36 ` Krishna Kurapati
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261016080517.156248-1-charles.s.bailey@gmail.com \
--to=charles.s.bailey@gmail.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.