Re: [PATCH 1/2] dt-bindings: arm-smmu: Document SM7250 SMMU

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: iommu/arm,smmu: missing clock constraints for SM7250 Adreno SMMU
--

commit 858a7b55acf188b45bbadcffa3b76541e3ae0d31
Author: Ishu Brar <patches@brar.si>

dt-bindings: arm-smmu: Document SM7250 SMMU

This commit documents the apps SMMU and GPU SMMU implementations found on
the Qualcomm SM7250 SoC. The GPU SMMU variant additionally carries the
qcom,adreno-smmu compatible string.

> diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
> index 6748351c78122..86844cefa76a3 100644
> --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
> +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml

[ ... ]

> @@ -116,6 +117,7 @@ properties:
>                - qcom,shikra-smmu-500
>                - qcom,sm6115-smmu-500
>                - qcom,sm6125-smmu-500
> +              - qcom,sm7250-smmu-500
>                - qcom,sm8150-smmu-500
>                - qcom,sm8250-smmu-500
>                - qcom,sm8350-smmu-500

[Severity: Medium]
By adding the SM7250 compatible string to the Adreno GPU SMMU definition
here, should it also be added to the subsequent allOf conditional blocks
that enforce clock-names constraints?

Currently, the SM7250 Adreno GPU SMMU appears to be omitted from the
allOf block that requires specific clocks (such as ahb, bus, and iface).
This causes the device to fall through to the unconstrained base schema
for clocks, which could silently permit device trees with invalid, missing,
or wrongly ordered clocks to pass schema validation during a
dt_binding_check run.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261016-smmu-sm7250-v1-0-e11fc0384cfa@brar.si?part=1