Re: [PATCH v5 1/2] dt-bindings: input: add OnePlus pogo-pin keyboard

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] MAINTAINERS: alphabetical sorting error for ONEPLUS entry
--

commit d93ea6ab73044ac76b5e3e2c76b82b975bf6fd6f
Author: Yibo Wang <wyibo6109@gmail.com>

dt-bindings: input: add OnePlus pogo-pin keyboard

This patch adds the device tree binding for the OnePlus Pad 3 Pro / Pad 4
and OPPO Pad 5 Pro pogo-pin smart keyboards. It defines the compatible
strings, required GPIO properties, and adds a MAINTAINERS entry.

> diff --git a/MAINTAINERS b/MAINTAINERS
> index b8c4e1080af94..d81e400059ced 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
[ ... ]
> @@ -20154,6 +20154,12 @@ S:	Maintained
>  F:	Documentation/ABI/testing/sysfs-bus-platform-onboard-usb-dev
>  F:	drivers/usb/misc/onboard_usb_dev.c
>  
> +ONEPLUS POGO-PIN KEYBOARD DRIVER
> +M:	Yibo Wang <wyibo6109@gmail.com>
> +L:	linux-input@vger.kernel.org
> +S:	Maintained
> +F:	Documentation/devicetree/bindings/input/oneplus,pogo-keyboard.yaml
> +
>  ONENAND FLASH DRIVER

[Severity: Low]
This isn't a bug, but should the ONEPLUS entry be placed after the ONENAND
entry? The MAINTAINERS file is expected to be kept in strict alphabetical
order, and ONEP... follows ONEN... alphabetically.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261016123334.1019257-1-wyibo6109@gmail.com?part=1