* [PATCH v2 0/4] Add DP AltMode VDO definitions for DT usage
@ 2026-10-17 19:59 ` Sebastian Reichel
0 siblings, 0 replies; 14+ messages in thread
From: Sebastian Reichel @ 2026-10-17 19:59 UTC (permalink / raw)
To: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Heiko Stuebner, Matthias Brugger,
AngeloGioacchino Del Regno, Bjorn Andersson, Konrad Dybcio
Cc: linux-usb, devicetree, linux-kernel, linux-arm-kernel,
linux-rockchip, linux-mediatek, linux-arm-msm, kernel,
Sebastian Reichel, Dmitry Baryshkov, Konrad Dybcio
Make DP AltMode devicetree entries more readable by adding a few
defines. This hopefully helps to correctly describe the supported
DP AltMode when boards are being upstreamed. Apparently right now
all upstream boards with DP AltMode *should* have set their VDO to
0x00001c46, which means that they can output DP1.4 with C, D or E
pin mapping on a receptacle that also has functional USB 2.
The patch series is based on current master.
Changes in v2:
- Link to v1: https://patch.msgid.link/20261014-dp-altmode-dt-defines-v1-0-b657c9b6e4c3@collabora.com
- s/USB_DISPLAYPORT_SVID/USB_SVID_DP_ALTMODE/ ; I initially
used the former and somehow missed updating the Mediatek DTS
before sending out the patches
- Collect Reviewed-by from Dmitry Baryshkov and Konrad Dybcio
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
---
Sebastian Reichel (4):
dt-bindings: connector: Add DP AltMode VDO definitions
arm64: dts: rockchip: Use DP AltMode defines
arm64: dts: mediatek: Use DP AltMode defines
arm64: dts: qcom: Use DP AltMode defines
.../boot/dts/mediatek/mt8390-genio-common.dtsi | 8 ++-
.../boot/dts/mediatek/mt8395-genio-common.dtsi | 10 +++-
arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 8 ++-
arch/arm64/boot/dts/qcom/sm8150-hdk.dts | 9 +++-
.../dts/rockchip/rk3576-anbernic-rg-vita-pro.dts | 8 ++-
.../boot/dts/rockchip/rk3576-armsom-cm5-io.dts | 8 ++-
.../boot/dts/rockchip/rk3576-armsom-sige5.dts | 8 ++-
.../boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi | 8 ++-
.../boot/dts/rockchip/rk3588s-indiedroid-nova.dts | 8 ++-
include/dt-bindings/usb/pd.h | 58 ++++++++++++++++++++++
10 files changed, 115 insertions(+), 18 deletions(-)
---
base-commit: 58161ead29e50d70a317ea26b472e0c7508e69da
change-id: 20261010-dp-altmode-dt-defines-2aa5a94b76f5
Best regards,
--
Sebastian Reichel <sebastian.reichel@collabora.com>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 14+ messages in thread* [PATCH v2 1/4] dt-bindings: connector: Add DP AltMode VDO definitions
2026-10-17 19:59 ` Sebastian Reichel
@ 2026-10-17 19:59 ` Sebastian Reichel
-1 siblings, 0 replies; 14+ messages in thread
From: Sebastian Reichel @ 2026-10-17 19:59 UTC (permalink / raw)
To: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Heiko Stuebner, Matthias Brugger,
AngeloGioacchino Del Regno, Bjorn Andersson, Konrad Dybcio
Cc: linux-usb, devicetree, linux-kernel, linux-arm-kernel,
linux-rockchip, linux-mediatek, linux-arm-msm, kernel,
Sebastian Reichel, Dmitry Baryshkov
From: Sebastian Reichel <sebastian.reichel@collabora.com>
The typical USB-C DisplayPort AltMode capabilities for a down facing
port (i.e. sending out video data) looks like this:
altmodes {
displayport {
svid = /bits/ 16 <0xff01>;
vdo = <0x00001c46>;
};
};
Improve the readability by adding defines for the numbers, so that
the above instead looks like this:
altmodes {
displayport {
svid = /bits/ 16 <USB_SVID_DP_ALTMODE>;
vdo = <VDO_DP(DP_CAP_DPAM_V2_0, DP_CAP_CABLE_TYPE_PASSIVE,
DP_CAP_UHBR_13_5_UNSUPPORTED,
DP_PIN_UFP_NONE, DP_PIN_DFP_C_D_E,
DP_CAP_USB2_USED, DP_CAP_RECEPTACLE,
DP_CAP_SIGNALLING_HBR3, DP_CAP_DFP_D)>;
};
};
The generated DT binary will stay unchanged.
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
---
include/dt-bindings/usb/pd.h | 58 ++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 58 insertions(+)
diff --git a/include/dt-bindings/usb/pd.h b/include/dt-bindings/usb/pd.h
index 1e64a1f563f9..6cea6165fc0f 100644
--- a/include/dt-bindings/usb/pd.h
+++ b/include/dt-bindings/usb/pd.h
@@ -483,6 +483,64 @@
| ((vbm) & 0x3) << 15 | (curr) << 14 | ((vbi) & 0x3f) << 7 \
| ((gi) & 0x3f) << 1 | (ct))
+/*
+ * Displayport AltMode VDO
+ * -----------------------
+ * <30> :: DPAM version
+ * <29:28> :: Cable type
+ * <26> :: UHBR 13.5 support
+ * <23:16> :: UFP Pin assignment
+ * <15:8> :: DFP Pin assignment
+ * <7> :: USB
+ * <6> :: Receptacle
+ * <5:2> :: Signalling
+ * <1:0> :: Capabilities
+ */
+#define DP_CAP_UFP_D 1
+#define DP_CAP_DFP_D 2
+#define DP_CAP_DFP_D_AND_UFP_D 3
+
+#define DP_CAP_SIGNALLING_HBR3 1
+#define DP_CAP_SIGNALLING_UHBR10 2
+#define DP_CAP_SIGNALLING_UHBR20 3
+
+#define DP_CAP_PLUG 0
+#define DP_CAP_RECEPTACLE 1
+
+#define DP_CAP_USB2_USED 0
+#define DP_CAP_USB2_UNUSED 1
+
+#define DP_PIN_ASSIGN_A 0x01 /* Not supported after v1.0b */
+#define DP_PIN_ASSIGN_B 0x02 /* Not supported after v1.0b */
+#define DP_PIN_ASSIGN_C 0x04
+#define DP_PIN_ASSIGN_D 0x08
+#define DP_PIN_ASSIGN_E 0x10
+#define DP_PIN_ASSIGN_F 0x20 /* Not supported after v1.0b */
+
+#define DP_PIN_UFP_NONE 0x00
+#define DP_PIN_DFP_C_D_E (DP_PIN_ASSIGN_C | \
+ DP_PIN_ASSIGN_D | \
+ DP_PIN_ASSIGN_E)
+
+#define DP_CAP_UHBR_13_5_UNSUPPORTED 0
+#define DP_CAP_UHBR_13_5_SUPPORTED 1
+
+#define DP_CAP_CABLE_TYPE_PASSIVE 0
+#define DP_CAP_CABLE_TYPE_RE_TIMER 1
+#define DP_CAP_CABLE_TYPE_RE_DRIVER 2
+#define DP_CAP_CABLE_TYPE_OPTICAL 3
+
+#define DP_CAP_DPAM_V2_0 0
+#define DP_CAP_DPAM_V2_1 1
+
+#define VDO_DP(dpam, cable, uhbr, ufp_pins, dfp_pins, usb, rcpt, sig, caps) \
+ (((dpam) & 1) << 30 | ((cable) & 3) << 28 | ((uhbr) & 1) << 26 \
+ | ((ufp_pins) & 0xff) << 16 | ((dfp_pins) & 0xff) << 8 \
+ | ((usb) & 1) << 7 | ((rcpt) & 1) << 6 | ((sig) & 0xf) << 2 \
+ | ((caps) & 3))
+
+#define USB_SVID_DP_ALTMODE 0xff01
+
/*
* Sink Load Characteristics
* -------------------------
--
2.53.0
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH v2 1/4] dt-bindings: connector: Add DP AltMode VDO definitions
@ 2026-10-17 19:59 ` Sebastian Reichel
0 siblings, 0 replies; 14+ messages in thread
From: Sebastian Reichel @ 2026-10-17 19:59 UTC (permalink / raw)
To: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Heiko Stuebner, Matthias Brugger,
AngeloGioacchino Del Regno, Bjorn Andersson, Konrad Dybcio
Cc: linux-usb, devicetree, linux-kernel, linux-arm-kernel,
linux-rockchip, linux-mediatek, linux-arm-msm, kernel,
Sebastian Reichel, Dmitry Baryshkov
From: Sebastian Reichel <sebastian.reichel@collabora.com>
The typical USB-C DisplayPort AltMode capabilities for a down facing
port (i.e. sending out video data) looks like this:
altmodes {
displayport {
svid = /bits/ 16 <0xff01>;
vdo = <0x00001c46>;
};
};
Improve the readability by adding defines for the numbers, so that
the above instead looks like this:
altmodes {
displayport {
svid = /bits/ 16 <USB_SVID_DP_ALTMODE>;
vdo = <VDO_DP(DP_CAP_DPAM_V2_0, DP_CAP_CABLE_TYPE_PASSIVE,
DP_CAP_UHBR_13_5_UNSUPPORTED,
DP_PIN_UFP_NONE, DP_PIN_DFP_C_D_E,
DP_CAP_USB2_USED, DP_CAP_RECEPTACLE,
DP_CAP_SIGNALLING_HBR3, DP_CAP_DFP_D)>;
};
};
The generated DT binary will stay unchanged.
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
---
include/dt-bindings/usb/pd.h | 58 ++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 58 insertions(+)
diff --git a/include/dt-bindings/usb/pd.h b/include/dt-bindings/usb/pd.h
index 1e64a1f563f9..6cea6165fc0f 100644
--- a/include/dt-bindings/usb/pd.h
+++ b/include/dt-bindings/usb/pd.h
@@ -483,6 +483,64 @@
| ((vbm) & 0x3) << 15 | (curr) << 14 | ((vbi) & 0x3f) << 7 \
| ((gi) & 0x3f) << 1 | (ct))
+/*
+ * Displayport AltMode VDO
+ * -----------------------
+ * <30> :: DPAM version
+ * <29:28> :: Cable type
+ * <26> :: UHBR 13.5 support
+ * <23:16> :: UFP Pin assignment
+ * <15:8> :: DFP Pin assignment
+ * <7> :: USB
+ * <6> :: Receptacle
+ * <5:2> :: Signalling
+ * <1:0> :: Capabilities
+ */
+#define DP_CAP_UFP_D 1
+#define DP_CAP_DFP_D 2
+#define DP_CAP_DFP_D_AND_UFP_D 3
+
+#define DP_CAP_SIGNALLING_HBR3 1
+#define DP_CAP_SIGNALLING_UHBR10 2
+#define DP_CAP_SIGNALLING_UHBR20 3
+
+#define DP_CAP_PLUG 0
+#define DP_CAP_RECEPTACLE 1
+
+#define DP_CAP_USB2_USED 0
+#define DP_CAP_USB2_UNUSED 1
+
+#define DP_PIN_ASSIGN_A 0x01 /* Not supported after v1.0b */
+#define DP_PIN_ASSIGN_B 0x02 /* Not supported after v1.0b */
+#define DP_PIN_ASSIGN_C 0x04
+#define DP_PIN_ASSIGN_D 0x08
+#define DP_PIN_ASSIGN_E 0x10
+#define DP_PIN_ASSIGN_F 0x20 /* Not supported after v1.0b */
+
+#define DP_PIN_UFP_NONE 0x00
+#define DP_PIN_DFP_C_D_E (DP_PIN_ASSIGN_C | \
+ DP_PIN_ASSIGN_D | \
+ DP_PIN_ASSIGN_E)
+
+#define DP_CAP_UHBR_13_5_UNSUPPORTED 0
+#define DP_CAP_UHBR_13_5_SUPPORTED 1
+
+#define DP_CAP_CABLE_TYPE_PASSIVE 0
+#define DP_CAP_CABLE_TYPE_RE_TIMER 1
+#define DP_CAP_CABLE_TYPE_RE_DRIVER 2
+#define DP_CAP_CABLE_TYPE_OPTICAL 3
+
+#define DP_CAP_DPAM_V2_0 0
+#define DP_CAP_DPAM_V2_1 1
+
+#define VDO_DP(dpam, cable, uhbr, ufp_pins, dfp_pins, usb, rcpt, sig, caps) \
+ (((dpam) & 1) << 30 | ((cable) & 3) << 28 | ((uhbr) & 1) << 26 \
+ | ((ufp_pins) & 0xff) << 16 | ((dfp_pins) & 0xff) << 8 \
+ | ((usb) & 1) << 7 | ((rcpt) & 1) << 6 | ((sig) & 0xf) << 2 \
+ | ((caps) & 3))
+
+#define USB_SVID_DP_ALTMODE 0xff01
+
/*
* Sink Load Characteristics
* -------------------------
--
2.53.0
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH v2 1/4] dt-bindings: connector: Add DP AltMode VDO definitions
2026-10-17 19:59 ` Sebastian Reichel
(?)
@ 2026-10-17 20:01 ` sashiko-bot
-1 siblings, 0 replies; 14+ messages in thread
From: sashiko-bot @ 2026-10-17 20:01 UTC (permalink / raw)
To: Sebastian Reichel; +Cc: linux-usb
> From: Sebastian Reichel <sebastian.reichel@collabora.com>
>
> The typical USB-C DisplayPort AltMode capabilities for a down facing
> port (i.e. sending out video data) looks like this:
>
> altmodes {
> displayport {
> svid = /bits/ 16 <0xff01>;
> vdo = <0x00001c46>;
> };
> };
>
> Improve the readability by adding defines for the numbers, so that
> the above instead looks like this:
>
> altmodes {
> displayport {
> svid = /bits/ 16 <USB_SVID_DP_ALTMODE>;
> vdo = <VDO_DP(DP_CAP_DPAM_V2_0, DP_CAP_CABLE_TYPE_PASSIVE,
> DP_CAP_UHBR_13_5_UNSUPPORTED,
> DP_PIN_UFP_NONE, DP_PIN_DFP_C_D_E,
> DP_CAP_USB2_USED, DP_CAP_RECEPTACLE,
> DP_CAP_SIGNALLING_HBR3, DP_CAP_DFP_D)>;
> };
> };
>
> The generated DT binary will stay unchanged.
>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261017-dp-altmode-dt-defines-v2-0-7ab3d93553dd@collabora.com?part=1
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2 2/4] arm64: dts: rockchip: Use DP AltMode defines
2026-10-17 19:59 ` Sebastian Reichel
@ 2026-10-17 19:59 ` Sebastian Reichel
-1 siblings, 0 replies; 14+ messages in thread
From: Sebastian Reichel @ 2026-10-17 19:59 UTC (permalink / raw)
To: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Heiko Stuebner, Matthias Brugger,
AngeloGioacchino Del Regno, Bjorn Andersson, Konrad Dybcio
Cc: linux-usb, devicetree, linux-kernel, linux-arm-kernel,
linux-rockchip, linux-mediatek, linux-arm-msm, kernel,
Sebastian Reichel, Dmitry Baryshkov
From: Sebastian Reichel <sebastian.reichel@collabora.com>
Use the new USB-C DP AltMode defines for the SVID and the capabilities
VDO to make the DTs more readable. This also fixes up announcing
0xffffffff, which is simply wrong as that allows using the port in
upfacing mode (i.e. the board receiving DisplayPort data, bandwidth
above HBR3 or pin configurations not handled by USBDP.
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
---
arch/arm64/boot/dts/rockchip/rk3576-anbernic-rg-vita-pro.dts | 8 ++++++--
arch/arm64/boot/dts/rockchip/rk3576-armsom-cm5-io.dts | 8 ++++++--
arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts | 8 ++++++--
arch/arm64/boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi | 8 ++++++--
arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts | 8 ++++++--
5 files changed, 30 insertions(+), 10 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3576-anbernic-rg-vita-pro.dts b/arch/arm64/boot/dts/rockchip/rk3576-anbernic-rg-vita-pro.dts
index 358dea43f9b6..621f786147d5 100644
--- a/arch/arm64/boot/dts/rockchip/rk3576-anbernic-rg-vita-pro.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3576-anbernic-rg-vita-pro.dts
@@ -911,8 +911,12 @@ connector {
altmodes {
displayport {
- svid = /bits/ 16 <0xff01>;
- vdo = <0xffffffff>;
+ svid = /bits/ 16 <USB_SVID_DP_ALTMODE>;
+ vdo = <VDO_DP(DP_CAP_DPAM_V2_0, DP_CAP_CABLE_TYPE_PASSIVE,
+ DP_CAP_UHBR_13_5_UNSUPPORTED,
+ DP_PIN_UFP_NONE, DP_PIN_DFP_C_D_E,
+ DP_CAP_USB2_USED, DP_CAP_RECEPTACLE,
+ DP_CAP_SIGNALLING_HBR3, DP_CAP_DFP_D)>;
};
};
diff --git a/arch/arm64/boot/dts/rockchip/rk3576-armsom-cm5-io.dts b/arch/arm64/boot/dts/rockchip/rk3576-armsom-cm5-io.dts
index ebb231271e45..d154e9037ed0 100644
--- a/arch/arm64/boot/dts/rockchip/rk3576-armsom-cm5-io.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3576-armsom-cm5-io.dts
@@ -204,8 +204,12 @@ PDO_FIXED(9000, 3000, PDO_FIXED_USB_COMM)
altmodes {
displayport {
- svid = /bits/ 16 <0xff01>;
- vdo = <0xffffffff>;
+ svid = /bits/ 16 <USB_SVID_DP_ALTMODE>;
+ vdo = <VDO_DP(DP_CAP_DPAM_V2_0, DP_CAP_CABLE_TYPE_PASSIVE,
+ DP_CAP_UHBR_13_5_UNSUPPORTED,
+ DP_PIN_UFP_NONE, DP_PIN_DFP_C_D_E,
+ DP_CAP_USB2_USED, DP_CAP_RECEPTACLE,
+ DP_CAP_SIGNALLING_HBR3, DP_CAP_DFP_D)>;
};
};
diff --git a/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts b/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts
index 4ac4465e39a5..e457fb37f3b3 100644
--- a/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts
@@ -711,8 +711,12 @@ connector {
altmodes {
displayport {
- svid = /bits/ 16 <0xff01>;
- vdo = <0xffffffff>;
+ svid = /bits/ 16 <USB_SVID_DP_ALTMODE>;
+ vdo = <VDO_DP(DP_CAP_DPAM_V2_0, DP_CAP_CABLE_TYPE_PASSIVE,
+ DP_CAP_UHBR_13_5_UNSUPPORTED,
+ DP_PIN_UFP_NONE, DP_PIN_DFP_C_D_E,
+ DP_CAP_USB2_USED, DP_CAP_RECEPTACLE,
+ DP_CAP_SIGNALLING_HBR3, DP_CAP_DFP_D)>;
};
};
diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi
index 13aaf63ad093..163ad7eef4fd 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi
@@ -346,8 +346,12 @@ usb_con: connector {
altmodes {
displayport {
- svid = /bits/ 16 <0xff01>;
- vdo = <0xffffffff>;
+ svid = /bits/ 16 <USB_SVID_DP_ALTMODE>;
+ vdo = <VDO_DP(DP_CAP_DPAM_V2_0, DP_CAP_CABLE_TYPE_PASSIVE,
+ DP_CAP_UHBR_13_5_UNSUPPORTED,
+ DP_PIN_UFP_NONE, DP_PIN_DFP_C_D_E,
+ DP_CAP_USB2_USED, DP_CAP_RECEPTACLE,
+ DP_CAP_SIGNALLING_HBR3, DP_CAP_DFP_D)>;
};
};
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts b/arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts
index ed36c27c2320..8f6f32ee2074 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts
@@ -392,8 +392,12 @@ usb_con: connector {
altmodes {
displayport {
- svid = /bits/ 16 <0xff01>;
- vdo = <0xffffffff>;
+ svid = /bits/ 16 <USB_SVID_DP_ALTMODE>;
+ vdo = <VDO_DP(DP_CAP_DPAM_V2_0, DP_CAP_CABLE_TYPE_PASSIVE,
+ DP_CAP_UHBR_13_5_UNSUPPORTED,
+ DP_PIN_UFP_NONE, DP_PIN_DFP_C_D_E,
+ DP_CAP_USB2_USED, DP_CAP_RECEPTACLE,
+ DP_CAP_SIGNALLING_HBR3, DP_CAP_DFP_D)>;
};
};
--
2.53.0
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH v2 2/4] arm64: dts: rockchip: Use DP AltMode defines
@ 2026-10-17 19:59 ` Sebastian Reichel
0 siblings, 0 replies; 14+ messages in thread
From: Sebastian Reichel @ 2026-10-17 19:59 UTC (permalink / raw)
To: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Heiko Stuebner, Matthias Brugger,
AngeloGioacchino Del Regno, Bjorn Andersson, Konrad Dybcio
Cc: linux-usb, devicetree, linux-kernel, linux-arm-kernel,
linux-rockchip, linux-mediatek, linux-arm-msm, kernel,
Sebastian Reichel, Dmitry Baryshkov
From: Sebastian Reichel <sebastian.reichel@collabora.com>
Use the new USB-C DP AltMode defines for the SVID and the capabilities
VDO to make the DTs more readable. This also fixes up announcing
0xffffffff, which is simply wrong as that allows using the port in
upfacing mode (i.e. the board receiving DisplayPort data, bandwidth
above HBR3 or pin configurations not handled by USBDP.
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
---
arch/arm64/boot/dts/rockchip/rk3576-anbernic-rg-vita-pro.dts | 8 ++++++--
arch/arm64/boot/dts/rockchip/rk3576-armsom-cm5-io.dts | 8 ++++++--
arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts | 8 ++++++--
arch/arm64/boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi | 8 ++++++--
arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts | 8 ++++++--
5 files changed, 30 insertions(+), 10 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3576-anbernic-rg-vita-pro.dts b/arch/arm64/boot/dts/rockchip/rk3576-anbernic-rg-vita-pro.dts
index 358dea43f9b6..621f786147d5 100644
--- a/arch/arm64/boot/dts/rockchip/rk3576-anbernic-rg-vita-pro.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3576-anbernic-rg-vita-pro.dts
@@ -911,8 +911,12 @@ connector {
altmodes {
displayport {
- svid = /bits/ 16 <0xff01>;
- vdo = <0xffffffff>;
+ svid = /bits/ 16 <USB_SVID_DP_ALTMODE>;
+ vdo = <VDO_DP(DP_CAP_DPAM_V2_0, DP_CAP_CABLE_TYPE_PASSIVE,
+ DP_CAP_UHBR_13_5_UNSUPPORTED,
+ DP_PIN_UFP_NONE, DP_PIN_DFP_C_D_E,
+ DP_CAP_USB2_USED, DP_CAP_RECEPTACLE,
+ DP_CAP_SIGNALLING_HBR3, DP_CAP_DFP_D)>;
};
};
diff --git a/arch/arm64/boot/dts/rockchip/rk3576-armsom-cm5-io.dts b/arch/arm64/boot/dts/rockchip/rk3576-armsom-cm5-io.dts
index ebb231271e45..d154e9037ed0 100644
--- a/arch/arm64/boot/dts/rockchip/rk3576-armsom-cm5-io.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3576-armsom-cm5-io.dts
@@ -204,8 +204,12 @@ PDO_FIXED(9000, 3000, PDO_FIXED_USB_COMM)
altmodes {
displayport {
- svid = /bits/ 16 <0xff01>;
- vdo = <0xffffffff>;
+ svid = /bits/ 16 <USB_SVID_DP_ALTMODE>;
+ vdo = <VDO_DP(DP_CAP_DPAM_V2_0, DP_CAP_CABLE_TYPE_PASSIVE,
+ DP_CAP_UHBR_13_5_UNSUPPORTED,
+ DP_PIN_UFP_NONE, DP_PIN_DFP_C_D_E,
+ DP_CAP_USB2_USED, DP_CAP_RECEPTACLE,
+ DP_CAP_SIGNALLING_HBR3, DP_CAP_DFP_D)>;
};
};
diff --git a/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts b/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts
index 4ac4465e39a5..e457fb37f3b3 100644
--- a/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts
@@ -711,8 +711,12 @@ connector {
altmodes {
displayport {
- svid = /bits/ 16 <0xff01>;
- vdo = <0xffffffff>;
+ svid = /bits/ 16 <USB_SVID_DP_ALTMODE>;
+ vdo = <VDO_DP(DP_CAP_DPAM_V2_0, DP_CAP_CABLE_TYPE_PASSIVE,
+ DP_CAP_UHBR_13_5_UNSUPPORTED,
+ DP_PIN_UFP_NONE, DP_PIN_DFP_C_D_E,
+ DP_CAP_USB2_USED, DP_CAP_RECEPTACLE,
+ DP_CAP_SIGNALLING_HBR3, DP_CAP_DFP_D)>;
};
};
diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi
index 13aaf63ad093..163ad7eef4fd 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi
@@ -346,8 +346,12 @@ usb_con: connector {
altmodes {
displayport {
- svid = /bits/ 16 <0xff01>;
- vdo = <0xffffffff>;
+ svid = /bits/ 16 <USB_SVID_DP_ALTMODE>;
+ vdo = <VDO_DP(DP_CAP_DPAM_V2_0, DP_CAP_CABLE_TYPE_PASSIVE,
+ DP_CAP_UHBR_13_5_UNSUPPORTED,
+ DP_PIN_UFP_NONE, DP_PIN_DFP_C_D_E,
+ DP_CAP_USB2_USED, DP_CAP_RECEPTACLE,
+ DP_CAP_SIGNALLING_HBR3, DP_CAP_DFP_D)>;
};
};
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts b/arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts
index ed36c27c2320..8f6f32ee2074 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts
@@ -392,8 +392,12 @@ usb_con: connector {
altmodes {
displayport {
- svid = /bits/ 16 <0xff01>;
- vdo = <0xffffffff>;
+ svid = /bits/ 16 <USB_SVID_DP_ALTMODE>;
+ vdo = <VDO_DP(DP_CAP_DPAM_V2_0, DP_CAP_CABLE_TYPE_PASSIVE,
+ DP_CAP_UHBR_13_5_UNSUPPORTED,
+ DP_PIN_UFP_NONE, DP_PIN_DFP_C_D_E,
+ DP_CAP_USB2_USED, DP_CAP_RECEPTACLE,
+ DP_CAP_SIGNALLING_HBR3, DP_CAP_DFP_D)>;
};
};
--
2.53.0
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH v2 2/4] arm64: dts: rockchip: Use DP AltMode defines
2026-10-17 19:59 ` Sebastian Reichel
(?)
@ 2026-10-17 20:01 ` sashiko-bot
-1 siblings, 0 replies; 14+ messages in thread
From: sashiko-bot @ 2026-10-17 20:01 UTC (permalink / raw)
To: Sebastian Reichel; +Cc: linux-usb
> From: Sebastian Reichel <sebastian.reichel@collabora.com>
>
> Use the new USB-C DP AltMode defines for the SVID and the capabilities
> VDO to make the DTs more readable. This also fixes up announcing
> 0xffffffff, which is simply wrong as that allows using the port in
> upfacing mode (i.e. the board receiving DisplayPort data, bandwidth
> above HBR3 or pin configurations not handled by USBDP.
>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261017-dp-altmode-dt-defines-v2-0-7ab3d93553dd@collabora.com?part=2
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2 3/4] arm64: dts: mediatek: Use DP AltMode defines
2026-10-17 19:59 ` Sebastian Reichel
@ 2026-10-17 19:59 ` Sebastian Reichel
-1 siblings, 0 replies; 14+ messages in thread
From: Sebastian Reichel @ 2026-10-17 19:59 UTC (permalink / raw)
To: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Heiko Stuebner, Matthias Brugger,
AngeloGioacchino Del Regno, Bjorn Andersson, Konrad Dybcio
Cc: linux-usb, devicetree, linux-kernel, linux-arm-kernel,
linux-rockchip, linux-mediatek, linux-arm-msm, kernel,
Sebastian Reichel, Dmitry Baryshkov
From: Sebastian Reichel <sebastian.reichel@collabora.com>
Use the new USB-C DP AltMode defines for the SVID and the capabilities
VDO to make the DTs more readable. This also fixes up mt8390 Genio
platform incorrectly announcing UFP_D (upwards facing) support. This
feature is unfortunately not supported by the SoC.
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
---
arch/arm64/boot/dts/mediatek/mt8390-genio-common.dtsi | 8 ++++++--
arch/arm64/boot/dts/mediatek/mt8395-genio-common.dtsi | 10 ++++++++--
2 files changed, 14 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt8390-genio-common.dtsi b/arch/arm64/boot/dts/mediatek/mt8390-genio-common.dtsi
index 669eaec662f3..9f75ae3c32d2 100644
--- a/arch/arm64/boot/dts/mediatek/mt8390-genio-common.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8390-genio-common.dtsi
@@ -527,8 +527,12 @@ PDO_FIXED_DUAL_ROLE |
altmodes {
displayport {
- svid = /bits/ 16 <0xff01>;
- vdo = <0x001c1c47>;
+ svid = /bits/ 16 <USB_SVID_DP_ALTMODE>;
+ vdo = <VDO_DP(DP_CAP_DPAM_V2_0, DP_CAP_CABLE_TYPE_PASSIVE,
+ DP_CAP_UHBR_13_5_UNSUPPORTED,
+ DP_PIN_UFP_NONE, DP_PIN_DFP_C_D_E,
+ DP_CAP_USB2_USED, DP_CAP_RECEPTACLE,
+ DP_CAP_SIGNALLING_HBR3, DP_CAP_DFP_D)>;
};
};
diff --git a/arch/arm64/boot/dts/mediatek/mt8395-genio-common.dtsi b/arch/arm64/boot/dts/mediatek/mt8395-genio-common.dtsi
index aef908df530e..d41638e74291 100644
--- a/arch/arm64/boot/dts/mediatek/mt8395-genio-common.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8395-genio-common.dtsi
@@ -597,8 +597,14 @@ PDO_FIXED_DUAL_ROLE |
altmodes {
displayport {
- svid = /bits/ 16 <0xff01>;
- vdo = <0x00001c46>;
+ svid = /bits/ 16 <USB_SVID_DP_ALTMODE>;
+ vdo = <VDO_DP(DP_CAP_DPAM_V2_0,
+ DP_CAP_CABLE_TYPE_PASSIVE,
+ DP_CAP_UHBR_13_5_UNSUPPORTED,
+ DP_PIN_UFP_NONE, DP_PIN_DFP_C_D_E,
+ DP_CAP_USB2_USED, DP_CAP_RECEPTACLE,
+ DP_CAP_SIGNALLING_HBR3,
+ DP_CAP_DFP_D)>;
};
};
--
2.53.0
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH v2 3/4] arm64: dts: mediatek: Use DP AltMode defines
@ 2026-10-17 19:59 ` Sebastian Reichel
0 siblings, 0 replies; 14+ messages in thread
From: Sebastian Reichel @ 2026-10-17 19:59 UTC (permalink / raw)
To: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Heiko Stuebner, Matthias Brugger,
AngeloGioacchino Del Regno, Bjorn Andersson, Konrad Dybcio
Cc: linux-usb, devicetree, linux-kernel, linux-arm-kernel,
linux-rockchip, linux-mediatek, linux-arm-msm, kernel,
Sebastian Reichel, Dmitry Baryshkov
From: Sebastian Reichel <sebastian.reichel@collabora.com>
Use the new USB-C DP AltMode defines for the SVID and the capabilities
VDO to make the DTs more readable. This also fixes up mt8390 Genio
platform incorrectly announcing UFP_D (upwards facing) support. This
feature is unfortunately not supported by the SoC.
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
---
arch/arm64/boot/dts/mediatek/mt8390-genio-common.dtsi | 8 ++++++--
arch/arm64/boot/dts/mediatek/mt8395-genio-common.dtsi | 10 ++++++++--
2 files changed, 14 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt8390-genio-common.dtsi b/arch/arm64/boot/dts/mediatek/mt8390-genio-common.dtsi
index 669eaec662f3..9f75ae3c32d2 100644
--- a/arch/arm64/boot/dts/mediatek/mt8390-genio-common.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8390-genio-common.dtsi
@@ -527,8 +527,12 @@ PDO_FIXED_DUAL_ROLE |
altmodes {
displayport {
- svid = /bits/ 16 <0xff01>;
- vdo = <0x001c1c47>;
+ svid = /bits/ 16 <USB_SVID_DP_ALTMODE>;
+ vdo = <VDO_DP(DP_CAP_DPAM_V2_0, DP_CAP_CABLE_TYPE_PASSIVE,
+ DP_CAP_UHBR_13_5_UNSUPPORTED,
+ DP_PIN_UFP_NONE, DP_PIN_DFP_C_D_E,
+ DP_CAP_USB2_USED, DP_CAP_RECEPTACLE,
+ DP_CAP_SIGNALLING_HBR3, DP_CAP_DFP_D)>;
};
};
diff --git a/arch/arm64/boot/dts/mediatek/mt8395-genio-common.dtsi b/arch/arm64/boot/dts/mediatek/mt8395-genio-common.dtsi
index aef908df530e..d41638e74291 100644
--- a/arch/arm64/boot/dts/mediatek/mt8395-genio-common.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8395-genio-common.dtsi
@@ -597,8 +597,14 @@ PDO_FIXED_DUAL_ROLE |
altmodes {
displayport {
- svid = /bits/ 16 <0xff01>;
- vdo = <0x00001c46>;
+ svid = /bits/ 16 <USB_SVID_DP_ALTMODE>;
+ vdo = <VDO_DP(DP_CAP_DPAM_V2_0,
+ DP_CAP_CABLE_TYPE_PASSIVE,
+ DP_CAP_UHBR_13_5_UNSUPPORTED,
+ DP_PIN_UFP_NONE, DP_PIN_DFP_C_D_E,
+ DP_CAP_USB2_USED, DP_CAP_RECEPTACLE,
+ DP_CAP_SIGNALLING_HBR3,
+ DP_CAP_DFP_D)>;
};
};
--
2.53.0
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH v2 3/4] arm64: dts: mediatek: Use DP AltMode defines
2026-10-17 19:59 ` Sebastian Reichel
(?)
@ 2026-10-17 20:01 ` sashiko-bot
-1 siblings, 0 replies; 14+ messages in thread
From: sashiko-bot @ 2026-10-17 20:01 UTC (permalink / raw)
To: Sebastian Reichel; +Cc: linux-usb
> From: Sebastian Reichel <sebastian.reichel@collabora.com>
>
> Use the new USB-C DP AltMode defines for the SVID and the capabilities
> VDO to make the DTs more readable. This also fixes up mt8390 Genio
> platform incorrectly announcing UFP_D (upwards facing) support. This
> feature is unfortunately not supported by the SoC.
>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261017-dp-altmode-dt-defines-v2-0-7ab3d93553dd@collabora.com?part=3
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2 4/4] arm64: dts: qcom: Use DP AltMode defines
2026-10-17 19:59 ` Sebastian Reichel
@ 2026-10-17 19:59 ` Sebastian Reichel
-1 siblings, 0 replies; 14+ messages in thread
From: Sebastian Reichel @ 2026-10-17 19:59 UTC (permalink / raw)
To: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Heiko Stuebner, Matthias Brugger,
AngeloGioacchino Del Regno, Bjorn Andersson, Konrad Dybcio
Cc: linux-usb, devicetree, linux-kernel, linux-arm-kernel,
linux-rockchip, linux-mediatek, linux-arm-msm, kernel,
Sebastian Reichel, Konrad Dybcio
From: Sebastian Reichel <sebastian.reichel@collabora.com>
Use the new USB-C DP AltMode defines for the SVID and the capabilities
VDO to make the DTs more readable.
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
---
arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 8 ++++++--
arch/arm64/boot/dts/qcom/sm8150-hdk.dts | 9 +++++++--
2 files changed, 13 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
index d6af679abe1a..d21b94e872ce 100644
--- a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
+++ b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
@@ -1508,8 +1508,12 @@ PDO_FIXED_USB_COMM |
altmodes {
displayport {
- svid = /bits/ 16 <0xff01>;
- vdo = <0x00001c46>;
+ svid = /bits/ 16 <USB_SVID_DP_ALTMODE>;
+ vdo = <VDO_DP(DP_CAP_DPAM_V2_0, DP_CAP_CABLE_TYPE_PASSIVE,
+ DP_CAP_UHBR_13_5_UNSUPPORTED,
+ DP_PIN_UFP_NONE, DP_PIN_DFP_C_D_E,
+ DP_CAP_USB2_USED, DP_CAP_RECEPTACLE,
+ DP_CAP_SIGNALLING_HBR3, DP_CAP_DFP_D)>;
};
};
diff --git a/arch/arm64/boot/dts/qcom/sm8150-hdk.dts b/arch/arm64/boot/dts/qcom/sm8150-hdk.dts
index cdced5c848d3..3d83dd305954 100644
--- a/arch/arm64/boot/dts/qcom/sm8150-hdk.dts
+++ b/arch/arm64/boot/dts/qcom/sm8150-hdk.dts
@@ -581,8 +581,13 @@ PDO_FIXED_USB_COMM |
altmodes {
displayport {
- svid = /bits/ 16 <0xff01>;
- vdo = <0x00001c46>;
+ svid = /bits/ 16 <USB_SVID_DP_ALTMODE>;
+ vdo = <VDO_DP(DP_CAP_DPAM_V2_0, DP_CAP_CABLE_TYPE_PASSIVE,
+ DP_CAP_UHBR_13_5_UNSUPPORTED,
+ DP_PIN_UFP_NONE, DP_PIN_DFP_C_D_E,
+ DP_CAP_USB2_USED, DP_CAP_RECEPTACLE,
+ DP_CAP_SIGNALLING_HBR3, DP_CAP_DFP_D)>;
+
};
};
--
2.53.0
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH v2 4/4] arm64: dts: qcom: Use DP AltMode defines
@ 2026-10-17 19:59 ` Sebastian Reichel
0 siblings, 0 replies; 14+ messages in thread
From: Sebastian Reichel @ 2026-10-17 19:59 UTC (permalink / raw)
To: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Heiko Stuebner, Matthias Brugger,
AngeloGioacchino Del Regno, Bjorn Andersson, Konrad Dybcio
Cc: linux-usb, devicetree, linux-kernel, linux-arm-kernel,
linux-rockchip, linux-mediatek, linux-arm-msm, kernel,
Sebastian Reichel, Konrad Dybcio
From: Sebastian Reichel <sebastian.reichel@collabora.com>
Use the new USB-C DP AltMode defines for the SVID and the capabilities
VDO to make the DTs more readable.
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
---
arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 8 ++++++--
arch/arm64/boot/dts/qcom/sm8150-hdk.dts | 9 +++++++--
2 files changed, 13 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
index d6af679abe1a..d21b94e872ce 100644
--- a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
+++ b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
@@ -1508,8 +1508,12 @@ PDO_FIXED_USB_COMM |
altmodes {
displayport {
- svid = /bits/ 16 <0xff01>;
- vdo = <0x00001c46>;
+ svid = /bits/ 16 <USB_SVID_DP_ALTMODE>;
+ vdo = <VDO_DP(DP_CAP_DPAM_V2_0, DP_CAP_CABLE_TYPE_PASSIVE,
+ DP_CAP_UHBR_13_5_UNSUPPORTED,
+ DP_PIN_UFP_NONE, DP_PIN_DFP_C_D_E,
+ DP_CAP_USB2_USED, DP_CAP_RECEPTACLE,
+ DP_CAP_SIGNALLING_HBR3, DP_CAP_DFP_D)>;
};
};
diff --git a/arch/arm64/boot/dts/qcom/sm8150-hdk.dts b/arch/arm64/boot/dts/qcom/sm8150-hdk.dts
index cdced5c848d3..3d83dd305954 100644
--- a/arch/arm64/boot/dts/qcom/sm8150-hdk.dts
+++ b/arch/arm64/boot/dts/qcom/sm8150-hdk.dts
@@ -581,8 +581,13 @@ PDO_FIXED_USB_COMM |
altmodes {
displayport {
- svid = /bits/ 16 <0xff01>;
- vdo = <0x00001c46>;
+ svid = /bits/ 16 <USB_SVID_DP_ALTMODE>;
+ vdo = <VDO_DP(DP_CAP_DPAM_V2_0, DP_CAP_CABLE_TYPE_PASSIVE,
+ DP_CAP_UHBR_13_5_UNSUPPORTED,
+ DP_PIN_UFP_NONE, DP_PIN_DFP_C_D_E,
+ DP_CAP_USB2_USED, DP_CAP_RECEPTACLE,
+ DP_CAP_SIGNALLING_HBR3, DP_CAP_DFP_D)>;
+
};
};
--
2.53.0
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH v2 4/4] arm64: dts: qcom: Use DP AltMode defines
2026-10-17 19:59 ` Sebastian Reichel
(?)
@ 2026-10-17 20:01 ` sashiko-bot
-1 siblings, 0 replies; 14+ messages in thread
From: sashiko-bot @ 2026-10-17 20:01 UTC (permalink / raw)
To: Sebastian Reichel; +Cc: linux-usb
> From: Sebastian Reichel <sebastian.reichel@collabora.com>
>
> Use the new USB-C DP AltMode defines for the SVID and the capabilities
> VDO to make the DTs more readable.
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261017-dp-altmode-dt-defines-v2-0-7ab3d93553dd@collabora.com?part=4
^ permalink raw reply [flat|nested] 14+ messages in thread