* Re: [PATCH] staging: fbtft: fix syntax errors in macros
2026-10-18 8:53 [PATCH] staging: fbtft: fix syntax errors in macros wrmfwv
@ 2026-10-18 8:58 ` sashiko-bot
2026-10-18 9:54 ` Greg KH
2026-10-19 9:20 ` Andy Shevchenko
2 siblings, 0 replies; 4+ messages in thread
From: sashiko-bot @ 2026-10-18 8:58 UTC (permalink / raw)
To: wrmfwv; +Cc: dri-devel
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] staging: fbtft: missing argument in define_fbtft_write_reg() breaks build
--
commit b28f14a98f84b888195dbf0a2f659dbf742f021c
Author: gtl-m <admin@micronull.cn>
staging: fbtft: fix syntax errors in macros
This commit removes trailing commas and spaces before closing parentheses in
two define_fbtft_write_reg() macro invocations to address checkpatch.pl
warnings.
> diff --git a/drivers/staging/fbtft/fbtft-bus.c b/drivers/staging/fbtft/fbtft-bus.c
> index 30e436ff19e4c..409770891c548 100644
> --- a/drivers/staging/fbtft/fbtft-bus.c
> +++ b/drivers/staging/fbtft/fbtft-bus.c
> @@ -62,9 +62,9 @@ out: \
> } \
> EXPORT_SYMBOL(func);
>
> -define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, )
> +define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8)
> define_fbtft_write_reg(fbtft_write_reg16_bus8, __be16, u16, cpu_to_be16)
> -define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16, )
> +define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16)
[Severity: Low]
Does removing the trailing comma break the build when CONFIG_FB_TFT is
enabled?
In drivers/staging/fbtft/fbtft-bus.c, define_fbtft_write_reg() is defined
as a 4-argument macro:
#define define_fbtft_write_reg(func, buffer_type, data_type, modifier) \
void func(struct fbtft_par *par, int len, ...) \
{ \
...
*buf = modifier((data_type)va_arg(args, unsigned int)); \
For fbtft_write_reg8_bus8() and fbtft_write_reg16_bus16(), no byte-order
conversion modifier is needed, so the trailing comma intentionally passes an
empty fourth argument to the macro. Removing the comma passes only 3
arguments to a 4-parameter macro, causing the C preprocessor to fail the
build.
>
> void fbtft_write_reg8_bus9(struct fbtft_par *par, int len, ...)
> {
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261018085345.17619-1-wrmfwv@163.com?part=1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] staging: fbtft: fix syntax errors in macros
2026-10-18 8:53 [PATCH] staging: fbtft: fix syntax errors in macros wrmfwv
2026-10-18 8:58 ` sashiko-bot
@ 2026-10-18 9:54 ` Greg KH
2026-10-19 9:20 ` Andy Shevchenko
2 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2026-10-18 9:54 UTC (permalink / raw)
To: wrmfwv; +Cc: andy, dri-devel, linux-fbdev, linux-staging, linux-kernel, gtl-m
On Sun, Oct 18, 2026 at 04:53:45PM +0800, wrmfwv@163.com wrote:
> From: gtl-m <admin@micronull.cn>
>
> checkpatch.pl reported errors regarding unnecessary commas and spaces
> before closing parentheses in the fbtft_write_reg macro definitions.
> Remove them to strictly comply with the kernel coding style guidelines.
>
> Signed-off-by: gtl-m <admin@micronull.cn>
> ---
> drivers/staging/fbtft/fbtft-bus.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/fbtft/fbtft-bus.c b/drivers/staging/fbtft/fbtft-bus.c
> index 30e436ff19e4..409770891c54 100644
> --- a/drivers/staging/fbtft/fbtft-bus.c
> +++ b/drivers/staging/fbtft/fbtft-bus.c
> @@ -62,9 +62,9 @@ out: \
> } \
> EXPORT_SYMBOL(func);
>
> -define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, )
> +define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8)
> define_fbtft_write_reg(fbtft_write_reg16_bus8, __be16, u16, cpu_to_be16)
> -define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16, )
> +define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16)
>
> void fbtft_write_reg8_bus9(struct fbtft_par *par, int len, ...)
> {
> --
> 2.25.1
>
>
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.
You are receiving this message because of the following common error(s)
as indicated below:
- It looks like you did not use your "real" name for the patch on either
the Signed-off-by: line, or the From: line (both of which have to
match). Please read the kernel file,
Documentation/process/submitting-patches.rst for how to do this
correctly.
If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.
thanks,
greg k-h's patch email bot
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] staging: fbtft: fix syntax errors in macros
2026-10-18 8:53 [PATCH] staging: fbtft: fix syntax errors in macros wrmfwv
2026-10-18 8:58 ` sashiko-bot
2026-10-18 9:54 ` Greg KH
@ 2026-10-19 9:20 ` Andy Shevchenko
2 siblings, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2026-10-19 9:20 UTC (permalink / raw)
To: wrmfwv
Cc: andy, gregkh, dri-devel, linux-fbdev, linux-staging, linux-kernel,
gtl-m
On Sun, Oct 18, 2026 at 04:53:45PM +0800, wrmfwv@163.com wrote:
> checkpatch.pl reported errors regarding unnecessary commas and spaces
> before closing parentheses in the fbtft_write_reg macro definitions.
> Remove them to strictly comply with the kernel coding style guidelines.
NAK.
It's your homework to understand why.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread