From: sashiko-bot@kernel.org
To: "Cole Leavitt" <cole@unwrap.rs>
Cc: linux-pci@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH 2/2] thunderbolt: Don't resume the software CM if the host controller is gone
Date: Sun, 18 Oct 2026 16:45:58 +0000 [thread overview]
Message-ID: <sashiko-outbox-176291@kernel.org> (raw)
In-Reply-To: <20261018163910.132231-2-cole@unwrap.rs>
> nhi_resume_noirq() sets nhi->going_away when the host controller is not
> present anymore on resume (commit bdccf295d7cd ("thunderbolt: Do not
> touch the hardware if the NHI is gone on resume")). With going_away set
> tb_ring_start() refuses to start the control channel rings, but the
> software connection manager's tb_resume_noirq() still goes through the
> whole resume sequence. Every control channel request then fails with
> -ESHUTDOWN from __tb_ring_enqueue(), and tb_cfg_read()/tb_cfg_write()
> WARN for each one:
>
> tb_cfg_write: -108
> WARNING: drivers/thunderbolt/ctl.c:1157 at tb_cfg_write+0x94/0xf0 [thunderbolt]
> Call Trace:
> tb_switch_configure+0x8f/0x1d0 [thunderbolt]
> tb_switch_resume+0xb9/0x3d0 [thunderbolt]
> tb_resume_noirq+0x5d/0x2e0 [thunderbolt]
> [ ... ]
> no events are processed in the meantime.
>
> Fixes: bdccf295d7cd ("thunderbolt: Do not touch the hardware if the NHI is gone on resume")
> Cc: stable@vger.kernel.org
> Signed-off-by: Cole Leavitt <cole@unwrap.rs>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261018163910.132231-1-cole@unwrap.rs?part=2
next prev parent reply other threads:[~2026-10-18 16:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-18 16:37 [PATCH 0/2] PCI: pciehp / thunderbolt: Fix resume with a slow Thunderbolt host link Cole Leavitt
2026-10-18 16:39 ` [PATCH 1/2] PCI: pciehp: Defer device replacement handling until ->resume() Cole Leavitt
2026-10-18 16:39 ` [PATCH 2/2] thunderbolt: Don't resume the software CM if the host controller is gone Cole Leavitt
2026-10-18 16:45 ` sashiko-bot [this message]
2026-10-19 4:29 ` Mika Westerberg
2026-10-18 16:47 ` [PATCH 1/2] PCI: pciehp: Defer device replacement handling until ->resume() sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-176291@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=cole@unwrap.rs \
--cc=linux-pci@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.