All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Cole Leavitt" <cole@unwrap.rs>
Cc: linux-pci@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH 1/2] PCI: pciehp: Defer device replacement handling until ->resume()
Date: Sun, 18 Oct 2026 16:47:14 +0000	[thread overview]
Message-ID: <sashiko-outbox-176295@kernel.org> (raw)
In-Reply-To: <20261018163910.132231-1-cole@unwrap.rs>

> On a Lenovo ThinkPad P16 Gen3 with a discrete Thunderbolt 5 host
> controller (Intel JHL9580 "Barlow Ridge") below Root Port 0000:80:1b.4,
> resume from suspend-to-idle intermittently hangs with a black screen:
> 
>   pcieport 0000:80:1b.4: Data Link Layer Link Active not set in 100 msec
>   pcieport 0000:80:1b.4: pciehp: Slot(25): Card not present
>   thunderbolt 0000:8a:00.0: RX ring 0 already stopped
>   ...
>   Oops: general protection fault, kernel NULL pointer dereference 0x32b
>   Workqueue: async async_run_entry_fn
>   RIP: 0010:tb_resume_noirq+0x3f/0x2e0 [thunderbolt]
>   Call Trace:
>    tb_domain_resume_noirq+0x42/0x60 [thunderbolt]
>    dpm_run_callback+0x4b/0x140
>    device_resume_noirq+0x16d/0x2c0
> [ ... ]
> followed by ->resume(), so resume from hibernation is fixed as well.
> 
> Fixes: 9d573d19547b ("PCI: pciehp: Detect device replacement during system sleep")
> Cc: stable@vger.kernel.org # v6.11+
> Signed-off-by: Cole Leavitt <cole@unwrap.rs>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261018163910.132231-1-cole@unwrap.rs?part=1


      parent reply	other threads:[~2026-10-18 16:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-18 16:37 [PATCH 0/2] PCI: pciehp / thunderbolt: Fix resume with a slow Thunderbolt host link Cole Leavitt
2026-10-18 16:39 ` [PATCH 1/2] PCI: pciehp: Defer device replacement handling until ->resume() Cole Leavitt
2026-10-18 16:39   ` [PATCH 2/2] thunderbolt: Don't resume the software CM if the host controller is gone Cole Leavitt
2026-10-18 16:45     ` sashiko-bot
2026-10-19  4:29     ` Mika Westerberg
2026-10-18 16:47   ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-176295@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=cole@unwrap.rs \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.