All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Vinicius Pedrosa" <vinicius.eduardo.pedrosa@gmail.com>,
	linux-serial@vger.kernel.org
Subject: Re: [PATCH v2 4/4] serial: 8250_dw: Add Allwinner A733 UART
Date: Mon, 19 Oct 2026 20:24:17 +0000	[thread overview]
Message-ID: <sashiko-outbox-178167@kernel.org> (raw)
In-Reply-To: <a3505ad8e74a08faa270881f0efbfe0d0d82d6e0.1792439398.git.vinicius.eduardo.pedrosa@gmail.com>

> On the A733, dw8250_set_termios() stops the UART clock around
> clk_set_rate() on every termios change that reaches the driver. If TX is
> active at that moment, the character being shifted out is corrupted.
> 
> No baud rate change is required to trigger the problem. Toggling only
> CLOCAL or CSTOPB 300 times during continuous console output corrupted
> bytes in every run without the quirk and in none with it.
> 
> Use the existing SKIP_SET_RATE quirk, as the JH7100 and SG2044 UARTs do.
> 
> Signed-off-by: Vinicius Pedrosa <vinicius.eduardo.pedrosa@gmail.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1792439398.git.vinicius.eduardo.pedrosa@gmail.com?part=4


      reply	other threads:[~2026-10-19 20:24 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-19 20:06 [PATCH v2 0/4] serial: 8250_dw: Allwinner A733 UART support Vinicius Pedrosa
2026-10-19 20:06 ` [PATCH v2 1/4] serial: 8250_dw: Keep the BUSY-safe divisor hook when DLF is present Vinicius Pedrosa
2026-10-19 20:26   ` sashiko-bot
2026-10-20  8:30   ` Andy Shevchenko
2026-10-20  8:51   ` Andy Shevchenko
2026-10-19 20:06 ` [PATCH v2 2/4] serial: 8250_dw: Only accept a contiguous DLF readback Vinicius Pedrosa
2026-10-19 20:24   ` sashiko-bot
2026-10-20  6:11   ` Jiri Slaby
2026-10-20  8:31     ` Andy Shevchenko
2026-10-19 20:06 ` [PATCH v2 3/4] dt-bindings: serial: snps-dw-apb-uart: Add Allwinner A733 Vinicius Pedrosa
2026-10-19 20:24   ` sashiko-bot
2026-10-19 20:06 ` [PATCH v2 4/4] serial: 8250_dw: Add Allwinner A733 UART Vinicius Pedrosa
2026-10-19 20:24   ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-178167@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=vinicius.eduardo.pedrosa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.