[PATCH] USB: serial: sierra: fix runtime pm leak on resume failure

[PATCH] USB: serial: sierra: fix runtime pm leak on resume failure

[Johan Hovold]

Make sure to balance the runtime PM usage count also if delayed URB
submission fails during resume (e.g. to allow runtime PM to be used
after the driver has been rebound).

Fixes: e6929a9020ac ("USB: support for autosuspend in sierra while online")
Cc: Oliver Neukum <oliver@neukum.org>
Cc: stable@vger.kernel.org	# 2.6.32
Signed-off-by: Johan Hovold <johan@kernel.org>
---
 drivers/usb/serial/sierra.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/usb/serial/sierra.c b/drivers/usb/serial/sierra.c
index f2cc7f364d20..d2d84542d86c 100644
--- a/drivers/usb/serial/sierra.c
+++ b/drivers/usb/serial/sierra.c
@@ -973,6 +973,8 @@ static int sierra_submit_delayed_urbs(struct usb_serial_port *port)
 			usb_unanchor_urb(urb);
 			kfree(urb->transfer_buffer);
 
+			usb_autopm_put_interface_async(port->serial->interface);
+
 			spin_lock(&portdata->lock);
 			portdata->outstanding_urbs--;
 			spin_unlock(&portdata->lock);
-- 
2.55.0

Re: [PATCH] USB: serial: sierra: fix runtime pm leak on resume failure

[sashiko-bot]

> Make sure to balance the runtime PM usage count also if delayed URB
> submission fails during resume (e.g. to allow runtime PM to be used
> after the driver has been rebound).
> 
> Fixes: e6929a9020ac ("USB: support for autosuspend in sierra while online")
> Cc: Oliver Neukum <oliver@neukum.org>
> Cc: stable@vger.kernel.org	# 2.6.32
> Signed-off-by: Johan Hovold <johan@kernel.org>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261020125347.2145928-1-johan@kernel.org?part=1