[PATCH] USB: quirks: add DEVICE_QUALIFIER quirk for Mobapad C2 Lite gamepad

[PATCH] USB: quirks: add DEVICE_QUALIFIER quirk for Mobapad C2 Lite gamepad

[Danny Zimmer]

The Mobapad C2 Lite gamepad in its "Xbox 360 Controller for Windows" mode
(USB ID 2345:e06e) fails to enumerate on Linux and enters an endless
connect/reset loop. A USB trace shows the device returns its device
descriptor, but then stalls the Device_Qualifier request and stops
answering any further control transfers, so the host resets it and the
cycle repeats indefinitely.

The device works on Windows, which does not issue a Device_Qualifier
request. Setting USB_QUIRK_DEVICE_QUALIFIER so the host skips that request
lets the device enumerate normally; the configuration descriptor is then
read at its usual size without problems and the controller binds as an
xpad gamepad.

Tested on two hosts (x86_64/xhci and Raspberry Pi 3B/dwc_otg).

Signed-off-by: Danny Zimmer <dzimmer50@googlemail.com>
---
 drivers/usb/core/quirks.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index b5b577f..06d15ae 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -586,6 +586,9 @@ static const struct usb_device_id usb_quirk_list[] = {
 	/* VIA Labs, Inc. USB2.0 Hub */
 	{ USB_DEVICE(0x2109, 0x2817), .driver_info = USB_QUIRK_NO_LPM },
 
+	/* Mobapad C2 Lite gamepad - stalls on Device_Qualifier request */
+	{ USB_DEVICE(0x2345, 0xe06e), .driver_info = USB_QUIRK_DEVICE_QUALIFIER },
+
 	/* Raydium Touchscreen */
 	{ USB_DEVICE(0x2386, 0x3114), .driver_info = USB_QUIRK_NO_LPM },
 
-- 
2.43.0

Re: [PATCH] USB: quirks: add DEVICE_QUALIFIER quirk for Mobapad C2 Lite gamepad

[sashiko-bot]

> The Mobapad C2 Lite gamepad in its "Xbox 360 Controller for Windows" mode
> (USB ID 2345:e06e) fails to enumerate on Linux and enters an endless
> connect/reset loop. A USB trace shows the device returns its device
> descriptor, but then stalls the Device_Qualifier request and stops
> answering any further control transfers, so the host resets it and the
> cycle repeats indefinitely.
> 
> The device works on Windows, which does not issue a Device_Qualifier
> request. Setting USB_QUIRK_DEVICE_QUALIFIER so the host skips that request
> lets the device enumerate normally; the configuration descriptor is then
> read at its usual size without problems and the controller binds as an
> xpad gamepad.
> 
> Tested on two hosts (x86_64/xhci and Raspberry Pi 3B/dwc_otg).
> 
> Signed-off-by: Danny Zimmer <dzimmer50@googlemail.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261022061214.3497578-1-dzimmer50@googlemail.com?part=1