Re: [PATCH] dt-bindings: soc: document Casio fx-9750GIII

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: soc: renesas: misplaced board schema and missing root node check
--

commit 954525625db8c56e7940385b08c24b1985903147
Author: Artem Novak <artem122novak@gmail.com>

dt-bindings: soc: document Casio fx-9750GIII

This commit adds the casio vendor prefix to vendor-prefixes.yaml and adds a
new Devicetree binding schema for the Casio fx-9750GIII graphing calculator
based on the Renesas SH7305 processor.

> diff --git a/Documentation/devicetree/bindings/soc/renesas/casio,fx-9750giii.yaml b/Documentation/devicetree/bindings/soc/renesas/casio,fx-9750giii.yaml
> new file mode 100644
> index 0000000000000..f3c1c02f1bd5f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/renesas/casio,fx-9750giii.yaml
> @@ -0,0 +1,33 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/soc/renesas/casio,fx-9750giii.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Casio fx-9750GIII Graphing Calculator
> +
> +maintainers:
> +  - Artem Novak <artem122novak@gmail.com>
> +
> +description:
> +  The Casio fx-9750GIII graphing calculator is based on
> +  the Renesas SH7305 processor.
> +
> +select:
> +  properties:
> +    compatible:
> +      contains:
> +        const: casio,fx-9750giii
> +  required:
> +    - compatible
> +
> +properties:
> +  compatible:
> +    items:
> +      - const: casio,fx-9750giii
> +      - const: renesas,sh7305
> +
> +required:
> +  - compatible
> +
> +additionalProperties: true

[Severity: Low]
Should the casio,fx-9750giii and renesas,sh7305 compatible strings be added
under properties in Documentation/devicetree/bindings/soc/renesas/renesas.yaml
instead of creating a standalone per-board schema file?

In Documentation/devicetree/bindings/soc/renesas/, existing SoC and board
root-node compatible combinations (including SH-Mobile SoCs and third-party
vendor boards) are consolidated in renesas.yaml:

Documentation/devicetree/bindings/soc/renesas/renesas.yaml:
  properties:
    $nodename:
      const: '/'
    compatible:
      oneOf:

With a separate casio,fx-9750giii.yaml file, when running dt_binding_check or
dtbs_check on device trees using casio,fx-9750giii or renesas,sh7305:

1. Because properties in casio,fx-9750giii.yaml sets additionalProperties:
   true without constraining $nodename to '/', the schema can match non-root
   nodes.

2. Because the custom select block in casio,fx-9750giii.yaml only matches
   casio,fx-9750giii, a device tree specifying renesas,sh7305 with a
   different or invalid board compatible will bypass this schema during
   validation, and other SH7305-based boards cannot cleanly share the
   renesas,sh7305 SoC entry.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261022063902.471383-1-artem122novak@gmail.com?part=1