All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: soc: document Casio fx-9750GIII
@ 2026-10-22  6:39 Artem Novak
  2026-10-22  6:49 ` sashiko-bot
  2026-10-22  7:16 ` Krzysztof Kozlowski
  0 siblings, 2 replies; 8+ messages in thread
From: Artem Novak @ 2026-10-22  6:39 UTC (permalink / raw)
  To: robh; +Cc: krzk+dt, conor+dt, devicetree, linux-sh, glaubitz, Artem Novak

Document for the Casio fx-9750GIII graphing calculator,
which is based on the Renesas SH7305 (SH4A) processor.

Add the Casio vendor prefix and the board compatible
binding.

Signed-off-by: Artem Novak <artem122novak@gmail.com>
---
 .../soc/renesas/casio,fx-9750giii.yaml        | 33 +++++++++++++++++++
 .../devicetree/bindings/vendor-prefixes.yaml  |  2 ++
 2 files changed, 35 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/soc/renesas/casio,fx-9750giii.yaml

diff --git a/Documentation/devicetree/bindings/soc/renesas/casio,fx-9750giii.yaml b/Documentation/devicetree/bindings/soc/renesas/casio,fx-9750giii.yaml
new file mode 100644
index 000000000000..f3c1c02f1bd5
--- /dev/null
+++ b/Documentation/devicetree/bindings/soc/renesas/casio,fx-9750giii.yaml
@@ -0,0 +1,33 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/soc/renesas/casio,fx-9750giii.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Casio fx-9750GIII Graphing Calculator
+
+maintainers:
+  - Artem Novak <artem122novak@gmail.com>
+
+description:
+  The Casio fx-9750GIII graphing calculator is based on
+  the Renesas SH7305 processor.
+
+select:
+  properties:
+    compatible:
+      contains:
+        const: casio,fx-9750giii
+  required:
+    - compatible
+
+properties:
+  compatible:
+    items:
+      - const: casio,fx-9750giii
+      - const: renesas,sh7305
+
+required:
+  - compatible
+
+additionalProperties: true
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index ba2002969373..78ba9c29cb56 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -301,6 +301,8 @@ patternProperties:
     description: Capella Microsystems, Inc
   "^cascoda,.*":
     description: Cascoda, Ltd.
+  "^casio,.*":
+    description: Casio Computer Co., Ltd.
   "^catalyst,.*":
     description: Catalyst Semiconductor, Inc.
   "^cavium,.*":
-- 
2.56.0


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH] dt-bindings: soc: document Casio fx-9750GIII
  2026-10-22  6:39 [PATCH] dt-bindings: soc: document Casio fx-9750GIII Artem Novak
@ 2026-10-22  6:49 ` sashiko-bot
  2026-10-22  7:16 ` Krzysztof Kozlowski
  1 sibling, 0 replies; 8+ messages in thread
From: sashiko-bot @ 2026-10-22  6:49 UTC (permalink / raw)
  To: Artem Novak; +Cc: devicetree, robh, conor+dt

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: soc: renesas: misplaced board schema and missing root node check
--

commit 954525625db8c56e7940385b08c24b1985903147
Author: Artem Novak <artem122novak@gmail.com>

dt-bindings: soc: document Casio fx-9750GIII

This commit adds the casio vendor prefix to vendor-prefixes.yaml and adds a
new Devicetree binding schema for the Casio fx-9750GIII graphing calculator
based on the Renesas SH7305 processor.

> diff --git a/Documentation/devicetree/bindings/soc/renesas/casio,fx-9750giii.yaml b/Documentation/devicetree/bindings/soc/renesas/casio,fx-9750giii.yaml
> new file mode 100644
> index 0000000000000..f3c1c02f1bd5f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/renesas/casio,fx-9750giii.yaml
> @@ -0,0 +1,33 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/soc/renesas/casio,fx-9750giii.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Casio fx-9750GIII Graphing Calculator
> +
> +maintainers:
> +  - Artem Novak <artem122novak@gmail.com>
> +
> +description:
> +  The Casio fx-9750GIII graphing calculator is based on
> +  the Renesas SH7305 processor.
> +
> +select:
> +  properties:
> +    compatible:
> +      contains:
> +        const: casio,fx-9750giii
> +  required:
> +    - compatible
> +
> +properties:
> +  compatible:
> +    items:
> +      - const: casio,fx-9750giii
> +      - const: renesas,sh7305
> +
> +required:
> +  - compatible
> +
> +additionalProperties: true

[Severity: Low]
Should the casio,fx-9750giii and renesas,sh7305 compatible strings be added
under properties in Documentation/devicetree/bindings/soc/renesas/renesas.yaml
instead of creating a standalone per-board schema file?

In Documentation/devicetree/bindings/soc/renesas/, existing SoC and board
root-node compatible combinations (including SH-Mobile SoCs and third-party
vendor boards) are consolidated in renesas.yaml:

Documentation/devicetree/bindings/soc/renesas/renesas.yaml:
  properties:
    $nodename:
      const: '/'
    compatible:
      oneOf:

With a separate casio,fx-9750giii.yaml file, when running dt_binding_check or
dtbs_check on device trees using casio,fx-9750giii or renesas,sh7305:

1. Because properties in casio,fx-9750giii.yaml sets additionalProperties:
   true without constraining $nodename to '/', the schema can match non-root
   nodes.

2. Because the custom select block in casio,fx-9750giii.yaml only matches
   casio,fx-9750giii, a device tree specifying renesas,sh7305 with a
   different or invalid board compatible will bypass this schema during
   validation, and other SH7305-based boards cannot cleanly share the
   renesas,sh7305 SoC entry.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261022063902.471383-1-artem122novak@gmail.com?part=1

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] dt-bindings: soc: document Casio fx-9750GIII
  2026-10-22  6:39 [PATCH] dt-bindings: soc: document Casio fx-9750GIII Artem Novak
  2026-10-22  6:49 ` sashiko-bot
@ 2026-10-22  7:16 ` Krzysztof Kozlowski
  2026-10-22  7:27   ` John Paul Adrian Glaubitz
  1 sibling, 1 reply; 8+ messages in thread
From: Krzysztof Kozlowski @ 2026-10-22  7:16 UTC (permalink / raw)
  To: Artem Novak, robh; +Cc: krzk+dt, conor+dt, devicetree, linux-sh, glaubitz

On 22/10/2026 08:39, Artem Novak wrote:
> Document for the Casio fx-9750GIII graphing calculator,
> which is based on the Renesas SH7305 (SH4A) processor.
> 
> Add the Casio vendor prefix and the board compatible
> binding.

This looks oddly wrapped.

Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597

Anyway, I do not understand why this is sent separately from any other
code. We do not take usually bindings without any users.

> 
> Signed-off-by: Artem Novak <artem122novak@gmail.com>
> ---
>  .../soc/renesas/casio,fx-9750giii.yaml        | 33 +++++++++++++++++++
>  .../devicetree/bindings/vendor-prefixes.yaml  |  2 ++
>  2 files changed, 35 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/soc/renesas/casio,fx-9750giii.yaml
> 
> diff --git a/Documentation/devicetree/bindings/soc/renesas/casio,fx-9750giii.yaml b/Documentation/devicetree/bindings/soc/renesas/casio,fx-9750giii.yaml
> new file mode 100644
> index 000000000000..f3c1c02f1bd5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/renesas/casio,fx-9750giii.yaml
> @@ -0,0 +1,33 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/soc/renesas/casio,fx-9750giii.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Casio fx-9750GIII Graphing Calculator
> +
> +maintainers:
> +  - Artem Novak <artem122novak@gmail.com>
> +
> +description:
> +  The Casio fx-9750GIII graphing calculator is based on
> +  the Renesas SH7305 processor.
> +
> +select:
> +  properties:
> +    compatible:
> +      contains:
> +        const: casio,fx-9750giii
> +  required:
> +    - compatible

And this I do not understand at all. Why do you need this?

> +
> +properties:
> +  compatible:
> +    items:
> +      - const: casio,fx-9750giii
> +      - const: renesas,sh7305

Where is any user of this?


Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] dt-bindings: soc: document Casio fx-9750GIII
  2026-10-22  7:16 ` Krzysztof Kozlowski
@ 2026-10-22  7:27   ` John Paul Adrian Glaubitz
  2026-10-22  7:33     ` Krzysztof Kozlowski
  0 siblings, 1 reply; 8+ messages in thread
From: John Paul Adrian Glaubitz @ 2026-10-22  7:27 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Artem Novak, robh
  Cc: krzk+dt, conor+dt, devicetree, linux-sh

On Thu, 2026-10-22 at 09:16 +0200, Krzysztof Kozlowski wrote:
> > +properties:
> > +  compatible:
> > +    items:
> > +      - const: casio,fx-9750giii
> > +      - const: renesas,sh7305
> 
> Where is any user of this?

There is a Casio calculator community out there that are users
for this.

Thanks,
Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] dt-bindings: soc: document Casio fx-9750GIII
  2026-10-22  7:27   ` John Paul Adrian Glaubitz
@ 2026-10-22  7:33     ` Krzysztof Kozlowski
  2026-10-22  7:46       ` John Paul Adrian Glaubitz
  2026-10-22  8:05       ` Artem Novak
  0 siblings, 2 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2026-10-22  7:33 UTC (permalink / raw)
  To: John Paul Adrian Glaubitz, Artem Novak, robh
  Cc: krzk+dt, conor+dt, devicetree, linux-sh

On 22/10/2026 09:27, John Paul Adrian Glaubitz wrote:
> On Thu, 2026-10-22 at 09:16 +0200, Krzysztof Kozlowski wrote:
>>> +properties:
>>> +  compatible:
>>> +    items:
>>> +      - const: casio,fx-9750giii
>>> +      - const: renesas,sh7305
>>
>> Where is any user of this?
> 
> There is a Casio calculator community out there that are users
> for this.

Upstream user, so any known upstream open source project using Linux
kernel DT bindings. We do not need bindings for non-upstream users.

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] dt-bindings: soc: document Casio fx-9750GIII
  2026-10-22  7:33     ` Krzysztof Kozlowski
@ 2026-10-22  7:46       ` John Paul Adrian Glaubitz
  2026-10-22  7:57         ` Krzysztof Kozlowski
  2026-10-22  8:05       ` Artem Novak
  1 sibling, 1 reply; 8+ messages in thread
From: John Paul Adrian Glaubitz @ 2026-10-22  7:46 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Artem Novak, robh
  Cc: krzk+dt, conor+dt, devicetree, linux-sh

On Thu, 2026-10-22 at 09:33 +0200, Krzysztof Kozlowski wrote:
> > There is a Casio calculator community out there that are users
> > for this.
> 
> Upstream user, so any known upstream open source project using Linux
> kernel DT bindings. We do not need bindings for non-upstream users.

Yes, I realized that hadn't had any coffee yet and I misunderstood
that comment.

I think that Artem is sending the users for these bindings in a different
patch set. I have not been able to review the changes for arch/sh yet.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] dt-bindings: soc: document Casio fx-9750GIII
  2026-10-22  7:46       ` John Paul Adrian Glaubitz
@ 2026-10-22  7:57         ` Krzysztof Kozlowski
  0 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2026-10-22  7:57 UTC (permalink / raw)
  To: John Paul Adrian Glaubitz, Artem Novak, robh
  Cc: krzk+dt, conor+dt, devicetree, linux-sh

On 22/10/2026 09:46, John Paul Adrian Glaubitz wrote:
> On Thu, 2026-10-22 at 09:33 +0200, Krzysztof Kozlowski wrote:
>>> There is a Casio calculator community out there that are users
>>> for this.
>>
>> Upstream user, so any known upstream open source project using Linux
>> kernel DT bindings. We do not need bindings for non-upstream users.
> 
> Yes, I realized that hadn't had any coffee yet and I misunderstood
> that comment.
> 
> I think that Artem is sending the users for these bindings in a different
> patch set. I have not been able to review the changes for arch/sh yet.

So this looks like binding for the board/soc, thus must be sent along
with the DTS patchset.

See:
https://lore.kernel.org/all/20231121-topic-sm8650-upstream-dt-v3-0-db9d0507ffd3@linaro.org/

https://lore.kernel.org/linux-samsung-soc/CADrjBPq_0nUYRABKpskRF_dhHu+4K=duPVZX==0pr+cjSL_caQ@mail.gmail.com/T/#m2d9130a1342ab201ab49670fa6c858ee3724c83c

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] dt-bindings: soc: document Casio fx-9750GIII
  2026-10-22  7:33     ` Krzysztof Kozlowski
  2026-10-22  7:46       ` John Paul Adrian Glaubitz
@ 2026-10-22  8:05       ` Artem Novak
  1 sibling, 0 replies; 8+ messages in thread
From: Artem Novak @ 2026-10-22  8:05 UTC (permalink / raw)
  To: Krzysztof Kozlowski, John Paul Adrian Glaubitz, robh
  Cc: krzk+dt, conor+dt, devicetree, linux-sh

Good morning,

The board Device Tree is at
arch/sh/boot/dts/fx9750giii.dts,
in separate patches though.

https://lore.kernel.org/all/20261022063936.472520-2-artem122novak@gmail.com/

https://lore.kernel.org/all/20261022063936.472520-3-artem122novak@gmail.com/

Thanks,
Artem

On 10/22/26 1:33 AM, Krzysztof Kozlowski wrote:
> On 22/10/2026 09:27, John Paul Adrian Glaubitz wrote:
>> On Thu, 2026-10-22 at 09:16 +0200, Krzysztof Kozlowski wrote:
>>>> +properties:
>>>> +  compatible:
>>>> +    items:
>>>> +      - const: casio,fx-9750giii
>>>> +      - const: renesas,sh7305
>>>
>>> Where is any user of this?
>>
>> There is a Casio calculator community out there that are users
>> for this.
> 
> Upstream user, so any known upstream open source project using Linux
> kernel DT bindings. We do not need bindings for non-upstream users.
> 
> Best regards,
> Krzysztof


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2026-10-22  8:05 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-22  6:39 [PATCH] dt-bindings: soc: document Casio fx-9750GIII Artem Novak
2026-10-22  6:49 ` sashiko-bot
2026-10-22  7:16 ` Krzysztof Kozlowski
2026-10-22  7:27   ` John Paul Adrian Glaubitz
2026-10-22  7:33     ` Krzysztof Kozlowski
2026-10-22  7:46       ` John Paul Adrian Glaubitz
2026-10-22  7:57         ` Krzysztof Kozlowski
2026-10-22  8:05       ` Artem Novak

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.