Re: [PATCH 14/27] dt-bindings: net: rockchip-dwmac: Add RK3572

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: net: rockchip,rk3572-gmac missing from snps,dwmac.yaml
--

commit d49e116eebf8a880b2905b76936e70d57c74d68e
Author: Cunhao Lu <1579567540@qq.com>

dt-bindings: net: rockchip-dwmac: Add RK3572

This commit adds the rockchip,rk3572-gmac compatible string with the
snps,dwmac-4.20a fallback to the Rockchip dwmac device tree binding
schema.

> diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
> index 80c252845349c..83b0a81b4f3b7 100644
> --- a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml

[ ... ]

> @@ -54,6 +55,7 @@ properties:
>                - rockchip,rk3506-gmac
>                - rockchip,rk3528-gmac
>                - rockchip,rk3568-gmac
> +              - rockchip,rk3572-gmac
>                - rockchip,rk3576-gmac
>                - rockchip,rk3588-gmac
>                - rockchip,rv1126-gmac

[Severity: Low]
Should rockchip,rk3572-gmac also be added to properties:compatible in
Documentation/devicetree/bindings/net/snps,dwmac.yaml?

Documentation/devicetree/bindings/net/rockchip-dwmac.yaml references
snps,dwmac.yaml# under allOf:

  allOf:
    - $ref: snps,dwmac.yaml#

In Documentation/devicetree/bindings/net/snps,dwmac.yaml,
properties:compatible lists all Rockchip gmac compatibles from
rockchip-dwmac.yaml so that schemas including it can validate properly:

  properties:

    # We need to include all the compatibles from schemas that will
    # include that schemas, otherwise compatible won't validate for
    # those.
    compatible:
      contains:
        enum:
          ...
          - rockchip,rk3506-gmac
          - rockchip,rk3528-gmac
          - rockchip,rk3568-gmac
          - rockchip,rk3576-gmac
          - rockchip,rk3588-gmac
          - rockchip,rv1108-gmac
          - rockchip,rv1126-gmac

Prior commits adding or syncing Rockchip gmac compatibles (such as commit
4a667bec74b3 for rk3506, commit 299e2aefb159 for rk3576, and commit
e774c91dca45) updated snps,dwmac.yaml alongside rockchip-dwmac.yaml,
whereas omitting rockchip,rk3572-gmac leaves the two schemas out of sync.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261022-add-board-ok3572-c-v1-0-0b0fd85a31ee@qq.com?part=14