From: sashiko-bot@kernel.org
To: "Ian Rogers" <irogers@google.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v6 3/3] perf test: Don't count mlock budget wait time towards test timeout
Date: Thu, 22 Oct 2026 22:27:16 +0000 [thread overview]
Message-ID: <sashiko-outbox-182120@kernel.org> (raw)
In-Reply-To: <20261022222245.2064964-4-irogers@google.com>
> When multiple parallel tests need room in kernel.perf_event_mlock_kb,
> they take turns acquiring the shared mlock_budget->lock mutex in
> run_test_case_mlocked() after being forked in start_test().
>
> Because child->start_time is recorded in start_test() when the child
> process is forked, any time a test spends waiting in the
> mlock_budget->lock queue would otherwise be counted against both its
> per-test timeout (causing tests later in the queue to time out before
> they even start) and its JUnit XML testcase elapsed time.
>
> Extend struct mlock_budget with a per-slot shared start_time and started
> flag populated in run_test_case_mlocked() once the child acquires
> mlock_budget->lock. In check_child_timeout(), skip tests that are still
> waiting for mlock_budget->lock and measure the timeout from the lock
> acquisition timestamp once started. Also use the post-lock start_time
> when computing the test's elapsed duration.
>
> Signed-off-by: Ian Rogers <irogers@google.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261022222245.2064964-1-irogers@google.com?part=3
prev parent reply other threads:[~2026-10-22 22:27 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 21:01 [PATCH v1 1/2] perf test: Add per-test timeout support Ian Rogers
2026-09-28 21:01 ` [PATCH v1 2/2] perf test: Improve JUnit XML schema compliance and completeness Ian Rogers
2026-09-28 21:08 ` sashiko-bot
2026-09-28 21:14 ` [PATCH v1 1/2] perf test: Add per-test timeout support sashiko-bot
2026-09-29 1:18 ` [PATCH v2 " Ian Rogers
2026-09-29 1:18 ` [PATCH v2 2/2] perf test: Improve JUnit XML schema compliance and completeness Ian Rogers
2026-09-29 1:24 ` sashiko-bot
2026-09-29 1:31 ` [PATCH v2 1/2] perf test: Add per-test timeout support sashiko-bot
2026-09-29 2:53 ` [PATCH v3 " Ian Rogers
2026-09-29 2:53 ` [PATCH v3 2/2] perf test: Improve JUnit XML schema compliance and completeness Ian Rogers
2026-09-29 2:59 ` sashiko-bot
2026-09-29 3:00 ` [PATCH v3 1/2] perf test: Add per-test timeout support sashiko-bot
2026-10-05 22:44 ` Namhyung Kim
2026-10-12 21:57 ` Ian Rogers
2026-10-12 23:47 ` [PATCH v4 0/3] perf test: Per-test timeouts, JUnit XML compliance, and snippet improvements Ian Rogers
2026-10-12 23:47 ` [PATCH v4 1/3] perf test: Add per-test timeout support Ian Rogers
2026-10-12 23:56 ` sashiko-bot
2026-10-12 23:47 ` [PATCH v4 2/3] perf test: Improve JUnit XML schema compliance and completeness Ian Rogers
2026-10-12 23:54 ` sashiko-bot
2026-10-12 23:47 ` [PATCH v4 3/3] perf test: Avoid stack trace noise in verbose=1 failure snippets Ian Rogers
2026-10-12 23:53 ` sashiko-bot
2026-10-14 21:33 ` [PATCH v4 0/3] perf test: Per-test timeouts, JUnit XML compliance, and snippet improvements Namhyung Kim
2026-10-19 12:22 ` Arnaldo Carvalho de Melo
2026-10-22 16:00 ` Ian Rogers
2026-10-22 21:07 ` [PATCH v5 0/3] perf test: Per-test timeouts and JUnit XML schema compliance Ian Rogers
2026-10-22 21:07 ` [PATCH v5 1/3] perf test: Add per-test timeout support Ian Rogers
2026-10-22 21:21 ` sashiko-bot
2026-10-22 21:07 ` [PATCH v5 2/3] perf test: Improve JUnit XML schema compliance and completeness Ian Rogers
2026-10-22 21:12 ` sashiko-bot
2026-10-22 21:07 ` [PATCH v5 3/3] perf test: Don't count mlock budget wait time towards test timeout Ian Rogers
2026-10-22 21:12 ` sashiko-bot
2026-10-22 22:22 ` [PATCH v6 0/3] perf test: Per-test timeouts and JUnit XML schema compliance Ian Rogers
2026-10-22 22:22 ` [PATCH v6 1/3] perf test: Add per-test timeout support Ian Rogers
2026-10-22 22:34 ` sashiko-bot
2026-10-22 22:22 ` [PATCH v6 2/3] perf test: Improve JUnit XML schema compliance and completeness Ian Rogers
2026-10-22 22:28 ` sashiko-bot
2026-10-22 22:22 ` [PATCH v6 3/3] perf test: Don't count mlock budget wait time towards test timeout Ian Rogers
2026-10-22 22:27 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-182120@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=irogers@google.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.