From: sashiko-bot@kernel.org
To: "James Clark" <james.clark@linaro.org>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 1/2] perf test: Factor out the --skip check and its output
Date: Fri, 23 Oct 2026 09:05:24 +0000 [thread overview]
Message-ID: <sashiko-outbox-182548@kernel.org> (raw)
In-Reply-To: <20261023-james-perf-test-skip-v1-1-b6c11bdafd46@linaro.org>
> __cmd_test() checks the --skip list and prints the "Skip (user
> override)" line and its junit entry inline, and
> perf_test__shares_mlock_budget() repeats the check, with the list passed
> to both from cmd_test().
>
> Make the list static, like the other options, check it in
> perf_test__skip_suite() and move the output to
> print_suite_user_override(), so that the --skip-name option added next
> can hook into the same places.
>
> No functional changes intended.
>
> Signed-off-by: James Clark <james.clark@linaro.org>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261023-james-perf-test-skip-v1-0-b6c11bdafd46@linaro.org?part=1
next prev parent reply other threads:[~2026-10-23 9:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-23 9:01 [PATCH 0/2] perf test: Add --skip-name to skip tests by name James Clark
2026-10-23 9:01 ` [PATCH 1/2] perf test: Factor out the --skip check and its output James Clark
2026-10-23 9:05 ` sashiko-bot [this message]
2026-10-23 9:01 ` [PATCH 2/2] perf test: Add --skip-name to skip tests by name James Clark
2026-10-23 9:09 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-182548@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=james.clark@linaro.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.