Re: [PATCH 2/2] perf test: Add --skip-name to skip tests by name

[sashiko-bot@kernel.org]

> --skip takes test numbers which change whenever tests are added or
> removed, so a list of tests to skip in CI has to be updated as perf
> changes, or it silently skips the wrong tests.
> 
> Add --skip-name to skip a test by its name which should be more stable.
> The option can be repeated to skip more than one test instead of taking
> a comma separated list, as some descriptions contain commas, e.g.:
> 
>   $ perf test --skip-name 'Add fd to a fdarray, making it autogrow' \
>               --skip-name 'Simple expression parser' 7 32 33
>     7: Simple expression parser                : Skip (user override)
>    33: Add fd to a fdarray, making it autogrow : Skip (user override)
>    32: Filter fds with revents mask in a fdarray : Ok
> 
> The match is exact rather than substring so that adding a new test
> containing an existing skip substring doesn't get skipped.
> 
> A name that matches no test exits with an error so that a renamed test
> isn't silently run again:
> 
>   $ perf test --skip-name 'Add fd to a fdarray'
>   No test matches --skip-name 'Add fd to a fdarray'
>   $ echo $?
>   234
> 
> Signed-off-by: James Clark <james.clark@linaro.org>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261023-james-perf-test-skip-v1-0-b6c11bdafd46@linaro.org?part=2