Re: [PATCH 2/7] arm64: dts: qcom: sm8450: Add CSI2 PHY device tree nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] arm64: dts: qcom: sm8450: codename compatible used for csiphy nodes
--

commit 0c7c977d6500322c8d06815e06e46862092f3fc5
Author: Vladimir Zapolskiy <vz@kernel.org>

arm64: dts: qcom: sm8450: Add CSI2 PHY device tree nodes

This commit adds six CAMSS CSIPHY device tree nodes and a shared CSIPHY OPP
table for the Qualcomm SM8450 (Waipio) SoC.

> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> index b8793482b1815..b70a8635c6be8 100644
> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi

[ ... ]

> @@ -3298,6 +3314,270 @@ cci1_i2c1: i2c-bus@1 {
>  			};
>  		};
>  
> +		csiphy0: phy@ace4000 {
> +			compatible = "qcom,waipio-csi2-phy", "qcom,x1e80100-csi2-phy";

[Severity: Low]
Should csiphy0 through csiphy5 in arch/arm64/boot/dts/qcom/sm8450.dtsi (and
the corresponding binding in
Documentation/devicetree/bindings/phy/qcom,x1e80100-csi2-phy.yaml) use the
SoC model-number compatible "qcom,sm8450-csi2-phy" instead of the internal
codename "qcom,waipio-csi2-phy"?

In Documentation/devicetree/bindings/arm/qcom.yaml, the canonical SoC
compatible for Waipio is "qcom,sm8450", and
Documentation/devicetree/bindings/arm/qcom-soc.yaml specifies that SoCs
numbered with sm[0-9]+ use "qcom,sm<number>-*" for component compatibles,
while codename-based compatibles are reserved for the newer codename-only
SoCs:

        # Preferred naming style for compatibles of SoC components:
        - pattern: "^qcom,(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm|x1[ep])[0-9]+(pro)?-.*$"
        - pattern: "^qcom,sar[0-9]+[a-z]?-.*$"
        - pattern: "^qcom,(sa|sc)8[0-9]+[a-z][a-z]?-.*$"
        - pattern: "^qcom,(eliza|kaanapali|glymur|hawi|mahua|maili|milos|nord|shikra)-.+$"

All other SoC-specific blocks in arch/arm64/boot/dts/qcom/sm8450.dtsi,
including the camera subsystem nodes camcc ("qcom,sm8450-camcc") and
cci0/cci1 ("qcom,sm8450-cci") as well as all other PHY nodes, follow the
"qcom,sm8450-*" naming convention.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261023163057.775917-1-vz@kernel.org?part=2