[PATCH 1/4] 9p: fix header guard comment in acl.h

[PATCH 1/4] 9p: fix header guard comment in acl.h

[Ankit Thakur]

The closing comment of the include guard says FS_9P_XATTR_H, but the
guard macro is FS_9P_ACL_H. Fix the comment to match.

Signed-off-by: Ankit Thakur <codeankit.thakur@gmail.com>
---
 fs/9p/acl.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/9p/acl.h b/fs/9p/acl.h
index 2d1b24abc..d123ab613 100644
--- a/fs/9p/acl.h
+++ b/fs/9p/acl.h
@@ -51,4 +51,4 @@ static inline int v9fs_acl_mode(struct inode *dir, umode_t *modep,
 }
 
 #endif
-#endif /* FS_9P_XATTR_H */
+#endif /* FS_9P_ACL_H */
-- 
2.55.0.windows.3

[PATCH 2/4] 9p: fix typos and wrong parameter docs in vfs_inode.c

[Ankit Thakur]

Fix spelling mistakes in comments (functon -> function, Hadlink ->
Hardlink).

Also fix the kernel-doc of v9fs_vfs_mkdir(), which described @dir and
@dentry as being unlinked instead of being the parent directory and the
directory being created.

Signed-off-by: Ankit Thakur <codeankit.thakur@gmail.com>
---
 fs/9p/vfs_inode.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/fs/9p/vfs_inode.c b/fs/9p/vfs_inode.c
index 537cb22ac..0585cc915 100644
--- a/fs/9p/vfs_inode.c
+++ b/fs/9p/vfs_inode.c
@@ -481,7 +481,7 @@ static int v9fs_at_to_dotl_flags(int flags)
 }
 
 /**
- * v9fs_dec_count - helper functon to drop i_nlink.
+ * v9fs_dec_count - helper function to drop i_nlink.
  *
  * If a directory had nlink <= 2 (including . and ..), then we should not drop
  * the link count, which indicates the underlying exported fs doesn't maintain
@@ -673,8 +673,8 @@ v9fs_vfs_create(const struct mnt_idmap *idmap, struct inode *dir,
 /**
  * v9fs_vfs_mkdir - VFS mkdir hook to create a directory
  * @idmap: idmap of the mount
- * @dir:  inode that is being unlinked
- * @dentry: dentry that is being unlinked
+ * @dir: inode of the parent directory
+ * @dentry: dentry representing the directory being created
  * @mode: mode for new directory
  *
  */
@@ -1134,7 +1134,7 @@ v9fs_stat2inode(struct p9_wstat *stat, struct inode *inode,
 		if (v9fs_proto_dotu(v9ses)) {
 			unsigned int i_nlink;
 			/*
-			 * Hadlink support got added later to the .u extension.
+			 * Hardlink support got added later to the .u extension.
 			 * So there can be a server out there that doesn't
 			 * support this even with .u extension. That would
 			 * just leave us with stat->extension being an empty
-- 
2.55.0.windows.3

[PATCH 3/4] 9p: remove duplicated assignment in v9fs_fill_super()

[Ankit Thakur]

The declaration of v9ses assigns it twice (v9ses = v9ses =
sb->s_fs_info). Drop the redundant assignment. No functional change.

Signed-off-by: Ankit Thakur <codeankit.thakur@gmail.com>
---
 fs/9p/vfs_super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/9p/vfs_super.c b/fs/9p/vfs_super.c
index 795260446..7b67193d9 100644
--- a/fs/9p/vfs_super.c
+++ b/fs/9p/vfs_super.c
@@ -34,7 +34,7 @@ static const struct super_operations v9fs_super_ops, v9fs_super_ops_dotl;
 static int v9fs_fill_super(struct super_block *sb)
 {
 	int ret;
-	struct v9fs_session_info *v9ses = v9ses = sb->s_fs_info;
+	struct v9fs_session_info *v9ses = sb->s_fs_info;
 
 	sb->s_maxbytes = MAX_LFS_FILESIZE;
 	sb->s_blocksize_bits = fls(v9ses->maxdata - 1);
-- 
2.55.0.windows.3

[PATCH 4/4] 9p: fix typo in file header comments

[Ankit Thakur]

Fix the spelling mistake contians -> contains in the header comments
of vfs_addr.c, vfs_dentry.c and vfs_file.c.

Signed-off-by: Ankit Thakur <codeankit.thakur@gmail.com>
---
 fs/9p/vfs_addr.c   | 2 +-
 fs/9p/vfs_dentry.c | 2 +-
 fs/9p/vfs_file.c   | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/fs/9p/vfs_addr.c b/fs/9p/vfs_addr.c
index 170a2b91c..3723c827c 100644
--- a/fs/9p/vfs_addr.c
+++ b/fs/9p/vfs_addr.c
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0-only
 /*
- * This file contians vfs address (mmap) ops for 9P2000.
+ * This file contains vfs address (mmap) ops for 9P2000.
  *
  *  Copyright (C) 2005 by Eric Van Hensbergen <ericvh@gmail.com>
  *  Copyright (C) 2002 by Ron Minnich <rminnich@lanl.gov>
diff --git a/fs/9p/vfs_dentry.c b/fs/9p/vfs_dentry.c
index fa6b7143d..5b05fa7bb 100644
--- a/fs/9p/vfs_dentry.c
+++ b/fs/9p/vfs_dentry.c
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0-only
 /*
- * This file contians vfs dentry ops for the 9P2000 protocol.
+ * This file contains vfs dentry ops for the 9P2000 protocol.
  *
  *  Copyright (C) 2004 by Eric Van Hensbergen <ericvh@gmail.com>
  *  Copyright (C) 2002 by Ron Minnich <rminnich@lanl.gov>
diff --git a/fs/9p/vfs_file.c b/fs/9p/vfs_file.c
index cddfb4b7c..a983ef866 100644
--- a/fs/9p/vfs_file.c
+++ b/fs/9p/vfs_file.c
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0-only
 /*
- * This file contians vfs file ops for 9P2000.
+ * This file contains vfs file ops for 9P2000.
  *
  *  Copyright (C) 2004 by Eric Van Hensbergen <ericvh@gmail.com>
  *  Copyright (C) 2002 by Ron Minnich <rminnich@lanl.gov>
-- 
2.55.0.windows.3

Re: [PATCH 4/4] 9p: fix typo in file header comments

[sashiko-bot]

> Fix the spelling mistake contians -> contains in the header comments
> of vfs_addr.c, vfs_dentry.c and vfs_file.c.
> 
> Signed-off-by: Ankit Thakur <codeankit.thakur@gmail.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261024092154.1844-1-codeankit.thakur@gmail.com?part=4

Re: [PATCH 2/4] 9p: fix typos and wrong parameter docs in vfs_inode.c

[sashiko-bot]

> Fix spelling mistakes in comments (functon -> function, Hadlink ->
> Hardlink).
> 
> Also fix the kernel-doc of v9fs_vfs_mkdir(), which described @dir and
> @dentry as being unlinked instead of being the parent directory and the
> directory being created.
> 
> Signed-off-by: Ankit Thakur <codeankit.thakur@gmail.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261024092154.1844-1-codeankit.thakur@gmail.com?part=2

Re: [PATCH 3/4] 9p: remove duplicated assignment in v9fs_fill_super()

[sashiko-bot]

> The declaration of v9ses assigns it twice (v9ses = v9ses =
> sb->s_fs_info). Drop the redundant assignment. No functional change.
> 
> Signed-off-by: Ankit Thakur <codeankit.thakur@gmail.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261024092154.1844-1-codeankit.thakur@gmail.com?part=3

Re: [PATCH 1/4] 9p: fix header guard comment in acl.h

[sashiko-bot]

> The closing comment of the include guard says FS_9P_XATTR_H, but the
> guard macro is FS_9P_ACL_H. Fix the comment to match.
> 
> Signed-off-by: Ankit Thakur <codeankit.thakur@gmail.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261024092154.1844-1-codeankit.thakur@gmail.com?part=1

Re: [PATCH 1/4] 9p: fix header guard comment in acl.h

[Dominique Martinet]

Thanks, I've picked up the 4 patches

-- 
Dominique Martinet | Asmadeus