Re: [PATCH v2 12/12] arm64: dts: qcom: qcs615: Add GP M/N clock controller

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] arm64: dts: qcom: talos: Undocumented gp_mn function in qcom,qcs615-tlmm
--

commit 80bf224325113e6fa5a7296e11cbe281f6b0c0e8
Author: Taniya Das <taniya.das@oss.qualcomm.com>

arm64: dts: qcom: qcs615: Add GP M/N clock controller

This commit adds the GP M/N clock controller node and its gp_mn_active pin
configuration state to arch/arm64/boot/dts/qcom/talos.dtsi.

> diff --git a/arch/arm64/boot/dts/qcom/talos.dtsi b/arch/arm64/boot/dts/qcom/talos.dtsi
> index 8ed6f2755705c..c415e782804ca 100644
> --- a/arch/arm64/boot/dts/qcom/talos.dtsi
> +++ b/arch/arm64/boot/dts/qcom/talos.dtsi
> @@ -1611,6 +1611,13 @@ cam_mclk1_default: cam-mclk1-default-state {
>  				bias-disable;
>  			};
>  
> +			gp_mn_active: gp-mn-active-state {
> +				pins = "gpio29";
> +				function = "gp_mn";
> +				drive-strength = <2>;
> +				bias-disable;
> +			};

[Severity: Low]
In arch/arm64/boot/dts/qcom/talos.dtsi, gp_mn_active is added under tlmm
(compatible "qcom,qcs615-tlmm") with function = "gp_mn".

While commit 110a5e6a912b added gp_mn to enum qcs615_functions in
drivers/pinctrl/qcom/pinctrl-qcs615.c, Documentation/devicetree/bindings/pinctrl/qcom,qcs615-tlmm.yaml
does not list gp_mn in the function enum under qcom-qcs615-tlmm-state:

Documentation/devicetree/bindings/pinctrl/qcom,qcs615-tlmm.yaml:
      function:
        description:
          Specify the alternative function to be configured for the specified
          pins.
        enum: [ gpio, adsp_ext, agera_pll, aoss_cti, atest_char, atest_tsens,
                atest_usb, cam_mclk, cci_async, cci_i2c, cci_timer, copy_gp,
                copy_phase, cri_trng, dbg_out_clk, ddr_bist, ddr_pxi, dp_hot,
                edp_hot, edp_lcd, emac_gcc, emac_phy_intr, forced_usb, gcc_gp,
                gp_pdm, gps_tx, hs0_mi2s, hs1_mi2s, jitter_bist, ldo_en,

Should gp_mn also be added to the function enum in
Documentation/devicetree/bindings/pinctrl/qcom,qcs615-tlmm.yaml (as well as
the corresponding pinctrl schemas for the other SoCs in this series) so that
make dtbs_check does not fail validation on gp-mn-active-state?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261026-b4-pdm_clk_gp_mnd_v2-v2-0-ff8e4bc8d567@oss.qualcomm.com?part=12