* [PATCH v3 0/3] Add support for Talos Lyra EVK board
@ 2026-10-27 11:31 Ruchira Revdekar
2026-10-27 11:31 ` [PATCH v3 1/3] dt-bindings: arm: qcom: Add " Ruchira Revdekar
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Ruchira Revdekar @ 2026-10-27 11:31 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Ruchira Revdekar,
Avaneesh Kumar Dwivedi, Monish Chunara, Rakesh Kota,
Sayali Lokhande, Nirmesh Kumar Singh, Akash Kumar,
Khalid Faisal Ansari, Vishnu Santhosh, Vishnu Saini
This series continues work originally posted by Avaneesh Kumar Dwivedi [1].
This series adds initial device tree support for the Talos Lyra EVK,
a QCS615-based System on Module (SoM) paired with a carrier board.
The Talos Lyra SoM is a compact compute module integrating the QCS615 SoC,
PMICs, memory, and essential connectivity. It is designed to be paired with
multiple carrier boards to support different use cases.
Talos Lyra is a distinct SoM revision of the existing Talos EVK SoM. The
key differences are:
- Adds Apache (Lite-on-Module) WLAN on SoC Card.
- Removes SPI-attached CAN transceiver module.
- SDC2 on the existing Talos SoM supported SDIO-based WLAN; it is now
used for the SD card connector only.
Note: The following are not included in this series and will be posted
as follow-ups:
- WLAN node
- USB Type-C OTG role switching via CYPD6129 controller (OTG support,
VBUS supply management). USB controllers are set to peripheral/host
for initial bring-up only.
[1] Link: https://lore.kernel.org/r/20260901-lyra_upstreaming-v1-0-e3a76dc9e21c@oss.qualcomm.com
Changes in v3:
- Remove inapplicable Tested-by from dt-bindings patch
- Fix DP HPD: use native pinctrl in mdss_dp0 instead of hpd-gpios in dp0-connector
- Fix model string: capitalize "Lyra"
- Squash EL2 overlay Makefile changes into board DTS patch
- Move USB PHY supply nodes to SoM DTSI (supplies are SoM PMIC-routed)
- Sort &node overrides alphabetically in board DTS (&tlmm before &usb_*)
- Reword dt-bindings commit message: clarify board/SoM relationship and explain absence of SoM-specific compatible
- Link to v2: https://patch.msgid.link/20261012-talos-lyra-evk-v2-v2-0-dcc9316ebb59@oss.qualcomm.com
Changes in v2:
- Drop qcom,talos-lyra-evk-som compatible from the binding; group
qcom,talos-lyra-evk under the existing talos-evk block instead
- Remove unused regulators vreg_s3a (smps3), vreg_s5a (smps5) and
vreg_s6a (smps6) from the SoM device tree
- Update board compatible string to remove qcom,talos-lyra-evk-som
- Add "talos:" subsystem prefix to patches 2 and 3 subjects
- Set initial-mode to HPM for all LDOs (ldo3, ldo11, ldo13, ldo15, ldo16)
- Add EL2 overlay for talos-lyra-evk as a separate patch (patch 4)
Changes in v1:
- dt-bindings for the Talos Lyra EVK board.
- Talos Lyra SoM DTSI with PMIC, regulators, storage (UFS/SD),
QUPv3 instances, ADSP/CDSP remoteprocs, and GPU definitions.
- Talos Lyra EVK board DTS enabling DisplayPort, GPIO expanders,
SPI-attached TPM (ST33), and USB on the carrier board.
Signed-off-by: Ruchira Revdekar <ruchira.revdekar@oss.qualcomm.com>
---
Avaneesh Kumar Dwivedi (3):
dt-bindings: arm: qcom: Add Talos Lyra EVK board
arm64: dts: qcom: talos: Add Talos Lyra EVK SoM platform
arm64: dts: qcom: talos: Add Talos Lyra EVK board
Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
arch/arm64/boot/dts/qcom/Makefile | 5 +
arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi | 281 +++++++++++++++++++++++
arch/arm64/boot/dts/qcom/talos-lyra-evk.dts | 115 ++++++++++
4 files changed, 402 insertions(+)
---
base-commit: becb95e45ef0dda9ffb35156d909d3da7a2789c3
change-id: 20261007-talos-lyra-evk-v2-e2e588a34f6d
Best regards,
--
Ruchira Revdekar <ruchira.revdekar@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH v3 1/3] dt-bindings: arm: qcom: Add Talos Lyra EVK board
2026-10-27 11:31 [PATCH v3 0/3] Add support for Talos Lyra EVK board Ruchira Revdekar
@ 2026-10-27 11:31 ` Ruchira Revdekar
2026-10-27 18:41 ` Krzysztof Kozlowski
2026-10-27 11:31 ` [PATCH v3 2/3] arm64: dts: qcom: talos: Add Talos Lyra EVK SoM platform Ruchira Revdekar
2026-10-27 11:31 ` [PATCH v3 3/3] arm64: dts: qcom: talos: Add Talos Lyra EVK board Ruchira Revdekar
2 siblings, 1 reply; 6+ messages in thread
From: Ruchira Revdekar @ 2026-10-27 11:31 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Ruchira Revdekar,
Avaneesh Kumar Dwivedi
From: Avaneesh Kumar Dwivedi <avaneesh.dwivedi@oss.qualcomm.com>
Add the qcom,talos-lyra-evk compatible string for the Talos Lyra EVK
board. The Talos Lyra EVK pairs the Talos Lyra SoM with a carrier board.
The SoM uses the same QCS615/SM6150 SoC as the existing Talos EVK, so
qcom,talos-lyra-evk is grouped under the existing talos-evk block rather
than introducing a SoM-specific compatible.
Signed-off-by: Avaneesh Kumar Dwivedi <avaneesh.dwivedi@oss.qualcomm.com>
Signed-off-by: Ruchira Revdekar <ruchira.revdekar@oss.qualcomm.com>
---
Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 121ca557ce1e..d0e30d6c1d4c 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -1089,6 +1089,7 @@ properties:
- enum:
- qcom,qcs615-ride
- qcom,talos-evk
+ - qcom,talos-lyra-evk
- const: qcom,qcs615
- const: qcom,sm6150
--
2.43.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v3 1/3] dt-bindings: arm: qcom: Add Talos Lyra EVK board
2026-10-27 11:31 ` [PATCH v3 1/3] dt-bindings: arm: qcom: Add " Ruchira Revdekar
@ 2026-10-27 18:41 ` Krzysztof Kozlowski
0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2026-10-27 18:41 UTC (permalink / raw)
To: Ruchira Revdekar
Cc: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
linux-kernel, Avaneesh Kumar Dwivedi
On Tue, Oct 27, 2026 at 05:01:55PM +0530, Ruchira Revdekar wrote:
> From: Avaneesh Kumar Dwivedi <avaneesh.dwivedi@oss.qualcomm.com>
>
> Add the qcom,talos-lyra-evk compatible string for the Talos Lyra EVK
> board. The Talos Lyra EVK pairs the Talos Lyra SoM with a carrier board.
> The SoM uses the same QCS615/SM6150 SoC as the existing Talos EVK, so
> qcom,talos-lyra-evk is grouped under the existing talos-evk block rather
> than introducing a SoM-specific compatible.
I do not understand this logic at all. Usage of same SoC has nothing to
do with having or not having SoM compatible. Every SoM uses same
compatible as some other device, so we should drop all SoM-compatibles
in the future?.
So if you have a SoM then it can be used with different boards, thus it
should have its own compatible.
Again, explain properly the hardware if this is the chosen design.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v3 2/3] arm64: dts: qcom: talos: Add Talos Lyra EVK SoM platform
2026-10-27 11:31 [PATCH v3 0/3] Add support for Talos Lyra EVK board Ruchira Revdekar
2026-10-27 11:31 ` [PATCH v3 1/3] dt-bindings: arm: qcom: Add " Ruchira Revdekar
@ 2026-10-27 11:31 ` Ruchira Revdekar
2026-10-27 11:53 ` sashiko-bot
2026-10-27 11:31 ` [PATCH v3 3/3] arm64: dts: qcom: talos: Add Talos Lyra EVK board Ruchira Revdekar
2 siblings, 1 reply; 6+ messages in thread
From: Ruchira Revdekar @ 2026-10-27 11:31 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Ruchira Revdekar,
Avaneesh Kumar Dwivedi, Monish Chunara, Rakesh Kota,
Sayali Lokhande, Nirmesh Kumar Singh
From: Avaneesh Kumar Dwivedi <avaneesh.dwivedi@oss.qualcomm.com>
Introduce the device tree for the QCS615-based Talos Lyra EVK SoM.
Lyra EVK SoM is a compact compute module integrating the QCS615 SoC,
PMIC, and essential connectivity, designed to mount on carrier boards.
The initial SoM device tree includes basic support for:
- CPU and memory
- PMIC and board-level regulators
- UFS and SD card storage
- QUPv3 (I2C/SPI/UART) instances
- ADSP/CDSP remoteprocs
- GPU
Co-developed-by: Monish Chunara <quic_mchunara@quicinc.com>
Signed-off-by: Monish Chunara <quic_mchunara@quicinc.com>
Co-developed-by: Rakesh Kota <rakesh.kota@oss.qualcomm.com>
Signed-off-by: Rakesh Kota <rakesh.kota@oss.qualcomm.com>
Co-developed-by: Sayali Lokhande <sayalil@qti.qualcomm.com>
Signed-off-by: Sayali Lokhande <sayalil@qti.qualcomm.com>
Tested-by: Nirmesh Kumar Singh <nirmesh.singh@oss.qualcomm.com>
Signed-off-by: Avaneesh Kumar Dwivedi <avaneesh.dwivedi@oss.qualcomm.com>
Signed-off-by: Ruchira Revdekar <ruchira.revdekar@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi | 281 +++++++++++++++++++++++
1 file changed, 281 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi b/arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi
new file mode 100644
index 000000000000..7d9a08471906
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi
@@ -0,0 +1,281 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
+ */
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
+#include "talos.dtsi"
+#include "pm8150.dtsi"
+/ {
+ aliases {
+ mmc0 = &sdhc_1;
+ mmc1 = &sdhc_2;
+ serial0 = &uart0;
+ };
+
+ chosen {
+ stdout-path = "serial0:115200n8";
+ };
+
+ clocks {
+ sleep_clk: sleep-clk {
+ compatible = "fixed-clock";
+ clock-frequency = <32764>;
+ #clock-cells = <0>;
+ };
+
+ xo_board_clk: xo-board-clk {
+ compatible = "fixed-clock";
+ clock-frequency = <38400000>;
+ #clock-cells = <0>;
+ };
+ };
+};
+
+&apps_rsc {
+ regulators-0 {
+ compatible = "qcom,pm8150-rpmh-regulators";
+ qcom,pmic-id = "a";
+
+ vreg_s4a: smps4 {
+ regulator-name = "vreg_s4a";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1829000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l1a: ldo1 {
+ regulator-name = "vreg_l1a";
+ regulator-min-microvolt = <856000>;
+ regulator-max-microvolt = <856000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ regulator-allow-set-load;
+ regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+ RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l2a: ldo2 {
+ regulator-name = "vreg_l2a";
+ regulator-min-microvolt = <1650000>;
+ regulator-max-microvolt = <3100000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ regulator-allow-set-load;
+ regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+ RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l3a: ldo3 {
+ regulator-name = "vreg_l3a";
+ regulator-min-microvolt = <1000000>;
+ regulator-max-microvolt = <1248000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ regulator-allow-set-load;
+ regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+ RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l5a: ldo5 {
+ regulator-name = "vreg_l5a";
+ regulator-min-microvolt = <875000>;
+ regulator-max-microvolt = <975000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ regulator-allow-set-load;
+ regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+ RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l7a: ldo7 {
+ regulator-name = "vreg_l7a";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1900000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ regulator-allow-set-load;
+ regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+ RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l8a: ldo8 {
+ regulator-name = "vreg_l8a";
+ regulator-min-microvolt = <1150000>;
+ regulator-max-microvolt = <1350000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ regulator-allow-set-load;
+ regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+ RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l10a: ldo10 {
+ regulator-name = "vreg_l10a";
+ regulator-min-microvolt = <2950000>;
+ regulator-max-microvolt = <3312000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ regulator-allow-set-load;
+ regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+ RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l11a: ldo11 {
+ regulator-name = "vreg_l11a";
+ regulator-min-microvolt = <1232000>;
+ regulator-max-microvolt = <1260000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ regulator-allow-set-load;
+ regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+ RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l12a: ldo12 {
+ regulator-name = "vreg_l12a";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1890000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l13a: ldo13 {
+ regulator-name = "vreg_l13a";
+ regulator-min-microvolt = <3000000>;
+ regulator-max-microvolt = <3230000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ regulator-allow-set-load;
+ regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+ RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l15a: ldo15 {
+ regulator-name = "vreg_l15a";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1904000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ regulator-allow-set-load;
+ regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+ RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l16a: ldo16 {
+ regulator-name = "vreg_l16a";
+ regulator-min-microvolt = <3000000>;
+ regulator-max-microvolt = <3312000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ regulator-allow-set-load;
+ regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+ RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l17a: ldo17 {
+ regulator-name = "vreg_l17a";
+ regulator-min-microvolt = <2950000>;
+ regulator-max-microvolt = <3312000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+ };
+};
+
+&gpu {
+ status = "okay";
+};
+
+&gpu_zap_shader {
+ firmware-name = "qcom/qcs615/a612_zap.mbn";
+};
+
+&qupv3_id_0 {
+ status = "okay";
+};
+
+&qupv3_id_1 {
+ status = "okay";
+};
+
+&remoteproc_adsp {
+ firmware-name = "qcom/qcs615/adsp.mbn";
+
+ status = "okay";
+};
+
+&remoteproc_cdsp {
+ firmware-name = "qcom/qcs615/cdsp.mbn";
+
+ status = "okay";
+};
+
+&sdhc_1 {
+ pinctrl-0 = <&sdc1_state_on>;
+ pinctrl-1 = <&sdc1_state_off>;
+ pinctrl-names = "default", "sleep";
+ bus-width = <8>;
+ mmc-ddr-1_8v;
+ mmc-hs200-1_8v;
+ mmc-hs400-1_8v;
+ mmc-hs400-enhanced-strobe;
+ vmmc-supply = <&vreg_l17a>;
+ vqmmc-supply = <&vreg_s4a>;
+ non-removable;
+ no-sd;
+ no-sdio;
+
+ status = "okay";
+};
+
+&sdhc_2 {
+ pinctrl-0 = <&sdc2_state_on>;
+ pinctrl-1 = <&sdc2_state_off>;
+ pinctrl-names = "default", "sleep";
+ bus-width = <4>;
+ cd-gpios = <&tlmm 99 GPIO_ACTIVE_LOW>;
+ vmmc-supply = <&vreg_l10a>;
+ vqmmc-supply = <&vreg_s4a>;
+
+ status = "okay";
+};
+
+&uart0 {
+ status = "okay";
+};
+
+&ufs_mem_hc {
+ reset-gpios = <&tlmm 123 GPIO_ACTIVE_LOW>;
+ vcc-supply = <&vreg_l17a>;
+ vcc-max-microamp = <600000>;
+ vccq2-supply = <&vreg_s4a>;
+ vccq2-max-microamp = <600000>;
+
+ status = "okay";
+};
+
+&ufs_mem_phy {
+ vdda-phy-supply = <&vreg_l5a>;
+ vdda-pll-supply = <&vreg_l12a>;
+
+ status = "okay";
+};
+
+&usb_1_hsphy {
+ vdd-supply = <&vreg_l5a>;
+ vdda-pll-supply = <&vreg_l12a>;
+ vdda-phy-dpdm-supply = <&vreg_l13a>;
+
+ status = "okay";
+};
+
+&usb_2_hsphy {
+ vdd-supply = <&vreg_l5a>;
+ vdda-pll-supply = <&vreg_l12a>;
+ vdda-phy-dpdm-supply = <&vreg_l13a>;
+
+ status = "okay";
+};
+
+&usb_qmpphy {
+ vdda-phy-supply = <&vreg_l5a>;
+ vdda-pll-supply = <&vreg_l12a>;
+
+ status = "okay";
+};
+
+&usb_qmpphy_2 {
+ vdda-phy-supply = <&vreg_l5a>;
+ vdda-pll-supply = <&vreg_l12a>;
+
+ status = "okay";
+};
--
2.43.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v3 2/3] arm64: dts: qcom: talos: Add Talos Lyra EVK SoM platform
2026-10-27 11:31 ` [PATCH v3 2/3] arm64: dts: qcom: talos: Add Talos Lyra EVK SoM platform Ruchira Revdekar
@ 2026-10-27 11:53 ` sashiko-bot
0 siblings, 0 replies; 6+ messages in thread
From: sashiko-bot @ 2026-10-27 11:53 UTC (permalink / raw)
To: Ruchira Revdekar; +Cc: devicetree, robh, conor+dt
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] arm64: dts: qcom: talos-lyra-evk-som: wrong vqmmc-supply on sdhc_2 breaks 3.3V/UHS-I
--
commit 9f59ab084ac5176f461f2df3b23f3bc182845992
Author: Avaneesh Kumar Dwivedi <avaneesh.dwivedi@oss.qualcomm.com>
arm64: dts: qcom: talos: Add Talos Lyra EVK SoM platform
This commit introduces the initial device tree for the QCS615-based Talos Lyra
EVK SoM platform, including definitions for CPU, memory, PMIC regulators, UFS
and SD/MMC storage, QUPv3, remoteprocs, and GPU.
> diff --git a/arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi b/arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi
> new file mode 100644
> index 0000000000000..7d9a084719067
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi
> @@ -0,0 +1,281 @@
[ ... ]
> +&apps_rsc {
> + regulators-0 {
> + compatible = "qcom,pm8150-rpmh-regulators";
> + qcom,pmic-id = "a";
> +
> + vreg_s4a: smps4 {
> + regulator-name = "vreg_s4a";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1829000>;
> + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> + };
[ ... ]
> + vreg_l2a: ldo2 {
> + regulator-name = "vreg_l2a";
> + regulator-min-microvolt = <1650000>;
> + regulator-max-microvolt = <3100000>;
> + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> + regulator-allow-set-load;
> + regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
> + RPMH_REGULATOR_MODE_HPM>;
> + };
[ ... ]
> +&sdhc_2 {
> + pinctrl-0 = <&sdc2_state_on>;
> + pinctrl-1 = <&sdc2_state_off>;
> + pinctrl-names = "default", "sleep";
> + bus-width = <4>;
> + cd-gpios = <&tlmm 99 GPIO_ACTIVE_LOW>;
> + vmmc-supply = <&vreg_l10a>;
> + vqmmc-supply = <&vreg_s4a>;
[Severity: Medium]
Should sdhc_2 use vreg_l2a instead of vreg_s4a for vqmmc-supply?
Here, vreg_s4a is constrained to 1.8V-1.829V, while sdhc_2 is the removable SD
card controller. When sdhci_msm_set_regulator_caps() in
drivers/mmc/host/sdhci-msm.c and sdhci_setup_host() in
drivers/mmc/host/sdhci.c check vqmmc, they see that 2.7V-3.6V is unsupported:
drivers/mmc/host/sdhci-msm.c:sdhci_msm_set_regulator_caps()
if (!IS_ERR(mmc->supply.vqmmc)) {
if (regulator_is_supported_voltage(supply, 1700000, 1950000))
caps |= CORE_1_8V_SUPPORT;
if (regulator_is_supported_voltage(supply, 2700000, 3600000))
caps |= CORE_3_0V_SUPPORT;
drivers/mmc/host/sdhci.c:sdhci_setup_host()
if (!regulator_is_supported_voltage(mmc->supply.vqmmc, 2700000,
3600000))
host->flags &= ~SDHCI_SIGNALING_330;
Because CORE_3_0V_SUPPORT is not set and SDHCI_SIGNALING_330 is cleared,
initial 3.3V SD signaling in mmc_power_up() ->
mmc_set_initial_signal_voltage() -> sdhci_msm_start_signal_voltage_switch()
fails with -EINVAL, breaking 3.3V initial I/O signaling and UHS-I voltage
switching.
Meanwhile, vreg_l2a (ldo2, 1.65V-3.1V) is defined in this file with no
consumers, similar to the issue on QCS615 Ride fixed in commit 4614628bea86
("arm64: dts: qcom: qcs615-ride: fix sdhc_2 vqmmc-supply for UHS-I mode").
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261027-talos-lyra-evk-v2-v3-0-658fd5a7ec99@oss.qualcomm.com?part=2
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v3 3/3] arm64: dts: qcom: talos: Add Talos Lyra EVK board
2026-10-27 11:31 [PATCH v3 0/3] Add support for Talos Lyra EVK board Ruchira Revdekar
2026-10-27 11:31 ` [PATCH v3 1/3] dt-bindings: arm: qcom: Add " Ruchira Revdekar
2026-10-27 11:31 ` [PATCH v3 2/3] arm64: dts: qcom: talos: Add Talos Lyra EVK SoM platform Ruchira Revdekar
@ 2026-10-27 11:31 ` Ruchira Revdekar
2 siblings, 0 replies; 6+ messages in thread
From: Ruchira Revdekar @ 2026-10-27 11:31 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Ruchira Revdekar,
Avaneesh Kumar Dwivedi, Akash Kumar, Khalid Faisal Ansari,
Vishnu Santhosh, Vishnu Saini, Nirmesh Kumar Singh
From: Avaneesh Kumar Dwivedi <avaneesh.dwivedi@oss.qualcomm.com>
Add the device tree for the Talos Lyra EVK platform which combines
the Talos Lyra EVK SoM and Lyra carrier board.
This device tree adds board-specific peripheral configuration on top
of the SoM, including:
- Native DisplayPort output
- GPIO expanders on i2c5
- SPI-attached TPM (ST33)
- USB host and peripheral controllers
- Power and reset keys
Also adds a talos-lyra-evk-el2 composite DTB combining
talos-lyra-evk.dtb with the talos-el2 overlay for hypervisor-enabled
configurations.
Co-developed-by: Akash Kumar <akakum@qti.qualcomm.com>
Signed-off-by: Akash Kumar <akakum@qti.qualcomm.com>
Co-developed-by: Khalid Faisal Ansari <khalid.ansari@oss.qualcomm.com>
Signed-off-by: Khalid Faisal Ansari <khalid.ansari@oss.qualcomm.com>
Co-developed-by: Vishnu Santhosh <vishnu.santhosh@oss.qualcomm.com>
Signed-off-by: Vishnu Santhosh <vishnu.santhosh@oss.qualcomm.com>
Co-developed-by: Vishnu Saini <vishsain@qti.qualcomm.com>
Signed-off-by: Vishnu Saini <vishsain@qti.qualcomm.com>
Tested-by: Nirmesh Kumar Singh <nirmesh.singh@oss.qualcomm.com>
Signed-off-by: Avaneesh Kumar Dwivedi <avaneesh.dwivedi@oss.qualcomm.com>
Signed-off-by: Ruchira Revdekar <ruchira.revdekar@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/Makefile | 5 ++
arch/arm64/boot/dts/qcom/talos-lyra-evk.dts | 115 ++++++++++++++++++++++++++++
2 files changed, 120 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index 88230c4e00ea..243231692866 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -471,6 +471,11 @@ dtb-$(CONFIG_ARCH_QCOM) += talos-evk-lvds-auo,g133han01.dtb
talos-evk-rpi-display-2-5in-dtbs := \
talos-evk.dtb talos-evk-rpi-display-2-5in.dtbo
dtb-$(CONFIG_ARCH_QCOM) += talos-evk-rpi-display-2-5in.dtb
+dtb-$(CONFIG_ARCH_QCOM) += talos-lyra-evk.dtb
+
+talos-lyra-evk-el2-dtbs := talos-lyra-evk.dtb talos-el2.dtbo
+
+dtb-$(CONFIG_ARCH_QCOM) += talos-lyra-evk-el2.dtb
x1e001de-devkit-el2-dtbs := x1e001de-devkit.dtb x1-el2.dtbo
dtb-$(CONFIG_ARCH_QCOM) += x1e001de-devkit.dtb x1e001de-devkit-el2.dtb
x1e78100-lenovo-thinkpad-t14s-el2-dtbs := x1e78100-lenovo-thinkpad-t14s.dtb x1-el2.dtbo
diff --git a/arch/arm64/boot/dts/qcom/talos-lyra-evk.dts b/arch/arm64/boot/dts/qcom/talos-lyra-evk.dts
new file mode 100644
index 000000000000..d4468e609911
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/talos-lyra-evk.dts
@@ -0,0 +1,115 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
+ */
+/dts-v1/;
+
+#include "talos-lyra-evk-som.dtsi"
+
+/ {
+ model = "Qualcomm Technologies, Inc. QCS615 Talos Lyra EVK";
+ compatible = "qcom,talos-lyra-evk", "qcom,qcs615", "qcom,sm6150";
+ chassis-type = "embedded";
+
+ dp0-connector {
+ compatible = "dp-connector";
+ label = "DP0";
+ type = "full-size";
+
+ port {
+ dp0_connector_in: endpoint {
+ remote-endpoint = <&mdss_dp0_out>;
+ };
+ };
+ };
+};
+
+&i2c5 {
+ clock-frequency = <100000>;
+
+ status = "okay";
+
+ expander0: gpio@20 {
+ compatible = "kinetic,kts1622", "ti,tcal6416";
+ reg = <0x20>;
+ #gpio-cells = <2>;
+ gpio-controller;
+ };
+
+ expander1: gpio@21 {
+ compatible = "kinetic,kts1622", "ti,tcal6416";
+ reg = <0x21>;
+ #gpio-cells = <2>;
+ gpio-controller;
+ };
+
+ expander2: gpio@38 {
+ compatible = "ti,tca9538";
+ reg = <0x38>;
+ #gpio-cells = <2>;
+ gpio-controller;
+ };
+
+ expander3: gpio@3c {
+ compatible = "ti,tca9538";
+ reg = <0x3c>;
+ #gpio-cells = <2>;
+ gpio-controller;
+ };
+};
+
+&mdss {
+ status = "okay";
+};
+
+&mdss_dp0 {
+ pinctrl-0 = <&dp_hot_plug_det>;
+ pinctrl-names = "default";
+
+ status = "okay";
+};
+
+&mdss_dp0_out {
+ link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000>;
+ remote-endpoint = <&dp0_connector_in>;
+};
+
+&pon_pwrkey {
+ status = "okay";
+};
+
+&pon_resin {
+ linux,code = <KEY_VOLUMEDOWN>;
+
+ status = "okay";
+};
+
+&spi6 {
+ status = "okay";
+
+ tpm@0 {
+ compatible = "st,st33htpm-spi", "tcg,tpm_tis-spi";
+ reg = <0>;
+ spi-max-frequency = <20000000>;
+ };
+};
+
+&tlmm {
+ dp_hot_plug_det: dp-hot-plug-det-state {
+ pins = "gpio104";
+ function = "dp_hot";
+ bias-disable;
+ };
+};
+
+&usb_1 {
+ dr_mode = "peripheral";
+
+ status = "okay";
+};
+
+&usb_2 {
+ dr_mode = "host";
+
+ status = "okay";
+};
--
2.43.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-10-27 18:41 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-27 11:31 [PATCH v3 0/3] Add support for Talos Lyra EVK board Ruchira Revdekar
2026-10-27 11:31 ` [PATCH v3 1/3] dt-bindings: arm: qcom: Add " Ruchira Revdekar
2026-10-27 18:41 ` Krzysztof Kozlowski
2026-10-27 11:31 ` [PATCH v3 2/3] arm64: dts: qcom: talos: Add Talos Lyra EVK SoM platform Ruchira Revdekar
2026-10-27 11:53 ` sashiko-bot
2026-10-27 11:31 ` [PATCH v3 3/3] arm64: dts: qcom: talos: Add Talos Lyra EVK board Ruchira Revdekar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.