* [PATCH] arm64: Add copy_mc_to_kernel() that recovers from synchronous external aborts
@ 2026-10-28 4:50 Adi Nikumbh
2026-10-29 4:50 ` sashiko-bot
0 siblings, 1 reply; 2+ messages in thread
From: Adi Nikumbh @ 2026-10-28 4:50 UTC (permalink / raw)
To: Catalin Marinas, Will Deacon
Cc: Adi Nikumbh, Mark Rutland, Tony Luck, Miaohe Lin, Naoya Horiguchi,
Tong Tiangen, Ruidong Tian, linux-arm-kernel, linux-mm,
linux-kernel
Without ACPI APEI firmware-first error handling, as on Zynq UltraScale+
boards using synopsys_edac, an uncorrectable DRAM ECC error reaches the
CPU as a synchronous external abort (SEA). When the kernel itself reads
the bad memory, do_sea() can only die.
fs/coredump.c already copies each page with copy_mc_to_kernel() when the
architecture provides it, so that a poisoned page ends the dump rather
than the kernel. arm64 does not provide it. A process killed with SIGBUS
by a SEA on poisoned memory is then dumped with a plain memcpy(), which
reads the same memory again from kernel mode and oopses.
The oops is worse than the original error. The dumping thread dies
before coredump_finish(), so every other thread of the process stays in
exit_mm() in TASK_UNINTERRUPTIBLE, waiting for a dump that never
completes. The process cannot be killed, and a service manager waiting
for it to exit cannot restart it.
Provide copy_mc_to_kernel() for arm64. Its source loads carry a new
EX_TYPE_KACCESS_MC exception table entry. When a kernel-mode SEA lands
on one of those loads, do_sea() moves the PC to the fixup and the copy
returns the number of bytes it did not copy. fixup_exception() does not
handle the new type, so other faults on these loads behave as they do
for memcpy(). The kernel is still tainted with TAINT_MACHINE_CHECK.
Only an EL1 data abort with an external abort fault status is
recovered. Aborts on instruction fetches or translation table walks
still die, and so does an error that a CPU with the RAS extension
reports as uncontainable.
Recovery does not depend on apei_claim_sea(). A SEA on a load is
synchronous and precise: the load did not complete, so resuming at the
fixup is safe however the error was reported. do_sea() still calls
apei_claim_sea() before resuming so that firmware-first systems record
and handle the error.
Defining copy_mc_to_kernel also gives its existing users the same
behaviour on arm64: copy_mc_highpage() and copy_mc_user_highpage(),
which queue memory_failure() for the source page on failure, and the
pmem, DAX, dm-writecache and dm-pcache drivers. copy_mc_to_user() and
ARCH_HAS_COPY_MC are left for later.
Signed-off-by: Adi Nikumbh <nikumbh.adi@gmail.com>
---
Notes:
Testing: arm64 defconfig with EDAC_SYNOPSYS, MEMORY_FAILURE,
BLK_DEV_PMEM=m, DM_WRITECACHE=m, DEV_DAX=m and WERROR builds without
warnings; fs/coredump.o now calls copy_mc_to_kernel(). Tested in QEMU
virt (TCG, cortex-a53) with an out-of-tree module, where a load from an
unassigned physical address raises a synchronous external abort (ESR
0x96000010). Without this patch, copy_mc_to_kernel() from that address
oopses in memcpy(). With the patch, it returns the full length as not
copied, sets TAINT_MACHINE_CHECK, leaves the destination unchanged and
the kernel continues. copy_mc_to_kernel() on RAM matches memcpy() for
sizes 0 to 4096 at offsets 0 to 2. Instruction-fetch, table-walk and
RAS-uncontainable aborts still die, but QEMU cannot raise those on the
annotated loads, so that is checked by review only. Not yet
tested on ZynqMP hardware or with a real DRAM ECC error, and not
through the coredump path end to end.
Prior work: Ruidong Tian's "arm64: add ARCH_HAS_COPY_MC support" v15 [1],
which continues Tong Tiangen's series, does more (copy_mc_to_user(),
copy_mc_[user]_highpage(), ARCH_HAS_COPY_MC), but its do_sea() only
applies the kernel fixup after apei_claim_sea() succeeds, so it does not
help systems without APEI firmware-first handling. This patch is the
smaller piece that does. The two conflict, since both add an exception
table type and a memcpy_mc.S. If v15 is the preferred base, I am happy
to rework this as a follow-up on top of it. If the arm64 maintainers want
the APEI gating kept, I would welcome guidance on how DT-only systems
should opt in.
[1] https://lore.kernel.org/all/20260618092124.3901230-1-tianruidong@linux.alibaba.com/
Tool use: this patch was drafted with an LLM coding assistant
(Anthropic's Claude). It traced the coredump and do_sea() paths,
drafted the architecture, the code, the changelog and the QEMU test
module, and ran the builds, checkpatch and the QEMU tests. A second
model (OpenAI's) reviewed the patch; its findings restricted recovery
to EL1 data aborts with an external abort fault status.
arch/arm64/include/asm/asm-extable.h | 9 ++++++
arch/arm64/include/asm/esr.h | 1 +
arch/arm64/include/asm/extable.h | 1 +
arch/arm64/include/asm/uaccess.h | 4 +++
arch/arm64/lib/Makefile | 2 ++
arch/arm64/lib/copy_mc.c | 28 +++++++++++++++++
arch/arm64/lib/memcpy_mc.S | 45 ++++++++++++++++++++++++++++
arch/arm64/mm/extable.c | 15 ++++++++++
arch/arm64/mm/fault.c | 33 ++++++++++++++++++++
9 files changed, 138 insertions(+)
create mode 100644 arch/arm64/lib/copy_mc.c
create mode 100644 arch/arm64/lib/memcpy_mc.S
diff --git a/arch/arm64/include/asm/asm-extable.h b/arch/arm64/include/asm/asm-extable.h
index d67e2fdd1ae..60cbadff723 100644
--- a/arch/arm64/include/asm/asm-extable.h
+++ b/arch/arm64/include/asm/asm-extable.h
@@ -11,6 +11,7 @@
#define EX_TYPE_KACCESS_ERR_ZERO 3
#define EX_TYPE_UACCESS_CPY 4
#define EX_TYPE_LOAD_UNALIGNED_ZEROPAD 5
+#define EX_TYPE_KACCESS_MC 6
/* Data fields for EX_TYPE_UACCESS_ERR_ZERO */
#define EX_DATA_REG_ERR_SHIFT 0
@@ -77,6 +78,14 @@
__ASM_EXTABLE_RAW(\insn, \fixup, EX_TYPE_UACCESS_CPY, \uaccess_is_write)
.endm
+/*
+ * Create an exception table entry for a kernel load in copy_mc_to_kernel(),
+ * which will branch to `fixup` only on a synchronous external abort.
+ */
+ .macro _asm_extable_kaccess_mc, insn, fixup
+ __ASM_EXTABLE_RAW(\insn, \fixup, EX_TYPE_KACCESS_MC, 0)
+ .endm
+
#else /* __ASSEMBLER__ */
#include <linux/stringify.h>
diff --git a/arch/arm64/include/asm/esr.h b/arch/arm64/include/asm/esr.h
index a584f88dbaf..8436c8d4668 100644
--- a/arch/arm64/include/asm/esr.h
+++ b/arch/arm64/include/asm/esr.h
@@ -105,6 +105,7 @@
#define ESR_ELx_VNCR (UL(1) << ESR_ELx_VNCR_SHIFT)
#define ESR_ELx_SET_SHIFT (11)
#define ESR_ELx_SET_MASK (UL(3) << ESR_ELx_SET_SHIFT)
+#define ESR_ELx_SET_UC (UL(2) << ESR_ELx_SET_SHIFT)
#define ESR_ELx_FnV_SHIFT (10)
#define ESR_ELx_FnV (UL(1) << ESR_ELx_FnV_SHIFT)
#define ESR_ELx_EA_SHIFT (9)
diff --git a/arch/arm64/include/asm/extable.h b/arch/arm64/include/asm/extable.h
index 9dc39612bdf..2629a2fe18c 100644
--- a/arch/arm64/include/asm/extable.h
+++ b/arch/arm64/include/asm/extable.h
@@ -48,4 +48,5 @@ bool ex_handler_bpf(const struct exception_table_entry *ex,
#endif /* !CONFIG_BPF_JIT */
bool fixup_exception(struct pt_regs *regs, unsigned long esr);
+bool fixup_exception_mc(struct pt_regs *regs);
#endif
diff --git a/arch/arm64/include/asm/uaccess.h b/arch/arm64/include/asm/uaccess.h
index 9f5bd9c69c2..19596fa3d67 100644
--- a/arch/arm64/include/asm/uaccess.h
+++ b/arch/arm64/include/asm/uaccess.h
@@ -474,6 +474,10 @@ extern long strncpy_from_user(char *dest, const char __user *src, long count);
extern __must_check long strnlen_user(const char __user *str, long n);
+unsigned long __must_check
+copy_mc_to_kernel(void *to, const void *from, size_t size);
+#define copy_mc_to_kernel copy_mc_to_kernel
+
#ifdef CONFIG_ARCH_HAS_UACCESS_FLUSHCACHE
extern unsigned long __must_check __copy_user_flushcache(void *to, const void __user *from, unsigned long n);
diff --git a/arch/arm64/lib/Makefile b/arch/arm64/lib/Makefile
index 38ffd359123..2772ce3ead9 100644
--- a/arch/arm64/lib/Makefile
+++ b/arch/arm64/lib/Makefile
@@ -11,6 +11,8 @@ lib-y := clear_user.o delay.o copy_from_user.o \
lib-$(CONFIG_ARCH_HAS_UACCESS_FLUSHCACHE) += uaccess_flushcache.o
+obj-y += copy_mc.o memcpy_mc.o
+
obj-$(CONFIG_FUNCTION_ERROR_INJECTION) += error-inject.o
obj-$(CONFIG_ARM64_MTE) += mte.o
diff --git a/arch/arm64/lib/copy_mc.c b/arch/arm64/lib/copy_mc.c
new file mode 100644
index 00000000000..365df3bfea3
--- /dev/null
+++ b/arch/arm64/lib/copy_mc.c
@@ -0,0 +1,28 @@
+// SPDX-License-Identifier: GPL-2.0-only
+
+#include <linux/export.h>
+#include <linux/instrumented.h>
+#include <linux/uaccess.h>
+
+unsigned long __memcpy_mc(void *to, const void *from, unsigned long n);
+
+/**
+ * copy_mc_to_kernel - copy memory, surviving uncorrectable source errors
+ * @to: destination address
+ * @from: source address
+ * @size: number of bytes to copy
+ *
+ * Return: 0 on success, otherwise the number of bytes not copied because a
+ * source load hit memory with an uncorrectable error.
+ */
+unsigned long __must_check copy_mc_to_kernel(void *to, const void *from, size_t size)
+{
+ unsigned long ret;
+
+ instrument_memcpy_before(to, from, size);
+ ret = __memcpy_mc(to, from, size);
+ instrument_memcpy_after(to, from, size, ret);
+
+ return ret;
+}
+EXPORT_SYMBOL_GPL(copy_mc_to_kernel);
diff --git a/arch/arm64/lib/memcpy_mc.S b/arch/arm64/lib/memcpy_mc.S
new file mode 100644
index 00000000000..e34a86bc0d2
--- /dev/null
+++ b/arch/arm64/lib/memcpy_mc.S
@@ -0,0 +1,45 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+
+#include <linux/linkage.h>
+#include <asm/asm-extable.h>
+#include <asm/assembler.h>
+
+/*
+ * Copy memory whose source may contain an uncorrectable error. A synchronous
+ * external abort on a source load stops the copy instead of killing the
+ * kernel. Faults of any other kind are handled as they are for memcpy().
+ *
+ * Parameters:
+ * x0 - dest
+ * x1 - src
+ * x2 - n
+ * Returns:
+ * x0 - bytes not copied
+ */
+SYM_FUNC_START(__memcpy_mc)
+ cmp x2, #8
+ b.lo .Lbytes
+.Lwords:
+1: ldr x3, [x1], #8
+ str x3, [x0], #8
+ sub x2, x2, #8
+ cmp x2, #8
+ b.hs .Lwords
+.Lbytes:
+ cbz x2, .Ldone
+2: ldrb w3, [x1], #1
+ strb w3, [x0], #1
+ subs x2, x2, #1
+ b.ne 2b
+.Ldone:
+ mov x0, #0
+ ret
+
+ /* The faulting load did not complete, so x2 still counts its bytes */
+.Lfault:
+ mov x0, x2
+ ret
+SYM_FUNC_END(__memcpy_mc)
+
+ _asm_extable_kaccess_mc 1b, .Lfault
+ _asm_extable_kaccess_mc 2b, .Lfault
diff --git a/arch/arm64/mm/extable.c b/arch/arm64/mm/extable.c
index 299a244f68e..22b0356664b 100644
--- a/arch/arm64/mm/extable.c
+++ b/arch/arm64/mm/extable.c
@@ -105,7 +105,22 @@ bool fixup_exception(struct pt_regs *regs, unsigned long esr)
return ex_handler_uaccess_cpy(ex, regs, esr);
case EX_TYPE_LOAD_UNALIGNED_ZEROPAD:
return ex_handler_load_unaligned_zeropad(ex, regs);
+ case EX_TYPE_KACCESS_MC:
+ /* Only a synchronous external abort is fixed up, by fixup_exception_mc() */
+ return false;
}
BUG();
}
+
+bool fixup_exception_mc(struct pt_regs *regs)
+{
+ const struct exception_table_entry *ex;
+
+ ex = search_exception_tables(instruction_pointer(regs));
+ if (!ex || ex->type != EX_TYPE_KACCESS_MC)
+ return false;
+
+ regs->pc = get_ex_fixup(ex);
+ return true;
+}
diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c
index b22736853fc..f65304f29f6 100644
--- a/arch/arm64/mm/fault.c
+++ b/arch/arm64/mm/fault.c
@@ -874,6 +874,26 @@ static int do_bad(unsigned long far, unsigned long esr, struct pt_regs *regs)
return 1; /* "fault" */
}
+/*
+ * A kernel data abort on memory with an uncorrectable error can be recovered
+ * by copy_mc_to_kernel(). Aborts on instruction fetches or translation table
+ * walks cannot, and neither can errors the CPU reports as uncontainable.
+ */
+static bool is_el1_recoverable_sea(unsigned long esr)
+{
+ if (!is_el1_data_abort(esr))
+ return false;
+
+ if ((esr & ESR_ELx_FSC) != ESR_ELx_FSC_EXTABT)
+ return false;
+
+ if (cpus_have_cap(ARM64_HAS_RAS_EXTN) &&
+ (esr & ESR_ELx_SET_MASK) == ESR_ELx_SET_UC)
+ return false;
+
+ return true;
+}
+
static int do_sea(unsigned long far, unsigned long esr, struct pt_regs *regs)
{
const struct fault_info *inf;
@@ -889,6 +909,19 @@ static int do_sea(unsigned long far, unsigned long esr, struct pt_regs *regs)
return 0;
}
+ if (!user_mode(regs) && is_el1_recoverable_sea(esr) &&
+ fixup_exception_mc(regs)) {
+ /*
+ * copy_mc_to_kernel() read memory with an uncorrectable error.
+ * It returns the bytes it could not copy and its caller handles
+ * the failure, so the kernel does not need to die. Firmware-first
+ * systems still get to record the error.
+ */
+ apei_claim_sea(regs);
+ add_taint(TAINT_MACHINE_CHECK, LOCKDEP_STILL_OK);
+ return 0;
+ }
+
if (esr & ESR_ELx_FnV) {
siaddr = 0;
} else {
base-commit: 8a36f53fd5ec3eff01f1b637d42cbdc3821d0493
--
2.53.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm64: Add copy_mc_to_kernel() that recovers from synchronous external aborts
2026-10-28 4:50 [PATCH] arm64: Add copy_mc_to_kernel() that recovers from synchronous external aborts Adi Nikumbh
@ 2026-10-29 4:50 ` sashiko-bot
0 siblings, 0 replies; 2+ messages in thread
From: sashiko-bot @ 2026-10-29 4:50 UTC (permalink / raw)
To: Adi Nikumbh, Catalin Marinas, Will Deacon
Cc: Mark Rutland, Tony Luck, Miaohe Lin, Naoya Horiguchi,
Tong Tiangen, Ruidong Tian, linux-mm
Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
- [Critical] arm64: copy_mc_to_kernel macro bypasses MTE, KASAN, and cache page copy
- [High] arm64: extable: insn_may_access_user() livelocks on EX_TYPE_KACCESS_MC
- [High] arm64: fault: do_sea() apei_claim_sea() sends SIGBUS on recovered fault
--
commit 5a611f7bbfb0b0b0a16c229590b9cf45b688ab1a
Author: Adi Nikumbh <nikumbh.adi@gmail.com>
arm64: Add copy_mc_to_kernel() that recovers from synchronous external aborts
This commit adds copy_mc_to_kernel() and the EX_TYPE_KACCESS_MC exception
table type on arm64 so kernel loads from poisoned memory can recover from
synchronous external aborts instead of oopsing. In do_sea(), EL1 data aborts
matching an external abort fault status on an EX_TYPE_KACCESS_MC instruction
branch to the fixup and call apei_claim_sea().
> diff --git a/arch/arm64/include/asm/uaccess.h b/arch/arm64/include/asm/uaccess.h
> index 9f5bd9c69c249..19596fa3d6706 100644
> --- a/arch/arm64/include/asm/uaccess.h
> +++ b/arch/arm64/include/asm/uaccess.h
> @@ -474,6 +474,10 @@ extern long strncpy_from_user(char *dest, const char __user *src, long count);
>
> extern __must_check long strnlen_user(const char __user *str, long n);
>
> +unsigned long __must_check
> +copy_mc_to_kernel(void *to, const void *from, size_t size);
> +#define copy_mc_to_kernel copy_mc_to_kernel
[Severity: Critical]
Does defining the copy_mc_to_kernel macro here without arm64-specific
copy_mc_highpage() and copy_mc_user_highpage() implementations bypass MTE tag
handling, KASAN tag resets, and D-cache maintenance on page copies?
In include/linux/highmem.h, defining copy_mc_to_kernel switches
copy_mc_user_highpage() and copy_mc_highpage() away from calling arm64's
copy_user_highpage() and copy_highpage() in arch/arm64/mm/copypage.c:
include/linux/highmem.h:
#ifdef copy_mc_to_kernel
static inline int copy_mc_user_highpage(struct page *to, struct page *from,
unsigned long vaddr, struct vm_area_struct *vma)
{
unsigned long ret;
char *vfrom, *vto;
vfrom = kmap_local_page(from);
vto = kmap_local_page(to);
ret = copy_mc_to_kernel(vto, vfrom, PAGE_SIZE);
...
}
Callers on the Copy-on-Write and page migration paths (such as
__wp_page_copy_user(), do_cow_fault(), copy_present_page(),
copy_user_large_folio(), and folio_mc_copy()) now invoke
copy_mc_to_kernel() directly instead of arch/arm64/mm/copypage.c:
arch/arm64/mm/copypage.c:copy_highpage() {
...
copy_page(kto, kfrom);
if (kasan_hw_tags_enabled())
page_kasan_tag_reset(to);
if (!system_supports_mte())
return;
if (folio_test_hugetlb(src) &&
folio_test_hugetlb_mte_tagged(src)) {
if (!folio_try_hugetlb_mte_tagging(dst))
return;
mte_copy_page_tags(kto, kfrom);
folio_set_hugetlb_mte_tagged(dst);
} else if (page_mte_tagged(from)) {
try_page_mte_tagging(to);
mte_copy_page_tags(kto, kfrom);
set_page_mte_tagged(to);
}
}
arch/arm64/mm/copypage.c:copy_user_highpage() {
copy_highpage(to, from);
flush_dcache_page(to);
}
Skipping copy_user_highpage() and copy_highpage() causes four regressions:
1. MTE tags are not copied via mte_copy_page_tags() and PG_mte_tagged is left
unset on the destination page. When set_pte_at() later calls
__sync_cache_and_tags() -> mte_sync_tags() in arch/arm64/kernel/mte.c, it
sees PG_mte_tagged unset and zeroes all tags on the destination page via
mte_clear_page_tags(), corrupting userspace MTE tags across CoW faults and
migrations.
2. page_kasan_tag_reset(to) is skipped when kasan_hw_tags_enabled() is true.
3. flush_dcache_page(to) is skipped on user page copies, leaving
PG_dcache_clean stale when executable pages are copied.
4. Every CoW fault and page migration drops from copy_page() (which uses
FEAT_MOPS or 128-byte ldp/stnp loops) to the 8-byte ldr/str loop in
__memcpy_mc().
> diff --git a/arch/arm64/mm/extable.c b/arch/arm64/mm/extable.c
> index 299a244f68e60..22b0356664bea 100644
> --- a/arch/arm64/mm/extable.c
> +++ b/arch/arm64/mm/extable.c
> @@ -105,7 +105,22 @@ bool fixup_exception(struct pt_regs *regs, unsigned long esr)
> return ex_handler_uaccess_cpy(ex, regs, esr);
> case EX_TYPE_LOAD_UNALIGNED_ZEROPAD:
> return ex_handler_load_unaligned_zeropad(ex, regs);
> + case EX_TYPE_KACCESS_MC:
> + /* Only a synchronous external abort is fixed up, by fixup_exception_mc() */
> + return false;
> }
[Severity: High]
Should insn_may_access_user() in arch/arm64/mm/extable.c also return false for
EX_TYPE_KACCESS_MC?
Currently, insn_may_access_user() returns true in its default branch for all
exception table types other than EX_TYPE_UACCESS_CPY:
arch/arm64/mm/extable.c:insn_may_access_user() {
const struct exception_table_entry *ex = search_exception_tables(addr);
if (!ex)
return false;
switch (ex->type) {
case EX_TYPE_UACCESS_CPY:
return cpy_faulted_on_uaccess(ex, esr);
default:
return true;
}
}
Unlike copy_from_kernel_nofault() (which runs with pagefault_disable() so
do_page_fault() immediately takes the no_context path into fixup_exception()),
copy_mc_to_kernel() runs with page faults enabled.
If copy_mc_to_kernel() -> __memcpy_mc() is passed a TTBR0 address (such as a
user pointer or NULL with CONFIG_ARM64_SW_TTBR0_PAN) in process context, the
privileged ldr/ldrb in __memcpy_mc() triggers a permission fault with PAN
active:
do_page_fault()
if (is_ttbr0_addr(addr) && is_el1_permission_fault(addr, esr, regs)) {
...
if (!insn_may_access_user(regs->pc, esr))
die_kernel_fault("access to user memory outside uaccess routines",
addr, esr, regs);
}
Because insn_may_access_user() returns true for EX_TYPE_KACCESS_MC,
do_page_fault() skips die_kernel_fault(), takes current->mm's VMA / mmap lock,
and calls handle_mm_fault(). If the address is mapped in a readable user VMA,
handle_mm_fault() succeeds and do_page_fault() returns 0 without advancing
regs->pc or clearing PAN, causing the eret to re-execute the same ldr/ldrb
instruction in an infinite page-fault loop.
> diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c
> index b22736853fcd8..f65304f29f683 100644
> --- a/arch/arm64/mm/fault.c
> +++ b/arch/arm64/mm/fault.c
[ ... ]
> @@ -889,6 +909,19 @@ static int do_sea(unsigned long far, unsigned long esr, struct pt_regs *regs)
> return 0;
> }
>
> + if (!user_mode(regs) && is_el1_recoverable_sea(esr) &&
> + fixup_exception_mc(regs)) {
> + /*
> + * copy_mc_to_kernel() read memory with an uncorrectable error.
> + * It returns the bytes it could not copy and its caller handles
> + * the failure, so the kernel does not need to die. Firmware-first
> + * systems still get to record the error.
> + */
> + apei_claim_sea(regs);
> + add_taint(TAINT_MACHINE_CHECK, LOCKDEP_STILL_OK);
> + return 0;
> + }
[Severity: High]
Won't calling apei_claim_sea(regs) here cause ACPI APEI GHES to send SIGBUS to
current even though the kernel already recovered from the fault via
fixup_exception_mc()?
When apei_claim_sea() runs ghes_notify_sea() -> ghes_proc_in_irq() ->
ghes_do_proc() in drivers/acpi/apei/ghes.c, sync is true because
is_hest_sync_notify(ghes) is true for ACPI_HEST_NOTIFY_SEA:
1. If no memory failure work is queued (!queued, for example when
CONFIG_ACPI_APEI_MEMORY_FAILURE=n or the CPER record lacks a valid physical
address), ghes_do_proc() unconditionally forces SIGBUS on current:
drivers/acpi/apei/ghes.c:ghes_do_proc() {
...
if (sync && !queued) {
dev_err(ghes->dev,
HW_ERR GHES_PFX "%s:%d: synchronous unrecoverable error (SIGBUS)\n",
current->comm, task_pid_nr(current));
force_sig(SIGBUS);
}
}
2. If memory failure work is queued, ghes_do_memory_failure() sets
flags = MF_ACTION_REQUIRED because sync is true, and when current->mm is
non-NULL it queues memory_failure_cb() as TWA_RESUME task_work on current:
drivers/acpi/apei/ghes.c:memory_failure_cb() {
...
ret = memory_failure(twcb->pfn, twcb->flags);
gen_pool_free(ghes_estatus_pool, (unsigned long)twcb, sizeof(*twcb));
if (!ret || ret == -EHWPOISON || ret == -EOPNOTSUPP)
return;
pr_err("%#llx: Sending SIGBUS to %s:%d due to hardware memory corruption\n",
twcb->pfn, current->comm, task_pid_nr(current));
force_sig(SIGBUS);
}
When copy_mc_to_kernel() is called on behalf of a kernel subsystem (such as
pmem, dax, dm-writecache, or page migration) and recovers from the SEA,
memory_failure(pfn, MF_ACTION_REQUIRED) will either signal current or return
an error like -ENXIO, -EBUSY, or -EFAULT (when the PFN is not mapped in
current->mm), causing memory_failure_cb() to kill the calling user task with
SIGBUS instead of letting the caller handle the failed copy.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261028045028.72644-1-nikumbh.adi@gmail.com?part=1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-10-29 4:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-28 4:50 [PATCH] arm64: Add copy_mc_to_kernel() that recovers from synchronous external aborts Adi Nikumbh
2026-10-29 4:50 ` sashiko-bot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.