Re: [PATCH 1/8] MIPS: mm/c-octeon: fix missing function prototype warnings

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] MIPS: mm/c-octeon: missing prototypes for cache_parity_error_octeon_*()
--

commit 710759b5db134c7d9627997d6bd1fbab4fe6465b
Author: Randy Dunlap <rdunlap@infradead.org>

MIPS: mm/c-octeon: fix missing function prototype warnings

This commit adds missing cache error notifier prototypes to asm/r4kcache.h and
removes local extern declarations from drivers/edac/octeon_edac-pc.c to address
-Wmissing-prototypes warnings.

> diff --git a/arch/mips/include/asm/r4kcache.h b/arch/mips/include/asm/r4kcache.h
> index da1cd1bbdbc5d..8c36d228075f3 100644
> --- a/arch/mips/include/asm/r4kcache.h
> +++ b/arch/mips/include/asm/r4kcache.h
> @@ -31,6 +31,9 @@ extern int mips_sc_init(void);
>  extern void (*r4k_blast_dcache)(void);
>  extern void (*r4k_blast_icache)(void);
>  
> +extern int register_co_cache_error_notifier(struct notifier_block *nb);
> +extern int unregister_co_cache_error_notifier(struct notifier_block *nb);

[Severity: Medium]
The commit message lists four -Wmissing-prototypes warnings in
arch/mips/mm/c-octeon.c that this change aims to eliminate:

  register_co_cache_error_notifier()
  unregister_co_cache_error_notifier()
  cache_parity_error_octeon_recoverable()
  cache_parity_error_octeon_non_recoverable()

However, asm/r4kcache.h only adds prototypes for
register_co_cache_error_notifier() and unregister_co_cache_error_notifier().

In arch/mips/mm/c-octeon.c, cache_parity_error_octeon_recoverable() and
cache_parity_error_octeon_non_recoverable() are non-static functions called
from assembly in arch/mips/mm/cex-oct.S:

  asmlinkage void cache_parity_error_octeon_recoverable(void)
  {
          co_cache_error_call_notifiers(0);
  }

  asmlinkage void cache_parity_error_octeon_non_recoverable(void)
  {
          co_cache_error_call_notifiers(1);
          panic("Can't handle cache error: nested exception");
  }

Should prototypes for cache_parity_error_octeon_recoverable() and
cache_parity_error_octeon_non_recoverable() also be added here so those two
warnings are resolved as described in the changelog?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261030164657.2808262-1-rdunlap@infradead.org?part=1