[PATCH 0/8] MIPS: Octeon: fix missing function prototype warnings

[PATCH 0/8] MIPS: Octeon: fix missing function prototype warnings

[Randy Dunlap]

Add missing function prototypes to header files in most cases;
use the header files in the C source files.
In 2 cases, make the functions static so that no prototype is
needed.


 [PATCH 1/8] MIPS: mm/c-octeon: fix missing function prototype warnings
 [PATCH 2/8] MIPS: Octeon: cvmx-helper: fix missing function prototype warning
 [PATCH 3/8] MIPS: Octeon: cvmx-interrupt: fix missing function prototype warning
 [PATCH 4/8] MIPS: c-octeon: fix missing function prototype warning
 [PATCH 5/8] MIPS: Octeon: octeon-platform: fix missing function prototype warning
 [PATCH 6/8] MIPS: msi-octeon: fix missing function prototype warning
 [PATCH 7/8] MIPS: Octeon: pci: fix missing function prototype warnings
 [PATCH 8/8] MIPS: Octeon: octeon.h: fix missing function prototype warning


 arch/mips/cavium-octeon/executive/cvmx-helper-errata.c |    1 +
 arch/mips/cavium-octeon/executive/cvmx-helper.c        |    1 +
 arch/mips/cavium-octeon/executive/cvmx-interrupt-rsl.c |    2 --
 arch/mips/cavium-octeon/setup.c                        |    2 --
 arch/mips/include/asm/octeon/cvmx-gmxx-defs.h          |    1 +
 arch/mips/include/asm/octeon/octeon.h                  |    3 +++
 arch/mips/include/asm/r4kcache.h                       |    3 +++
 arch/mips/mm/c-octeon.c                                |    1 -
 arch/mips/pci/msi-octeon.c                             |    2 +-
 arch/mips/pci/pci-octeon.c                             |    2 +-
 arch/mips/pci/pcie-octeon.c                            |    2 +-
 drivers/edac/octeon_edac-pc.c                          |    4 +---
 12 files changed, 13 insertions(+), 11 deletions(-)


Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: linux-mips@vger.kernel.org
Cc: linux-edac@vger.kernel.org
Cc: linux-watchdog@vger.kernel.org

[PATCH 1/8] MIPS: mm/c-octeon: fix missing function prototype warnings

[Randy Dunlap]

Add missing cache function prototypes to <asm/r4kcache.h> and remove
2 local prototypes from the edac driver to eliminate build warnings:

arch/mips/mm/c-octeon.c:297:5: warning: no previous prototype for 'register_co_cache_error_notifier' [-Wmissing-prototypes]
  297 | int register_co_cache_error_notifier(struct notifier_block *nb)
arch/mips/mm/c-octeon.c:303:5: warning: no previous prototype for 'unregister_co_cache_error_notifier' [-Wmissing-prototypes]
  303 | int unregister_co_cache_error_notifier(struct notifier_block *nb)
arch/mips/mm/c-octeon.c:342:17: warning: no previous prototype for 'cache_parity_error_octeon_recoverable' [-Wmissing-prototypes]
  342 | asmlinkage void cache_parity_error_octeon_recoverable(void)
arch/mips/mm/c-octeon.c:351:17: warning: no previous prototype for 'cache_parity_error_octeon_non_recoverable' [-Wmissing-prototypes]
  351 | asmlinkage void cache_parity_error_octeon_non_recoverable(void)

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: linux-edac@vger.kernel.org
Cc: linux-mips@vger.kernel.org

 arch/mips/include/asm/r4kcache.h |    3 +++
 drivers/edac/octeon_edac-pc.c    |    4 +---
 2 files changed, 4 insertions(+), 3 deletions(-)

--- linux-next-20261028.orig/arch/mips/include/asm/r4kcache.h
+++ linux-next-20261028/arch/mips/include/asm/r4kcache.h
@@ -31,6 +31,9 @@ extern int mips_sc_init(void);
 extern void (*r4k_blast_dcache)(void);
 extern void (*r4k_blast_icache)(void);
 
+extern int register_co_cache_error_notifier(struct notifier_block *nb);
+extern int unregister_co_cache_error_notifier(struct notifier_block *nb);
+
 /*
  * This macro return a properly sign-extended address suitable as base address
  * for indexed cache operations.  Two issues here:
--- linux-next-20261028.orig/drivers/edac/octeon_edac-pc.c
+++ linux-next-20261028/drivers/edac/octeon_edac-pc.c
@@ -19,9 +19,7 @@
 
 #include <asm/octeon/cvmx.h>
 #include <asm/mipsregs.h>
-
-extern int register_co_cache_error_notifier(struct notifier_block *nb);
-extern int unregister_co_cache_error_notifier(struct notifier_block *nb);
+#include <asm/r4kcache.h>
 
 extern unsigned long long cache_err_dcache[NR_CPUS];
 

Re: [PATCH 1/8] MIPS: mm/c-octeon: fix missing function prototype warnings

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] MIPS: mm/c-octeon: missing prototypes for cache_parity_error_octeon_*()
--

commit 710759b5db134c7d9627997d6bd1fbab4fe6465b
Author: Randy Dunlap <rdunlap@infradead.org>

MIPS: mm/c-octeon: fix missing function prototype warnings

This commit adds missing cache error notifier prototypes to asm/r4kcache.h and
removes local extern declarations from drivers/edac/octeon_edac-pc.c to address
-Wmissing-prototypes warnings.

> diff --git a/arch/mips/include/asm/r4kcache.h b/arch/mips/include/asm/r4kcache.h
> index da1cd1bbdbc5d..8c36d228075f3 100644
> --- a/arch/mips/include/asm/r4kcache.h
> +++ b/arch/mips/include/asm/r4kcache.h
> @@ -31,6 +31,9 @@ extern int mips_sc_init(void);
>  extern void (*r4k_blast_dcache)(void);
>  extern void (*r4k_blast_icache)(void);
>  
> +extern int register_co_cache_error_notifier(struct notifier_block *nb);
> +extern int unregister_co_cache_error_notifier(struct notifier_block *nb);

[Severity: Medium]
The commit message lists four -Wmissing-prototypes warnings in
arch/mips/mm/c-octeon.c that this change aims to eliminate:

  register_co_cache_error_notifier()
  unregister_co_cache_error_notifier()
  cache_parity_error_octeon_recoverable()
  cache_parity_error_octeon_non_recoverable()

However, asm/r4kcache.h only adds prototypes for
register_co_cache_error_notifier() and unregister_co_cache_error_notifier().

In arch/mips/mm/c-octeon.c, cache_parity_error_octeon_recoverable() and
cache_parity_error_octeon_non_recoverable() are non-static functions called
from assembly in arch/mips/mm/cex-oct.S:

  asmlinkage void cache_parity_error_octeon_recoverable(void)
  {
          co_cache_error_call_notifiers(0);
  }

  asmlinkage void cache_parity_error_octeon_non_recoverable(void)
  {
          co_cache_error_call_notifiers(1);
          panic("Can't handle cache error: nested exception");
  }

Should prototypes for cache_parity_error_octeon_recoverable() and
cache_parity_error_octeon_non_recoverable() also be added here so those two
warnings are resolved as described in the changelog?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261030164657.2808262-1-rdunlap@infradead.org?part=1

Re: [PATCH 1/8] MIPS: mm/c-octeon: fix missing function prototype warnings

[Randy Dunlap]

On 10/30/26 9:53 AM, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] MIPS: mm/c-octeon: missing prototypes for cache_parity_error_octeon_*()
> --
> 
> commit 710759b5db134c7d9627997d6bd1fbab4fe6465b
> Author: Randy Dunlap <rdunlap@infradead.org>
> 
> MIPS: mm/c-octeon: fix missing function prototype warnings
> 
> This commit adds missing cache error notifier prototypes to asm/r4kcache.h and
> removes local extern declarations from drivers/edac/octeon_edac-pc.c to address
> -Wmissing-prototypes warnings.
> 
>> diff --git a/arch/mips/include/asm/r4kcache.h b/arch/mips/include/asm/r4kcache.h
>> index da1cd1bbdbc5d..8c36d228075f3 100644
>> --- a/arch/mips/include/asm/r4kcache.h
>> +++ b/arch/mips/include/asm/r4kcache.h
>> @@ -31,6 +31,9 @@ extern int mips_sc_init(void);
>>  extern void (*r4k_blast_dcache)(void);
>>  extern void (*r4k_blast_icache)(void);
>>  
>> +extern int register_co_cache_error_notifier(struct notifier_block *nb);
>> +extern int unregister_co_cache_error_notifier(struct notifier_block *nb);
> 
> [Severity: Medium]
> The commit message lists four -Wmissing-prototypes warnings in
> arch/mips/mm/c-octeon.c that this change aims to eliminate:
> 
>   register_co_cache_error_notifier()
>   unregister_co_cache_error_notifier()
>   cache_parity_error_octeon_recoverable()
>   cache_parity_error_octeon_non_recoverable()
> 
> However, asm/r4kcache.h only adds prototypes for
> register_co_cache_error_notifier() and unregister_co_cache_error_notifier().
> 
> In arch/mips/mm/c-octeon.c, cache_parity_error_octeon_recoverable() and
> cache_parity_error_octeon_non_recoverable() are non-static functions called
> from assembly in arch/mips/mm/cex-oct.S:
> 
>   asmlinkage void cache_parity_error_octeon_recoverable(void)
>   {
>           co_cache_error_call_notifiers(0);
>   }
> 
>   asmlinkage void cache_parity_error_octeon_non_recoverable(void)
>   {
>           co_cache_error_call_notifiers(1);
>           panic("Can't handle cache error: nested exception");
>   }
> 
> Should prototypes for cache_parity_error_octeon_recoverable() and
> cache_parity_error_octeon_non_recoverable() also be added here so those two
> warnings are resolved as described in the changelog?
> 

Yes, I'll add those and send v2.

-- 
~Randy

[PATCH 2/8] MIPS: Octeon: cvmx-helper: fix missing function prototype warning

[Randy Dunlap]

The missing function prototype is already in cvmx-helper-errata.h.
Use that header file in cvmx-helper.c and cvmx-helper-errata.c
to eliminate a build warning:

arch/mips/cavium-octeon/executive/cvmx-helper-errata.c:49:6: warning: no previous prototype for '__cvmx_helper_errata_qlm_disable_2nd_order_cdr' [-Wmissing-prototypes]
   49 | void __cvmx_helper_errata_qlm_disable_2nd_order_cdr(int qlm)

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: linux-mips@vger.kernel.org

 arch/mips/cavium-octeon/executive/cvmx-helper-errata.c |    1 +
 arch/mips/cavium-octeon/executive/cvmx-helper.c        |    1 +
 2 files changed, 2 insertions(+)

--- linux-next-20261028.orig/arch/mips/cavium-octeon/executive/cvmx-helper.c
+++ linux-next-20261028/arch/mips/cavium-octeon/executive/cvmx-helper.c
@@ -42,6 +42,7 @@
 #include <asm/octeon/cvmx-spi.h>
 #include <asm/octeon/cvmx-helper.h>
 #include <asm/octeon/cvmx-helper-board.h>
+#include <asm/octeon/cvmx-helper-errata.h>
 
 #include <asm/octeon/cvmx-pip-defs.h>
 #include <asm/octeon/cvmx-asxx-defs.h>
--- linux-next-20261028.orig/arch/mips/cavium-octeon/executive/cvmx-helper-errata.c
+++ linux-next-20261028/arch/mips/cavium-octeon/executive/cvmx-helper-errata.c
@@ -37,6 +37,7 @@
 
 #include <asm/octeon/octeon.h>
 
+#include <asm/octeon/cvmx-helper-errata.h>
 #include <asm/octeon/cvmx-helper-jtag.h>
 
 /**

[PATCH 3/8] MIPS: Octeon: cvmx-interrupt: fix missing function prototype warning

[Randy Dunlap]

Add the missing interrupt function prototype to <asm/octeon/cvmx-gmxx-defs.h>
and remove the local prototype from cvmx-interrupt-rsl.c to eliminate
a build warning:

arch/mips/cavium-octeon/executive/cvmx-interrupt-decodes.c:53:6: warning: no previous prototype for '__cvmx_interrupt_gmxx_rxx_int_en_enable' [-Wmissing-prototypes]
   53 | void __cvmx_interrupt_gmxx_rxx_int_en_enable(int index, int block)

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: linux-mips@vger.kernel.org

 arch/mips/cavium-octeon/executive/cvmx-interrupt-rsl.c |    2 --
 arch/mips/include/asm/octeon/cvmx-gmxx-defs.h          |    1 +
 2 files changed, 1 insertion(+), 2 deletions(-)

--- linux-next-20261028.orig/arch/mips/include/asm/octeon/cvmx-gmxx-defs.h
+++ linux-next-20261028/arch/mips/include/asm/octeon/cvmx-gmxx-defs.h
@@ -339,6 +339,7 @@ static inline uint64_t CVMX_GMXX_TX_XAUI
 }
 
 void __cvmx_interrupt_gmxx_enable(int interface);
+void __cvmx_interrupt_gmxx_rxx_int_en_enable(int index, int block);
 
 union cvmx_gmxx_hg2_control {
 	uint64_t u64;
--- linux-next-20261028.orig/arch/mips/cavium-octeon/executive/cvmx-interrupt-rsl.c
+++ linux-next-20261028/arch/mips/cavium-octeon/executive/cvmx-interrupt-rsl.c
@@ -39,8 +39,6 @@
 #define PRINT_ERROR(format, ...)
 #endif
 
-void __cvmx_interrupt_gmxx_rxx_int_en_enable(int index, int block);
-
 /**
  * Enable ASX error interrupts that exist on CN3XXX, CN50XX, and
  * CN58XX.

[PATCH 4/8] MIPS: c-octeon: fix missing function prototype warning

[Randy Dunlap]

Add the missing IPI function prototype to <asm/octeon/octeon.h> and
remove the local prototype from mm/c-octeon.c to eliminate a build warning:

arch/mips/cavium-octeon/smp.c:100:6: warning: no previous prototype for 'octeon_send_ipi_single' [-Wmissing-prototypes]
  100 | void octeon_send_ipi_single(int cpu, unsigned int action)

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: linux-mips@vger.kernel.org

 arch/mips/include/asm/octeon/octeon.h |    1 +
 arch/mips/mm/c-octeon.c               |    1 -
 2 files changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20261028.orig/arch/mips/mm/c-octeon.c
+++ linux-next-20261028/arch/mips/mm/c-octeon.c
@@ -62,7 +62,6 @@ static void local_octeon_flush_icache_ra
  */
 static void octeon_flush_icache_all_cores(struct vm_area_struct *vma)
 {
-	extern void octeon_send_ipi_single(int cpu, unsigned int action);
 #ifdef CONFIG_SMP
 	int cpu;
 	cpumask_t mask;
--- linux-next-20261028.orig/arch/mips/include/asm/octeon/octeon.h
+++ linux-next-20261028/arch/mips/include/asm/octeon/octeon.h
@@ -298,6 +298,7 @@ static inline void octeon_npi_write32(ui
 
 #ifdef CONFIG_SMP
 void octeon_setup_smp(void);
+void octeon_send_ipi_single(int cpu, unsigned int action);
 #else
 static inline void octeon_setup_smp(void) {}
 #endif

[PATCH 5/8] MIPS: Octeon: octeon-platform: fix missing function prototype warning

[Randy Dunlap]

Add the missing octeon_fill_mac_addresses() function prototype to
<asm/octeon/octeon.h> and remove the local prototype from setup.c to
eliminate a build warning:

arch/mips/cavium-octeon/octeon-platform.c:701:13: warning: no previous prototype for 'octeon_fill_mac_addresses' [-Wmissing-prototypes]
  701 | void __init octeon_fill_mac_addresses(void)

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: linux-mips@vger.kernel.org

 arch/mips/cavium-octeon/setup.c       |    2 --
 arch/mips/include/asm/octeon/octeon.h |    1 +
 2 files changed, 1 insertion(+), 2 deletions(-)

--- linux-next-20261028.orig/arch/mips/include/asm/octeon/octeon.h
+++ linux-next-20261028/arch/mips/include/asm/octeon/octeon.h
@@ -48,6 +48,7 @@ extern void octeon_user_io_init(void);
 extern void octeon_init_cvmcount(void);
 extern void octeon_setup_delays(void);
 extern void octeon_io_clk_delay(unsigned long);
+void __init octeon_fill_mac_addresses(void);
 
 #define OCTEON_ARGV_MAX_ARGS	64
 #define OCTEON_SERIAL_LEN	20
--- linux-next-20261028.orig/arch/mips/cavium-octeon/setup.c
+++ linux-next-20261028/arch/mips/cavium-octeon/setup.c
@@ -1156,8 +1156,6 @@ void __init prom_free_prom_memory(void)
 	}
 }
 
-void __init octeon_fill_mac_addresses(void);
-
 void __init device_tree_init(void)
 {
 	const void *fdt = NULL;

[PATCH 6/8] MIPS: msi-octeon: fix missing function prototype warning

[Randy Dunlap]

octeon_msi_intialize() isn't used outside of this source file so it can
be static to eliminate a build warning:

arch/mips/pci/msi-octeon.c:343:12: warning: no previous prototype for 'octeon_msi_initialize' [-Wmissing-prototypes]
  343 | int __init octeon_msi_initialize(void)

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: linux-mips@vger.kernel.org

 arch/mips/pci/msi-octeon.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20261028.orig/arch/mips/pci/msi-octeon.c
+++ linux-next-20261028/arch/mips/pci/msi-octeon.c
@@ -340,7 +340,7 @@ OCTEON_MSI_INT_HANDLER_X(3);
 /*
  * Initializes the MSI interrupt handling code
  */
-int __init octeon_msi_initialize(void)
+static int __init octeon_msi_initialize(void)
 {
 	int irq;
 	struct irq_chip *msi;

[PATCH 7/8] MIPS: Octeon: pci: fix missing function prototype warnings

[Randy Dunlap]

The octeon_pci[e]_pcibios_map_irq() functions are not used outside of
their source files, so they can be static to eliminate build warnings:

arch/mips/pci/pci-octeon.c:234:12: warning: no previous prototype for 'octeon_pci_pcibios_map_irq' [-Wmissing-prototypes]
  234 | int __init octeon_pci_pcibios_map_irq(const struct pci_dev *dev,
arch/mips/pci/pcie-octeon.c:1471:5: warning: no previous prototype for 'octeon_pcie_pcibios_map_irq' [-Wmissing-prototypes]
 1471 | int octeon_pcie_pcibios_map_irq(const struct pci_dev *dev, u8 slot, u8 pin)

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: linux-mips@vger.kernel.org

 arch/mips/pci/pci-octeon.c  |    2 +-
 arch/mips/pci/pcie-octeon.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

--- linux-next-20261028.orig/arch/mips/pci/pcie-octeon.c
+++ linux-next-20261028/arch/mips/pci/pcie-octeon.c
@@ -1468,7 +1468,7 @@ static int cvmx_pcie_rc_initialize(int p
  *		 as it goes through each bridge.
  * Returns Interrupt number for the device
  */
-int octeon_pcie_pcibios_map_irq(const struct pci_dev *dev, u8 slot, u8 pin)
+static int octeon_pcie_pcibios_map_irq(const struct pci_dev *dev, u8 slot, u8 pin)
 {
 	/*
 	 * The EBH5600 board with the PCI to PCIe bridge mistakenly
--- linux-next-20261028.orig/arch/mips/pci/pci-octeon.c
+++ linux-next-20261028/arch/mips/pci/pci-octeon.c
@@ -231,7 +231,7 @@ const char *octeon_get_pci_interrupts(vo
  *		 as it goes through each bridge.
  * Returns Interrupt number for the device
  */
-int __init octeon_pci_pcibios_map_irq(const struct pci_dev *dev,
+static int __init octeon_pci_pcibios_map_irq(const struct pci_dev *dev,
 				      u8 slot, u8 pin)
 {
 	int irq_num;

[PATCH 8/8] MIPS: Octeon: octeon.h: fix missing function prototype warning

[Randy Dunlap]

Add the missing octeon_wdt_nmi_stage3() function prototype to
<asm/octeon/octeon.h> to eliminate a build warning:

drivers/watchdog/octeon-wdt-main.c:211:6: warning: no previous prototype for 'octeon_wdt_nmi_stage3' [-Wmissing-prototypes]
  211 | void octeon_wdt_nmi_stage3(u64 reg[32])

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: linux-mips@vger.kernel.org
Cc: linux-watchdog@vger.kernel.org

 arch/mips/include/asm/octeon/octeon.h |    1 +
 1 file changed, 1 insertion(+)

--- linux-next-20261028.orig/arch/mips/include/asm/octeon/octeon.h
+++ linux-next-20261028/arch/mips/include/asm/octeon/octeon.h
@@ -49,6 +49,7 @@ extern void octeon_init_cvmcount(void);
 extern void octeon_setup_delays(void);
 extern void octeon_io_clk_delay(unsigned long);
 void __init octeon_fill_mac_addresses(void);
+void octeon_wdt_nmi_stage3(u64 reg[32]);
 
 #define OCTEON_ARGV_MAX_ARGS	64
 #define OCTEON_SERIAL_LEN	20