From: sashiko-bot@kernel.org
To: "Ian Rogers" <irogers@google.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 1/3] perf callchain: Fix loss of symbol in merge_chain_branch()
Date: Sat, 31 Oct 2026 06:39:44 +0000 [thread overview]
Message-ID: <sashiko-outbox-191784@kernel.org> (raw)
In-Reply-To: <20261031063549.1281324-2-irogers@google.com>
> Commit bffb5b0c0976 ("perf map/maps/thread: Changes to reference
> counting") replaced passing &list->ms to callchain_cursor_append() in
> merge_chain_branch() with a temporary struct map_symbol initialized with
> .thread and .map, but omitted .sym = list->ms.sym.
>
> As a result, callchains merged during histogram collapse lose their
> resolved struct symbol pointer, causing 'perf report --children' to
> print raw hexadecimal addresses instead of function names and inlined
> frames on merged callchain branches.
>
> Initialize .sym = list->ms.sym in the temporary struct map_symbol in
> merge_chain_branch().
>
> Fixes: bffb5b0c0976 ("perf map/maps/thread: Changes to reference counting")
> Suggested-by: Alireza Haghdoost <haghdoost@uber.com>
> Signed-off-by: Ian Rogers <irogers@google.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261031063549.1281324-1-irogers@google.com?part=1
next prev parent reply other threads:[~2026-10-31 6:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-31 6:35 [PATCH 0/3] perf symbols/callchain/annotate: Bug fixes from symbol reference counting review Ian Rogers
2026-10-31 6:35 ` [PATCH 1/3] perf callchain: Fix loss of symbol in merge_chain_branch() Ian Rogers
2026-10-31 6:39 ` sashiko-bot [this message]
2026-10-31 6:35 ` [PATCH 2/3] perf symbol-elf: Fix zero-size symbol end calculation across .symtab and .dynsym Ian Rogers
2026-10-31 6:41 ` sashiko-bot
2026-10-31 6:35 ` [PATCH 3/3] perf annotate: Fix block_range symbol loss on split and leaks on exit Ian Rogers
2026-10-31 6:47 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-191784@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=irogers@google.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.