Re: [PATCH 3/3] perf annotate: Fix block_range symbol loss on split and leaks on exit

[sashiko-bot@kernel.org]

> When block_range__create() splits an existing struct block_range entry
> into a leading head range (entry->start < start) or a trailing tail
> range (end < entry->end), it copies coverage and branch statistics from
> the original entry into head/tail, but omits .sym = entry->sym. Because
> the returned iterator only spans [start, end], process_basic_block()
> never revisits the split-off head or tail range, leaving its .sym NULL
> and causing block_range__coverage() to return -1 on instructions in that
> split range.
> 
> Additionally, the global block_ranges rbtree is never freed on exit from
> cmd_annotate(), and process_branch_stack() frees the resolved
> branch_info array without calling addr_map_symbol__exit() on bi[i].to
> and bi[i].from, leaking thread and map references acquired by
> sample__resolve_bstack().
> 
> Preserve .sym = entry->sym when splitting head and tail in
> block_range__create(), add block_ranges__exit() and call it from
> cmd_annotate(), and release bi[i].to and bi[i].from in
> process_branch_stack().
> 
> Fixes: 70fbe0574558 ("perf annotate: Add branch stack / basic block")
> Fixes: bffb5b0c0976 ("perf map/maps/thread: Changes to reference counting")
> Suggested-by: Alireza Haghdoost <haghdoost@uber.com>
> Signed-off-by: Ian Rogers <irogers@google.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261031063549.1281324-1-irogers@google.com?part=3