* [PATCH] firmware: raspberrypi: Add bcm2712 revD compatible check
@ 2026-11-02 17:02 Peter Robinson
2026-11-02 17:07 ` sashiko-bot
2026-11-02 17:36 ` Sander Speetjens
0 siblings, 2 replies; 3+ messages in thread
From: Peter Robinson @ 2026-11-02 17:02 UTC (permalink / raw)
To: Florian Fainelli, bcm-kernel-feedback-list, Alexandre Belloni,
Sander Speetjens, linux-rpi-kernel, linux-arm-kernel, linux-rtc,
Stefan Wahren
Cc: Peter Robinson
The bcm2712 revD doesn't contain the base SoC compatible of the revC
because they're not fully compatible, we need to check both else we
don't match for newer devices and the RTC doesn't get enumerated.
Fixes: dba67294e2151 ("rtc: Add Raspberry Pi 5 RTC driver")
Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
---
drivers/firmware/raspberrypi.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/firmware/raspberrypi.c b/drivers/firmware/raspberrypi.c
index 443459c8c90fa..ab1c77aeb199c 100644
--- a/drivers/firmware/raspberrypi.c
+++ b/drivers/firmware/raspberrypi.c
@@ -240,7 +240,8 @@ static void rpi_register_rtc_driver(struct device *dev)
* Check if our model of Raspberry Pi board is from the 5th gen
* as the RTC is only present on that model.
*/
- if (!of_machine_is_compatible("brcm,bcm2712"))
+ if (!(of_machine_is_compatible("brcm,bcm2712") ||
+ of_machine_is_compatible("brcm,bcm2712-d0")))
return;
pdev = platform_device_register_data(dev, "raspberrypi-rtc",
--
2.56.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] firmware: raspberrypi: Add bcm2712 revD compatible check
2026-11-02 17:02 [PATCH] firmware: raspberrypi: Add bcm2712 revD compatible check Peter Robinson
@ 2026-11-02 17:07 ` sashiko-bot
2026-11-02 17:36 ` Sander Speetjens
1 sibling, 0 replies; 3+ messages in thread
From: sashiko-bot @ 2026-11-02 17:07 UTC (permalink / raw)
To: Peter Robinson, linux-rtc; +Cc: Alexandre Belloni
> The bcm2712 revD doesn't contain the base SoC compatible of the revC
> because they're not fully compatible, we need to check both else we
> don't match for newer devices and the RTC doesn't get enumerated.
>
> Fixes: dba67294e2151 ("rtc: Add Raspberry Pi 5 RTC driver")
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261102170227.1719206-1-pbrobinson@gmail.com?part=1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] firmware: raspberrypi: Add bcm2712 revD compatible check
2026-11-02 17:02 [PATCH] firmware: raspberrypi: Add bcm2712 revD compatible check Peter Robinson
2026-11-02 17:07 ` sashiko-bot
@ 2026-11-02 17:36 ` Sander Speetjens
1 sibling, 0 replies; 3+ messages in thread
From: Sander Speetjens @ 2026-11-02 17:36 UTC (permalink / raw)
To: Peter Robinson
Cc: Florian Fainelli, bcm-kernel-feedback-list, Alexandre Belloni,
linux-rpi-kernel, linux-arm-kernel, linux-rtc, Stefan Wahren
On Mon, 2 Nov 2026 at 18:02, Peter Robinson <pbrobinson@gmail.com> wrote:
>
> The bcm2712 revD doesn't contain the base SoC compatible of the revC
> because they're not fully compatible, we need to check both else we
> don't match for newer devices and the RTC doesn't get enumerated.
>
> Fixes: dba67294e2151 ("rtc: Add Raspberry Pi 5 RTC driver")
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
Reviewed-by: Sander Speetjens <sander.speetjens@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-11-02 17:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-02 17:02 [PATCH] firmware: raspberrypi: Add bcm2712 revD compatible check Peter Robinson
2026-11-02 17:07 ` sashiko-bot
2026-11-02 17:36 ` Sander Speetjens
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.